Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54287/?format=api
{ "id": 54287, "url": "http://patches.dpdk.org/api/patches/54287/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190604054248.68510-12-leyi.rong@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190604054248.68510-12-leyi.rong@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190604054248.68510-12-leyi.rong@intel.com", "date": "2019-06-04T05:42:10", "name": "[11/49] net/ice/base: rollback AVF RSS configurations", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e1c73acd0eda00ab66544aef51820915a3e522b2", "submitter": { "id": 1204, "url": "http://patches.dpdk.org/api/people/1204/?format=api", "name": "Leyi Rong", "email": "leyi.rong@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190604054248.68510-12-leyi.rong@intel.com/mbox/", "series": [ { "id": 4879, "url": "http://patches.dpdk.org/api/series/4879/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4879", "date": "2019-06-04T05:41:59", "name": "shared code update", "version": 1, "mbox": "http://patches.dpdk.org/series/4879/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54287/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/54287/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 186AE1BA64;\n\tTue, 4 Jun 2019 07:44:17 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id 7EF811B9DD\n\tfor <dev@dpdk.org>; Tue, 4 Jun 2019 07:44:06 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t03 Jun 2019 22:44:06 -0700", "from lrong-srv-03.sh.intel.com ([10.67.119.177])\n\tby fmsmga008.fm.intel.com with ESMTP; 03 Jun 2019 22:44:04 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Leyi Rong <leyi.rong@intel.com>", "To": "qi.z.zhang@intel.com", "Cc": "dev@dpdk.org, Leyi Rong <leyi.rong@intel.com>,\n\tVignesh Sridhar <vignesh.sridhar@intel.com>,\n\tPaul M Stillwell Jr <paul.m.stillwell.jr@intel.com>", "Date": "Tue, 4 Jun 2019 13:42:10 +0800", "Message-Id": "<20190604054248.68510-12-leyi.rong@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190604054248.68510-1-leyi.rong@intel.com>", "References": "<20190604054248.68510-1-leyi.rong@intel.com>", "Subject": "[dpdk-dev] [PATCH 11/49] net/ice/base: rollback AVF RSS\n\tconfigurations", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Adding support to remove RSS configurations added\nprior to failing case in AVF.\n\nSigned-off-by: Vignesh Sridhar <vignesh.sridhar@intel.com>\nSigned-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>\nSigned-off-by: Leyi Rong <leyi.rong@intel.com>\n---\n drivers/net/ice/base/ice_flow.c | 128 ++++++++++++++++++++++++++++++++\n 1 file changed, 128 insertions(+)", "diff": "diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_flow.c\nindex f1bf5b5e7..d97fe1fc7 100644\n--- a/drivers/net/ice/base/ice_flow.c\n+++ b/drivers/net/ice/base/ice_flow.c\n@@ -1915,6 +1915,134 @@ ice_rem_rss_cfg_sync(struct ice_hw *hw, u16 vsi_handle, u64 hashed_flds,\n \treturn status;\n }\n \n+/* Mapping of AVF hash bit fields to an L3-L4 hash combination.\n+ * As the ice_flow_avf_hdr_field represent individual bit shifts in a hash,\n+ * convert its values to their appropriate flow L3, L4 values.\n+ */\n+#define ICE_FLOW_AVF_RSS_IPV4_MASKS \\\n+\t(BIT_ULL(ICE_AVF_FLOW_FIELD_IPV4_OTHER) | \\\n+\t BIT_ULL(ICE_AVF_FLOW_FIELD_FRAG_IPV4))\n+#define ICE_FLOW_AVF_RSS_TCP_IPV4_MASKS \\\n+\t(BIT_ULL(ICE_AVF_FLOW_FIELD_IPV4_TCP_SYN_NO_ACK) | \\\n+\t BIT_ULL(ICE_AVF_FLOW_FIELD_IPV4_TCP))\n+#define ICE_FLOW_AVF_RSS_UDP_IPV4_MASKS \\\n+\t(BIT_ULL(ICE_AVF_FLOW_FIELD_UNICAST_IPV4_UDP) | \\\n+\t BIT_ULL(ICE_AVF_FLOW_FIELD_MULTICAST_IPV4_UDP) | \\\n+\t BIT_ULL(ICE_AVF_FLOW_FIELD_IPV4_UDP))\n+#define ICE_FLOW_AVF_RSS_ALL_IPV4_MASKS \\\n+\t(ICE_FLOW_AVF_RSS_TCP_IPV4_MASKS | ICE_FLOW_AVF_RSS_UDP_IPV4_MASKS | \\\n+\t ICE_FLOW_AVF_RSS_IPV4_MASKS | BIT_ULL(ICE_AVF_FLOW_FIELD_IPV4_SCTP))\n+\n+#define ICE_FLOW_AVF_RSS_IPV6_MASKS \\\n+\t(BIT_ULL(ICE_AVF_FLOW_FIELD_IPV6_OTHER) | \\\n+\t BIT_ULL(ICE_AVF_FLOW_FIELD_FRAG_IPV6))\n+#define ICE_FLOW_AVF_RSS_UDP_IPV6_MASKS \\\n+\t(BIT_ULL(ICE_AVF_FLOW_FIELD_UNICAST_IPV6_UDP) | \\\n+\t BIT_ULL(ICE_AVF_FLOW_FIELD_MULTICAST_IPV6_UDP) | \\\n+\t BIT_ULL(ICE_AVF_FLOW_FIELD_IPV6_UDP))\n+#define ICE_FLOW_AVF_RSS_TCP_IPV6_MASKS \\\n+\t(BIT_ULL(ICE_AVF_FLOW_FIELD_IPV6_TCP_SYN_NO_ACK) | \\\n+\t BIT_ULL(ICE_AVF_FLOW_FIELD_IPV6_TCP))\n+#define ICE_FLOW_AVF_RSS_ALL_IPV6_MASKS \\\n+\t(ICE_FLOW_AVF_RSS_TCP_IPV6_MASKS | ICE_FLOW_AVF_RSS_UDP_IPV6_MASKS | \\\n+\t ICE_FLOW_AVF_RSS_IPV6_MASKS | BIT_ULL(ICE_AVF_FLOW_FIELD_IPV6_SCTP))\n+\n+#define ICE_FLOW_MAX_CFG\t10\n+\n+/**\n+ * ice_add_avf_rss_cfg - add an RSS configuration for AVF driver\n+ * @hw: pointer to the hardware structure\n+ * @vsi_handle: software VSI handle\n+ * @avf_hash: hash bit fields (ICE_AVF_FLOW_FIELD_*) to configure\n+ *\n+ * This function will take the hash bitmap provided by the AVF driver via a\n+ * message, convert it to ICE-compatible values, and configure RSS flow\n+ * profiles.\n+ */\n+enum ice_status\n+ice_add_avf_rss_cfg(struct ice_hw *hw, u16 vsi_handle, u64 avf_hash)\n+{\n+\tenum ice_status status = ICE_SUCCESS;\n+\tu64 hash_flds;\n+\n+\tif (avf_hash == ICE_AVF_FLOW_FIELD_INVALID ||\n+\t !ice_is_vsi_valid(hw, vsi_handle))\n+\t\treturn ICE_ERR_PARAM;\n+\n+\t/* Make sure no unsupported bits are specified */\n+\tif (avf_hash & ~(ICE_FLOW_AVF_RSS_ALL_IPV4_MASKS |\n+\t\t\t ICE_FLOW_AVF_RSS_ALL_IPV6_MASKS))\n+\t\treturn ICE_ERR_CFG;\n+\n+\thash_flds = avf_hash;\n+\n+\t/* Always create an L3 RSS configuration for any L4 RSS configuration */\n+\tif (hash_flds & ICE_FLOW_AVF_RSS_ALL_IPV4_MASKS)\n+\t\thash_flds |= ICE_FLOW_AVF_RSS_IPV4_MASKS;\n+\n+\tif (hash_flds & ICE_FLOW_AVF_RSS_ALL_IPV6_MASKS)\n+\t\thash_flds |= ICE_FLOW_AVF_RSS_IPV6_MASKS;\n+\n+\t/* Create the corresponding RSS configuration for each valid hash bit */\n+\twhile (hash_flds) {\n+\t\tu64 rss_hash = ICE_HASH_INVALID;\n+\n+\t\tif (hash_flds & ICE_FLOW_AVF_RSS_ALL_IPV4_MASKS) {\n+\t\t\tif (hash_flds & ICE_FLOW_AVF_RSS_IPV4_MASKS) {\n+\t\t\t\trss_hash = ICE_FLOW_HASH_IPV4;\n+\t\t\t\thash_flds &= ~ICE_FLOW_AVF_RSS_IPV4_MASKS;\n+\t\t\t} else if (hash_flds &\n+\t\t\t\t ICE_FLOW_AVF_RSS_TCP_IPV4_MASKS) {\n+\t\t\t\trss_hash = ICE_FLOW_HASH_IPV4 |\n+\t\t\t\t\tICE_FLOW_HASH_TCP_PORT;\n+\t\t\t\thash_flds &= ~ICE_FLOW_AVF_RSS_TCP_IPV4_MASKS;\n+\t\t\t} else if (hash_flds &\n+\t\t\t\t ICE_FLOW_AVF_RSS_UDP_IPV4_MASKS) {\n+\t\t\t\trss_hash = ICE_FLOW_HASH_IPV4 |\n+\t\t\t\t\tICE_FLOW_HASH_UDP_PORT;\n+\t\t\t\thash_flds &= ~ICE_FLOW_AVF_RSS_UDP_IPV4_MASKS;\n+\t\t\t} else if (hash_flds &\n+\t\t\t\t BIT_ULL(ICE_AVF_FLOW_FIELD_IPV4_SCTP)) {\n+\t\t\t\trss_hash = ICE_FLOW_HASH_IPV4 |\n+\t\t\t\t\tICE_FLOW_HASH_SCTP_PORT;\n+\t\t\t\thash_flds &=\n+\t\t\t\t\t~BIT_ULL(ICE_AVF_FLOW_FIELD_IPV4_SCTP);\n+\t\t\t}\n+\t\t} else if (hash_flds & ICE_FLOW_AVF_RSS_ALL_IPV6_MASKS) {\n+\t\t\tif (hash_flds & ICE_FLOW_AVF_RSS_IPV6_MASKS) {\n+\t\t\t\trss_hash = ICE_FLOW_HASH_IPV6;\n+\t\t\t\thash_flds &= ~ICE_FLOW_AVF_RSS_IPV6_MASKS;\n+\t\t\t} else if (hash_flds &\n+\t\t\t\t ICE_FLOW_AVF_RSS_TCP_IPV6_MASKS) {\n+\t\t\t\trss_hash = ICE_FLOW_HASH_IPV6 |\n+\t\t\t\t\tICE_FLOW_HASH_TCP_PORT;\n+\t\t\t\thash_flds &= ~ICE_FLOW_AVF_RSS_TCP_IPV6_MASKS;\n+\t\t\t} else if (hash_flds &\n+\t\t\t\t ICE_FLOW_AVF_RSS_UDP_IPV6_MASKS) {\n+\t\t\t\trss_hash = ICE_FLOW_HASH_IPV6 |\n+\t\t\t\t\tICE_FLOW_HASH_UDP_PORT;\n+\t\t\t\thash_flds &= ~ICE_FLOW_AVF_RSS_UDP_IPV6_MASKS;\n+\t\t\t} else if (hash_flds &\n+\t\t\t\t BIT_ULL(ICE_AVF_FLOW_FIELD_IPV6_SCTP)) {\n+\t\t\t\trss_hash = ICE_FLOW_HASH_IPV6 |\n+\t\t\t\t\tICE_FLOW_HASH_SCTP_PORT;\n+\t\t\t\thash_flds &=\n+\t\t\t\t\t~BIT_ULL(ICE_AVF_FLOW_FIELD_IPV6_SCTP);\n+\t\t\t}\n+\t\t}\n+\n+\t\tif (rss_hash == ICE_HASH_INVALID)\n+\t\t\treturn ICE_ERR_OUT_OF_RANGE;\n+\n+\t\tstatus = ice_add_rss_cfg(hw, vsi_handle, rss_hash,\n+\t\t\t\t\t ICE_FLOW_SEG_HDR_NONE);\n+\t\tif (status)\n+\t\t\tbreak;\n+\t}\n+\n+\treturn status;\n+}\n+\n /**\n * ice_rem_rss_cfg - remove an existing RSS config with matching hashed fields\n * @hw: pointer to the hardware structure\n", "prefixes": [ "11/49" ] }