Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54250/?format=api
{ "id": 54250, "url": "http://patches.dpdk.org/api/patches/54250/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1559583160-13944-26-git-send-email-anoobj@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1559583160-13944-26-git-send-email-anoobj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1559583160-13944-26-git-send-email-anoobj@marvell.com", "date": "2019-06-03T17:32:25", "name": "[25/39] eventdev: add routine to validate conf", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "c1f1dece5ad5419dc229c4bf52b8270420973021", "submitter": { "id": 1205, "url": "http://patches.dpdk.org/api/people/1205/?format=api", "name": "Anoob Joseph", "email": "anoobj@marvell.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1559583160-13944-26-git-send-email-anoobj@marvell.com/mbox/", "series": [ { "id": 4868, "url": "http://patches.dpdk.org/api/series/4868/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4868", "date": "2019-06-03T17:32:00", "name": "adding eventmode helper library", "version": 1, "mbox": "http://patches.dpdk.org/series/4868/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54250/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/54250/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 23D041BB78;\n\tMon, 3 Jun 2019 19:36:16 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n\t[67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 590841BB2A\n\tfor <dev@dpdk.org>; Mon, 3 Jun 2019 19:36:02 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n\tby mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id\n\tx53HKMDT027514; Mon, 3 Jun 2019 10:36:01 -0700", "from sc-exch01.marvell.com ([199.233.58.181])\n\tby mx0b-0016f401.pphosted.com with ESMTP id 2sw79pr6vf-8\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); \n\tMon, 03 Jun 2019 10:36:01 -0700", "from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH01.marvell.com\n\t(10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3;\n\tMon, 3 Jun 2019 10:35:50 -0700", "from maili.marvell.com (10.93.176.43) by SC-EXCH03.marvell.com\n\t(10.93.176.83) with Microsoft SMTP Server id 15.0.1367.3 via Frontend\n\tTransport; Mon, 3 Jun 2019 10:35:50 -0700", "from ajoseph83.caveonetworks.com.com (unknown [10.29.45.56])\n\tby maili.marvell.com (Postfix) with ESMTP id 7B1963F7040;\n\tMon, 3 Jun 2019 10:35:45 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n\th=from : to : cc :\n\tsubject : date : message-id : in-reply-to : references : mime-version\n\t: content-transfer-encoding : content-type; s=pfpt0818;\n\tbh=ClXojWags9Op7SNaZBzdBPN5grj3IWPSly3I/pv2pbI=;\n\tb=D5QDhXPhqnpPTZj52dZaN/+ORXanXiAG4G4LvjaBjycy0QkxeTHasy5gFV+8yjCKA2vC\n\twbv2s6wrvH1DOPTAu/ftGIJ7AZIEJ0ufuHRF7zwon0EiURwzGXzuVZb67C4zNr3wAtGn\n\tH9yRxKPGgfaRlhRqnM2dC0o9XhbqboXim+By5pNpWLFrxNo6kfRT59O+34G5siBNPX3t\n\t2WYhSfIxo6yD82gSmzsCKH8NgbIrabqaddSLGZDp4eSjFtofUx9j0r2GbSvT/H0gbPgP\n\t/u0yAlFDT1s5yc9+iVyjajEWza/serOTc+1blVUYZAzMNHwfXo6LFW7OH48PWFZ1fPeW\n\tKw== ", "From": "Anoob Joseph <anoobj@marvell.com>", "To": "Jerin Jacob <jerinj@marvell.com>, Nikhil Rao <nikhil.rao@intel.com>,\n\t\"Erik Gabriel Carrillo\" <erik.g.carrillo@intel.com>, Abhinandan Gujjar\n\t<abhinandan.gujjar@intel.com>,\n\tBruce Richardson <bruce.richardson@intel.com>,\n\tPablo de Lara <pablo.de.lara.guarch@intel.com>", "CC": "Anoob Joseph <anoobj@marvell.com>, Narayana Prasad <pathreya@marvell.com>,\n\t<dev@dpdk.org>, Lukasz Bartosik <lbartosik@marvell.com>, Pavan Nikhilesh\n\t<pbhagavatula@marvell.com>, Hemant Agrawal <hemant.agrawal@nxp.com>,\n\t\"Nipun Gupta\" <nipun.gupta@nxp.com>, Harry van Haaren\n\t<harry.van.haaren@intel.com>, =?utf-8?q?Mattias_R=C3=B6nnblom?=\n\t<mattias.ronnblom@ericsson.com>, Liang Ma <liang.j.ma@intel.com>", "Date": "Mon, 3 Jun 2019 23:02:25 +0530", "Message-ID": "<1559583160-13944-26-git-send-email-anoobj@marvell.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1559583160-13944-1-git-send-email-anoobj@marvell.com>", "References": "<1559583160-13944-1-git-send-email-anoobj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:, ,\n\tdefinitions=2019-06-03_13:, , signatures=0", "Subject": "[dpdk-dev] [PATCH 25/39] eventdev: add routine to validate conf", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Adding routine to validate event mode conf. This function will verify\nthe conf requested by the user and would populate other fields with\ndefault values. Presently, the function acts as placeholder for the\nabove mentioned actions.\n\nSigned-off-by: Anoob Joseph <anoobj@marvell.com>\nSigned-off-by: Lukasz Bartosik <lbartosik@marvell.com>\n---\n lib/librte_eventdev/rte_eventmode_helper.c | 33 ++++++++++++++++++++++++++++++\n 1 file changed, 33 insertions(+)", "diff": "diff --git a/lib/librte_eventdev/rte_eventmode_helper.c b/lib/librte_eventdev/rte_eventmode_helper.c\nindex a57f837..4dbb94a 100644\n--- a/lib/librte_eventdev/rte_eventmode_helper.c\n+++ b/lib/librte_eventdev/rte_eventmode_helper.c\n@@ -165,6 +165,32 @@ rte_eventmode_helper_parse_args(int argc, char **argv)\n \treturn NULL;\n }\n \n+/* Pre-process conf before using for init*/\n+\n+static int\n+rte_eventmode_validate_user_params(struct eventmode_conf *em_conf)\n+{\n+\t/* TODO */\n+\t/* Check sanity of the conf requested by user */\n+\n+\tRTE_SET_USED(em_conf);\n+\n+\treturn 0;\n+}\n+\n+static int\n+rte_eventmode_helper_validate_conf(struct eventmode_conf *em_conf)\n+{\n+\tint ret;\n+\n+\t/* After parsing all args, verify that the conf can be allowed */\n+\tret = rte_eventmode_validate_user_params(em_conf);\n+\tif (ret != 0)\n+\t\treturn ret;\n+\n+\treturn 0;\n+}\n+\n /* Setup eventmode devs */\n \n static int\n@@ -468,6 +494,13 @@ rte_eventmode_helper_initialize_devs(\n \t/* Get eventmode conf */\n \tem_conf = (struct eventmode_conf *)(mode_conf->mode_params);\n \n+\t/* Validate the conf requested */\n+\tif (rte_eventmode_helper_validate_conf(em_conf) != 0) {\n+\t\tRTE_EM_HLPR_LOG_ERR(\n+\t\t\t\"Failed while validating the conf requested\");\n+\t\treturn -1;\n+\t}\n+\n \t/* Stop eth devices before setting up adapter */\n \tRTE_ETH_FOREACH_DEV(portid) {\n \n", "prefixes": [ "25/39" ] }