Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54244/?format=api
{ "id": 54244, "url": "http://patches.dpdk.org/api/patches/54244/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1559583160-13944-25-git-send-email-anoobj@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1559583160-13944-25-git-send-email-anoobj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1559583160-13944-25-git-send-email-anoobj@marvell.com", "date": "2019-06-03T17:32:24", "name": "[24/39] eventdev: add Rx adapter init in eventmode", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "20e6c7f9cbcd3b0d8ca62dab7c374621e6a28e81", "submitter": { "id": 1205, "url": "http://patches.dpdk.org/api/people/1205/?format=api", "name": "Anoob Joseph", "email": "anoobj@marvell.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1559583160-13944-25-git-send-email-anoobj@marvell.com/mbox/", "series": [ { "id": 4868, "url": "http://patches.dpdk.org/api/series/4868/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4868", "date": "2019-06-03T17:32:00", "name": "adding eventmode helper library", "version": 1, "mbox": "http://patches.dpdk.org/series/4868/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54244/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/54244/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DEBD81BB0B;\n\tMon, 3 Jun 2019 19:35:50 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n\t[67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 7F3C41BACC\n\tfor <dev@dpdk.org>; Mon, 3 Jun 2019 19:35:48 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n\tby mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id\n\tx53HKaaU000839; Mon, 3 Jun 2019 10:35:47 -0700", "from sc-exch03.marvell.com ([199.233.58.183])\n\tby mx0a-0016f401.pphosted.com with ESMTP id 2sw2wmhdmj-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); \n\tMon, 03 Jun 2019 10:35:47 -0700", "from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH03.marvell.com\n\t(10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3;\n\tMon, 3 Jun 2019 10:35:47 -0700", "from maili.marvell.com (10.93.176.43) by SC-EXCH03.marvell.com\n\t(10.93.176.83) with Microsoft SMTP Server id 15.0.1367.3 via Frontend\n\tTransport; Mon, 3 Jun 2019 10:35:44 -0700", "from ajoseph83.caveonetworks.com.com (unknown [10.29.45.56])\n\tby maili.marvell.com (Postfix) with ESMTP id 71ABE3F703F;\n\tMon, 3 Jun 2019 10:35:39 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n\th=from : to : cc :\n\tsubject : date : message-id : in-reply-to : references : mime-version\n\t: content-transfer-encoding : content-type; s=pfpt0818;\n\tbh=/yCCdWMB6S1nQe0skeb9bjD4JCQafAdQrIUMvM76vgo=;\n\tb=FiHZyz9k0vwJ46hobxtCTIWhAtSkhCCSP51Cnp3l+jiX05Vn7ckdEyAKTMFzu4NfBIaP\n\t4NbqDWQkt0piIdB/TRJtWOe8/l7LTOeQ5vYHRFLqUXVdtj1YQwpNM6wEzqdmDGDKhH6b\n\tE+dmVXNy07CID+UGooMHHuKhWmqnHDjmgV3rpfKS7HidkT2085C+Q93pYcWUCVR9wwBm\n\t/tovGCYz3VLwV0kgusJMUJJEt5IP7sUILi1pVixlE58XO7zQuYr5/VTxFRK/MXkKDMzP\n\tIVs1EQwhW/C8ku0nT0gFqksqbkN4B7aR0b9ehwGOLaKgKNw71ESxaV/4fGW45I/JjBs5\n\tNQ== ", "From": "Anoob Joseph <anoobj@marvell.com>", "To": "Jerin Jacob <jerinj@marvell.com>, Nikhil Rao <nikhil.rao@intel.com>,\n\t\"Erik Gabriel Carrillo\" <erik.g.carrillo@intel.com>, Abhinandan Gujjar\n\t<abhinandan.gujjar@intel.com>,\n\tBruce Richardson <bruce.richardson@intel.com>,\n\tPablo de Lara <pablo.de.lara.guarch@intel.com>", "CC": "Anoob Joseph <anoobj@marvell.com>, Narayana Prasad <pathreya@marvell.com>,\n\t<dev@dpdk.org>, Lukasz Bartosik <lbartosik@marvell.com>, Pavan Nikhilesh\n\t<pbhagavatula@marvell.com>, Hemant Agrawal <hemant.agrawal@nxp.com>,\n\t\"Nipun Gupta\" <nipun.gupta@nxp.com>, Harry van Haaren\n\t<harry.van.haaren@intel.com>, =?utf-8?q?Mattias_R=C3=B6nnblom?=\n\t<mattias.ronnblom@ericsson.com>, Liang Ma <liang.j.ma@intel.com>", "Date": "Mon, 3 Jun 2019 23:02:24 +0530", "Message-ID": "<1559583160-13944-25-git-send-email-anoobj@marvell.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1559583160-13944-1-git-send-email-anoobj@marvell.com>", "References": "<1559583160-13944-1-git-send-email-anoobj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:, ,\n\tdefinitions=2019-06-03_13:, , signatures=0", "Subject": "[dpdk-dev] [PATCH 24/39] eventdev: add Rx adapter init in eventmode", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Adding rx adapter conf. The helper init routine would be initializing\nthe rx adapter according to the conf.\n\nSigned-off-by: Anoob Joseph <anoobj@marvell.com>\nSigned-off-by: Lukasz Bartosik <lbartosik@marvell.com>\n---\n lib/librte_eventdev/rte_eventmode_helper.c | 123 +++++++++++++++++++++\n .../rte_eventmode_helper_internal.h | 27 +++++\n 2 files changed, 150 insertions(+)", "diff": "diff --git a/lib/librte_eventdev/rte_eventmode_helper.c b/lib/librte_eventdev/rte_eventmode_helper.c\nindex 8faa4ea..a57f837 100644\n--- a/lib/librte_eventdev/rte_eventmode_helper.c\n+++ b/lib/librte_eventdev/rte_eventmode_helper.c\n@@ -6,6 +6,7 @@\n #include <rte_ethdev.h>\n #include <rte_eventdev.h>\n #include <rte_eventmode_helper.h>\n+#include <rte_event_eth_rx_adapter.h>\n #include <rte_malloc.h>\n \n #include \"rte_eventmode_helper_internal.h\"\n@@ -326,6 +327,123 @@ rte_eventmode_helper_initialize_ethdev(struct eventmode_conf *em_conf)\n \treturn 0;\n }\n \n+static int\n+rx_adapter_configure(struct eventmode_conf *em_conf,\n+\tstruct rx_adapter_conf *adapter)\n+{\n+\tint j;\n+\tint ret;\n+\tuint8_t eventdev_id;\n+\tuint32_t service_id;\n+\tstruct adapter_connection_info *conn;\n+\tstruct rte_event_port_conf port_conf = {0};\n+\tstruct rte_event_eth_rx_adapter_queue_conf queue_conf = {0};\n+\tstruct rte_event_dev_info evdev_default_conf = {0};\n+\n+\t/* Get event dev ID */\n+\teventdev_id = adapter->eventdev_id;\n+\n+\t/* Create rx_adapter */\n+\n+\t/* Get default configuration of event dev */\n+\tret = rte_event_dev_info_get(eventdev_id, &evdev_default_conf);\n+\tif (ret < 0) {\n+\t\tRTE_EM_HLPR_LOG_ERR(\n+\t\t\t\"Error in getting event device info[devID:%d]\",\n+\t\t\teventdev_id);\n+\t\treturn ret;\n+\t}\n+\n+\t/* Setup port conf */\n+\tport_conf.new_event_threshold = 1200;\n+\tport_conf.dequeue_depth =\n+\t\t\tevdev_default_conf.max_event_port_dequeue_depth;\n+\tport_conf.enqueue_depth =\n+\t\t\tevdev_default_conf.max_event_port_enqueue_depth;\n+\n+\t/* Create Rx adapter */\n+\tret = rte_event_eth_rx_adapter_create(adapter->adapter_id,\n+\t\t\tadapter->eventdev_id,\n+\t\t\t&port_conf);\n+\tif (ret < 0) {\n+\t\tRTE_EM_HLPR_LOG_ERR(\"Error in rx adapter creation\");\n+\t\treturn ret;\n+\t}\n+\n+\t/* Setup various connections in the adapter */\n+\n+\tqueue_conf.rx_queue_flags =\n+\t\t\tRTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID;\n+\n+\tfor (j = 0; j < adapter->nb_connections; j++) {\n+\t\t/* Get connection */\n+\t\tconn = &(adapter->conn[j]);\n+\n+\t\t/* Setup queue conf */\n+\t\tqueue_conf.ev.queue_id = conn->eventq_id;\n+\t\tqueue_conf.ev.sched_type = em_conf->ext_params.sched_type;\n+\n+\t\t/* Set flow ID as ethdev ID */\n+\t\tqueue_conf.ev.flow_id = conn->ethdev_id;\n+\n+\t\t/* Add queue to the adapter */\n+\t\tret = rte_event_eth_rx_adapter_queue_add(\n+\t\t\t\tadapter->adapter_id,\n+\t\t\t\tconn->ethdev_id,\n+\t\t\t\tconn->ethdev_rx_qid,\n+\t\t\t\t&queue_conf);\n+\t\tif (ret < 0) {\n+\t\t\tRTE_EM_HLPR_LOG_ERR(\n+\t\t\t\t\"Error in adding eth queue in Rx adapter\");\n+\t\t\treturn ret;\n+\t\t}\n+\t}\n+\n+\t/* Get the service ID used by rx adapter */\n+\tret = rte_event_eth_rx_adapter_service_id_get(adapter->adapter_id,\n+\t\t\t\t\t\t &service_id);\n+\tif (ret != -ESRCH && ret != 0) {\n+\t\tRTE_EM_HLPR_LOG_ERR(\n+\t\t\t\"Error getting service ID used by Rx adapter\");\n+\t\treturn ret;\n+\t}\n+\n+\t/*\n+\t * TODO\n+\t * Rx core will invoke the service when required. The runstate check\n+\t * is not required.\n+\t *\n+\t */\n+\trte_service_set_runstate_mapped_check(service_id, 0);\n+\n+\t/* Start adapter */\n+\tret = rte_event_eth_rx_adapter_start(adapter->adapter_id);\n+\tif (ret) {\n+\t\tRTE_EM_HLPR_LOG_ERR(\"Error in starting rx adapter\");\n+\t\treturn ret;\n+\t}\n+\n+\treturn 0;\n+}\n+\n+static int\n+rte_eventmode_helper_initialize_rx_adapter(struct eventmode_conf *em_conf)\n+{\n+\tint i, ret;\n+\tstruct rx_adapter_conf *adapter;\n+\n+\t/* Configure rx adapters */\n+\tfor (i = 0; i < em_conf->nb_rx_adapter; i++) {\n+\t\tadapter = &(em_conf->rx_adapter[i]);\n+\t\tret = rx_adapter_configure(em_conf, adapter);\n+\t\tif (ret < 0) {\n+\t\t\tRTE_EM_HLPR_LOG_ERR(\"Rx adapter configuration failed\");\n+\t\t\treturn ret;\n+\t\t}\n+\t}\n+\treturn 0;\n+}\n+\n int32_t __rte_experimental\n rte_eventmode_helper_initialize_devs(\n \t\tstruct rte_eventmode_helper_conf *mode_conf)\n@@ -370,6 +488,11 @@ rte_eventmode_helper_initialize_devs(\n \tif (ret != 0)\n \t\treturn ret;\n \n+\t/* Setup Rx adapter */\n+\tret = rte_eventmode_helper_initialize_rx_adapter(em_conf);\n+\tif (ret != 0)\n+\t\treturn ret;\n+\n \t/* Start eth devices after setting up adapter */\n \tRTE_ETH_FOREACH_DEV(portid) {\n \ndiff --git a/lib/librte_eventdev/rte_eventmode_helper_internal.h b/lib/librte_eventdev/rte_eventmode_helper_internal.h\nindex 2a6cd90..9c68605 100644\n--- a/lib/librte_eventdev/rte_eventmode_helper_internal.h\n+++ b/lib/librte_eventdev/rte_eventmode_helper_internal.h\n@@ -35,6 +35,12 @@\n /* Max event devices supported */\n #define EVENT_MODE_MAX_EVENT_DEVS RTE_EVENT_MAX_DEVS\n \n+/* Max Rx adapters supported */\n+#define EVENT_MODE_MAX_RX_ADAPTERS RTE_EVENT_MAX_DEVS\n+\n+/* Max Rx adapter connections */\n+#define EVENT_MODE_MAX_CONNECTIONS_PER_ADAPTER 16\n+\n /* Max event queues supported per event device */\n #define EVENT_MODE_MAX_EVENT_QUEUES_PER_DEV RTE_EVENT_MAX_QUEUES_PER_DEV\n \n@@ -50,12 +56,33 @@ struct eventdev_params {\n \tuint8_t ev_queue_mode;\n };\n \n+/* Rx adapter connection info */\n+struct adapter_connection_info {\n+\tuint8_t ethdev_id;\n+\tuint8_t eventq_id;\n+\tint32_t ethdev_rx_qid;\n+};\n+\n+/* Rx adapter conf */\n+struct rx_adapter_conf {\n+\tint32_t eventdev_id;\n+\tint32_t adapter_id;\n+\tuint32_t rx_core_id;\n+\tuint8_t nb_connections;\n+\tstruct adapter_connection_info\n+\t\t\tconn[EVENT_MODE_MAX_CONNECTIONS_PER_ADAPTER];\n+};\n+\n /* Eventmode conf data */\n struct eventmode_conf {\n \tint nb_eventdev;\n \t\t/**< No of event devs */\n \tstruct eventdev_params eventdev_config[EVENT_MODE_MAX_EVENT_DEVS];\n \t\t/**< Per event dev conf */\n+\tuint8_t nb_rx_adapter;\n+\t\t/**< No of Rx adapters */\n+\tstruct rx_adapter_conf rx_adapter[EVENT_MODE_MAX_RX_ADAPTERS];\n+\t\t/**< Rx adapter conf */\n \tuint8_t nb_link;\n \t\t/**< No of links */\n \tstruct rte_eventmode_helper_event_link_info\n", "prefixes": [ "24/39" ] }