Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54242/?format=api
http://patches.dpdk.org/api/patches/54242/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1559583160-13944-23-git-send-email-anoobj@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1559583160-13944-23-git-send-email-anoobj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1559583160-13944-23-git-send-email-anoobj@marvell.com", "date": "2019-06-03T17:32:22", "name": "[22/39] eventdev: add option to specify schedule mode for app stage", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "8823743f42bc072baa11e02693083bbf6dc63b45", "submitter": { "id": 1205, "url": "http://patches.dpdk.org/api/people/1205/?format=api", "name": "Anoob Joseph", "email": "anoobj@marvell.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1559583160-13944-23-git-send-email-anoobj@marvell.com/mbox/", "series": [ { "id": 4868, "url": "http://patches.dpdk.org/api/series/4868/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4868", "date": "2019-06-03T17:32:00", "name": "adding eventmode helper library", "version": 1, "mbox": "http://patches.dpdk.org/series/4868/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54242/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/54242/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 378B11B9D3;\n\tMon, 3 Jun 2019 19:35:38 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n\t[67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 5EB771B9CF\n\tfor <dev@dpdk.org>; Mon, 3 Jun 2019 19:35:36 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n\tby mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id\n\tx53HKk5T027666; Mon, 3 Jun 2019 10:35:35 -0700", "from sc-exch03.marvell.com ([199.233.58.183])\n\tby mx0b-0016f401.pphosted.com with ESMTP id 2sw79pr6yw-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); \n\tMon, 03 Jun 2019 10:35:34 -0700", "from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH03.marvell.com\n\t(10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3;\n\tMon, 3 Jun 2019 10:35:32 -0700", "from maili.marvell.com (10.93.176.43) by SC-EXCH03.marvell.com\n\t(10.93.176.83) with Microsoft SMTP Server id 15.0.1367.3 via Frontend\n\tTransport; Mon, 3 Jun 2019 10:35:32 -0700", "from ajoseph83.caveonetworks.com.com (unknown [10.29.45.56])\n\tby maili.marvell.com (Postfix) with ESMTP id 6505D3F7040;\n\tMon, 3 Jun 2019 10:35:27 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n\th=from : to : cc :\n\tsubject : date : message-id : in-reply-to : references : mime-version\n\t: content-transfer-encoding : content-type; s=pfpt0818;\n\tbh=87OSkinGzpTANoGkyjRWo5CIE8FFToGRqzYjDukJKSQ=;\n\tb=Z/Y1IY9y3Fmn8dijCW8L7/YttO0FXMaAWYSdfzYgccvyZFRqfgwkVImOeHCxeN63qfOi\n\tdQA73+3h7jueqX+0BHdPeDzbFw45quK1hwoX0OOi6DmSzEtSuGpVtY1koxU1Qa3E6aVD\n\tUXEMpn75QJeJaF6XYjjT8Pz+OlmG8zYtsCbNpti1aXaRX9fqUkeenb4o1Fw1U23dZRRj\n\tY+HIkUyQo4AEGDubw8OzcuIPEbD8TEcSisYN4akO+p20ldwOsCM2QGAHufgJS2mQLKYU\n\tY4JqOydIu3YxzOS9zMYKbjSEW2JleSfoifnmbPLXo19vB+KZr5VRjohXd3CLFb2zNyyo\n\t2g== ", "From": "Anoob Joseph <anoobj@marvell.com>", "To": "Jerin Jacob <jerinj@marvell.com>, Nikhil Rao <nikhil.rao@intel.com>,\n\t\"Erik Gabriel Carrillo\" <erik.g.carrillo@intel.com>, Abhinandan Gujjar\n\t<abhinandan.gujjar@intel.com>,\n\tBruce Richardson <bruce.richardson@intel.com>,\n\tPablo de Lara <pablo.de.lara.guarch@intel.com>", "CC": "Anoob Joseph <anoobj@marvell.com>, Narayana Prasad <pathreya@marvell.com>,\n\t<dev@dpdk.org>, Lukasz Bartosik <lbartosik@marvell.com>, Pavan Nikhilesh\n\t<pbhagavatula@marvell.com>, Hemant Agrawal <hemant.agrawal@nxp.com>,\n\t\"Nipun Gupta\" <nipun.gupta@nxp.com>, Harry van Haaren\n\t<harry.van.haaren@intel.com>, =?utf-8?q?Mattias_R=C3=B6nnblom?=\n\t<mattias.ronnblom@ericsson.com>, Liang Ma <liang.j.ma@intel.com>", "Date": "Mon, 3 Jun 2019 23:02:22 +0530", "Message-ID": "<1559583160-13944-23-git-send-email-anoobj@marvell.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1559583160-13944-1-git-send-email-anoobj@marvell.com>", "References": "<1559583160-13944-1-git-send-email-anoobj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:, ,\n\tdefinitions=2019-06-03_13:, , signatures=0", "Subject": "[dpdk-dev] [PATCH 22/39] eventdev: add option to specify schedule\n\tmode for app stage", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Scheduling mode for each event queue is dependent on the same of app\nstage. Configure event queue taking this also into account.\n\nSigned-off-by: Anoob Joseph <anoobj@marvell.com>\nSigned-off-by: Lukasz Bartosik <lbartosik@marvell.com>\n---\n lib/librte_eventdev/rte_eventmode_helper.c | 24 ++++++++++++++++++++--\n .../rte_eventmode_helper_internal.h | 8 ++++++++\n 2 files changed, 30 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_eventdev/rte_eventmode_helper.c b/lib/librte_eventdev/rte_eventmode_helper.c\nindex ec0be44..30bb357 100644\n--- a/lib/librte_eventdev/rte_eventmode_helper.c\n+++ b/lib/librte_eventdev/rte_eventmode_helper.c\n@@ -85,6 +85,8 @@ em_parse_transfer_mode(struct rte_eventmode_helper_conf *conf,\n static void\n em_initialize_helper_conf(struct rte_eventmode_helper_conf *conf)\n {\n+\tstruct eventmode_conf *em_conf = NULL;\n+\n \t/* Set default conf */\n \n \t/* Packet transfer mode: poll */\n@@ -92,6 +94,13 @@ em_initialize_helper_conf(struct rte_eventmode_helper_conf *conf)\n \n \t/* Keep all ethernet ports enabled by default */\n \tconf->eth_portmask = -1;\n+\n+\t/* Get eventmode conf */\n+\tem_conf = (struct eventmode_conf *)(conf->mode_params);\n+\n+\t/* Schedule type: ordered */\n+\t/* FIXME */\n+\tem_conf->ext_params.sched_type = RTE_SCHED_TYPE_ORDERED;\n }\n \n struct rte_eventmode_helper_conf * __rte_experimental\n@@ -233,8 +242,19 @@ rte_eventmode_helper_initialize_eventdev(struct eventmode_conf *em_conf)\n \t\t\teventq_conf.event_queue_cfg =\n \t\t\t\t\teventdev_config->ev_queue_mode;\n \n-\t\t\t/* Set schedule type as ATOMIC */\n-\t\t\teventq_conf.schedule_type = RTE_SCHED_TYPE_ATOMIC;\n+\t\t\t/*\n+\t\t\t * All queues need to be set with sched_type as\n+\t\t\t * schedule type for the application stage. One queue\n+\t\t\t * would be reserved for the final eth tx stage. This\n+\t\t\t * will be an atomic queue.\n+\t\t\t */\n+\t\t\tif (j == nb_eventqueue-1) {\n+\t\t\t\teventq_conf.schedule_type =\n+\t\t\t\t\tRTE_SCHED_TYPE_ATOMIC;\n+\t\t\t} else {\n+\t\t\t\teventq_conf.schedule_type =\n+\t\t\t\t\tem_conf->ext_params.sched_type;\n+\t\t\t}\n \n \t\t\t/* Set max atomic flows to 1024 */\n \t\t\teventq_conf.nb_atomic_flows = 1024;\ndiff --git a/lib/librte_eventdev/rte_eventmode_helper_internal.h b/lib/librte_eventdev/rte_eventmode_helper_internal.h\nindex ee41833..2a6cd90 100644\n--- a/lib/librte_eventdev/rte_eventmode_helper_internal.h\n+++ b/lib/librte_eventdev/rte_eventmode_helper_internal.h\n@@ -61,6 +61,14 @@ struct eventmode_conf {\n \tstruct rte_eventmode_helper_event_link_info\n \t\t\tlink[EVENT_MODE_MAX_LCORE_LINKS];\n \t\t/**< Per link conf */\n+\tunion {\n+\t\tstruct {\n+\t\t\tuint64_t sched_type\t\t\t: 2;\n+\t\t/**< Schedule type */\n+\t\t};\n+\t\tuint64_t u64;\n+\t} ext_params;\n+\t\t/**< 64 bit field to specify extended params */\n };\n \n #endif /* _RTE_EVENTMODE_HELPER_INTERNAL_H_ */\n", "prefixes": [ "22/39" ] }{ "id": 54242, "url": "