Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54122/?format=api
{ "id": 54122, "url": "http://patches.dpdk.org/api/patches/54122/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190602174247.32368-7-lance.richardson@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190602174247.32368-7-lance.richardson@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190602174247.32368-7-lance.richardson@broadcom.com", "date": "2019-06-02T17:42:41", "name": "[06/11] net/bnxt: support extended hwrm request sizes", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "dcbf6f71c9c62acaa768296ef1acd0e958bab0ca", "submitter": { "id": 1323, "url": "http://patches.dpdk.org/api/people/1323/?format=api", "name": "Lance Richardson", "email": "lance.richardson@broadcom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190602174247.32368-7-lance.richardson@broadcom.com/mbox/", "series": [ { "id": 4850, "url": "http://patches.dpdk.org/api/series/4850/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4850", "date": "2019-06-02T17:42:35", "name": "add support for BCM57508 controller", "version": 1, "mbox": "http://patches.dpdk.org/series/4850/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54122/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/54122/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 15F531B99F;\n\tSun, 2 Jun 2019 19:43:20 +0200 (CEST)", "from mail-yb1-f195.google.com (mail-yb1-f195.google.com\n\t[209.85.219.195]) by dpdk.org (Postfix) with ESMTP id CA99B4D27\n\tfor <dev@dpdk.org>; Sun, 2 Jun 2019 19:43:09 +0200 (CEST)", "by mail-yb1-f195.google.com with SMTP id x7so3188608ybg.5\n\tfor <dev@dpdk.org>; Sun, 02 Jun 2019 10:43:09 -0700 (PDT)", "from lrichardson-VirtualBox.attlocal.net\n\t(69-218-223-106.lightspeed.rlghnc.sbcglobal.net. [69.218.223.106])\n\tby smtp.gmail.com with ESMTPSA id\n\tn78sm1000819ywd.2.2019.06.02.10.43.08\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 02 Jun 2019 10:43:08 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=xPq4du0UREu4mhaa6tN8ZhzdPyl/ToV02UmY6Hovy78=;\n\tb=gK5GSsqZkIkdnJDYMuhYm8ZZO0+o3kpPwWx/fvyiNT/wM3naSoVWw8E+W6TJDpCIwG\n\td0mBoUNDmioQ2HPhur1XufxPB2cD4qsw9GKcoxPMw2YgJvBzmTh/lGCVQ28mlaJ8jQ2G\n\tnMD3xwgA6XABRRpIO7l53JRkt2MVO88hfM+IE=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=xPq4du0UREu4mhaa6tN8ZhzdPyl/ToV02UmY6Hovy78=;\n\tb=l/lurQtNNeH4WEkGE4d4D0ueiZDmqulL84d24GhZoyPlUjWD/zOeaO4JRmjS2TSnno\n\tyfwbgQnjCDevf9l3HSLpzHYpYdJ0Jlh2Nc/0HsJd2rxsC52/7FNuIXVD6lfqpEnF1ATQ\n\t0fmrc/kVCmmGvIzPbiA4qY6+hniGxFW1t3y0xAkL6AGir/+a/x/1sFBN2Ong9V9zp1AP\n\tVxp/AKHRsxsvJLtDZy/OpeuJfgXAOdMOtmVzgju8Aj4yU6AG8ceHfYtmLGb4KiEeu+Kk\n\tD1G12wzH37Q9R9f0FhQfYeByZVgVXQ9YhKDTccSnbId1fdD+s3H7jrytm0LQufJNeYlA\n\tsuKw==", "X-Gm-Message-State": "APjAAAUANhhfuQyLejEqfWVJluJ5c9J5jrlz34UpGYaOOdmoqZJR81cH\n\t2frixmN6gxaI7mARrtQRHnMUCHAuPpqcI7+WFN7ndRNI87Pa+3ITAzUtD64sqF5VIYA1aW34/l1\n\tnvavJc7TXWvPfPFMLNPUsXFCaYtwHB+E7BzPGzo0DVWR1prMSgj8Ja1IxqzsvMm5T", "X-Google-Smtp-Source": "APXvYqxTFioPll3A28M74Jz+TM13ILKt7tOm1Bxuv4gGoPrCan7bS416jNz+BnHWaH/RaY3FjUtZLQ==", "X-Received": "by 2002:a25:f506:: with SMTP id a6mr11374024ybe.33.1559497388926;\n\tSun, 02 Jun 2019 10:43:08 -0700 (PDT)", "From": "Lance Richardson <lance.richardson@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ajit.khaparde@broadcom.com, ferruh.yigit@intel.com,\n\tLance Richardson <lance.richardson@broadcom.com>", "Date": "Sun, 2 Jun 2019 13:42:41 -0400", "Message-Id": "<20190602174247.32368-7-lance.richardson@broadcom.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190602174247.32368-1-lance.richardson@broadcom.com>", "References": "<20190602174247.32368-1-lance.richardson@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 06/11] net/bnxt: support extended hwrm request\n\tsizes", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Enable support for extended request sizes.\n\nSigned-off-by: Lance Richardson <lance.richardson@broadcom.com>\nReviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt.h | 1 +\n drivers/net/bnxt/bnxt_hwrm.c | 31 ++++++++++++++++++++++---------\n 2 files changed, 23 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex caacc7258..9bb8d825d 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -320,6 +320,7 @@ struct bnxt {\n \trte_spinlock_t\t\t\thwrm_lock;\n \tuint16_t\t\t\tmax_req_len;\n \tuint16_t\t\t\tmax_resp_len;\n+\tuint16_t hwrm_max_ext_req_len;\n \n \tstruct bnxt_link_info\tlink_info;\n \tstruct bnxt_cos_queue_info\tcos_queue[BNXT_COS_QUEUE_COUNT];\ndiff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex 7cad3cb4c..45d37f176 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -85,10 +85,11 @@ static int bnxt_hwrm_send_message(struct bnxt *bp, void *msg,\n \tuint16_t mb_trigger_offset = use_kong_mb ?\n \t\tGRCPF_REG_KONG_COMM_TRIGGER : GRCPF_REG_CHIMP_COMM_TRIGGER;\n \n-\tif (bp->flags & BNXT_FLAG_SHORT_CMD) {\n+\tif (bp->flags & BNXT_FLAG_SHORT_CMD ||\n+\t msg_len > bp->max_req_len) {\n \t\tvoid *short_cmd_req = bp->hwrm_short_cmd_req_addr;\n \n-\t\tmemset(short_cmd_req, 0, bp->max_req_len);\n+\t\tmemset(short_cmd_req, 0, bp->hwrm_max_ext_req_len);\n \t\tmemcpy(short_cmd_req, req, msg_len);\n \n \t\tshort_input.req_type = rte_cpu_to_le_16(req->req_type);\n@@ -128,8 +129,7 @@ static int bnxt_hwrm_send_message(struct bnxt *bp, void *msg,\n \tfor (i = 0; i < HWRM_CMD_TIMEOUT; i++) {\n \t\t/* Sanity check on the resp->resp_len */\n \t\trte_rmb();\n-\t\tif (resp->resp_len && resp->resp_len <=\n-\t\t\t\tbp->max_resp_len) {\n+\t\tif (resp->resp_len && resp->resp_len <= bp->max_resp_len) {\n \t\t\t/* Last byte of resp contains the valid key */\n \t\t\tvalid = (uint8_t *)resp + resp->resp_len - 1;\n \t\t\tif (*valid == HWRM_RESP_VALID_KEY)\n@@ -832,7 +832,11 @@ int bnxt_hwrm_ver_get(struct bnxt *bp)\n \t\trc = -EINVAL;\n \t}\n \tbp->max_req_len = rte_le_to_cpu_16(resp->max_req_win_len);\n-\tmax_resp_len = resp->max_resp_len;\n+\tbp->hwrm_max_ext_req_len = rte_le_to_cpu_16(resp->max_ext_req_len);\n+\tif (bp->hwrm_max_ext_req_len < HWRM_MAX_REQ_LEN)\n+\t\tbp->hwrm_max_ext_req_len = HWRM_MAX_REQ_LEN;\n+\n+\tmax_resp_len = rte_le_to_cpu_16(resp->max_resp_len);\n \tdev_caps_cfg = rte_le_to_cpu_32(resp->dev_caps_cfg);\n \n \tif (bp->max_resp_len != max_resp_len) {\n@@ -864,11 +868,22 @@ int bnxt_hwrm_ver_get(struct bnxt *bp)\n \t (dev_caps_cfg &\n \t HWRM_VER_GET_OUTPUT_DEV_CAPS_CFG_SHORT_CMD_REQUIRED)) {\n \t\tPMD_DRV_LOG(DEBUG, \"Short command supported\\n\");\n+\t\tbp->flags |= BNXT_FLAG_SHORT_CMD;\n+\t}\n+\n+\tif (((dev_caps_cfg &\n+\t HWRM_VER_GET_OUTPUT_DEV_CAPS_CFG_SHORT_CMD_SUPPORTED) &&\n+\t (dev_caps_cfg &\n+\t HWRM_VER_GET_OUTPUT_DEV_CAPS_CFG_SHORT_CMD_REQUIRED)) ||\n+\t bp->hwrm_max_ext_req_len > HWRM_MAX_REQ_LEN) {\n+\t\tsprintf(type, \"bnxt_hwrm_short_%04x:%02x:%02x:%02x\",\n+\t\t\tbp->pdev->addr.domain, bp->pdev->addr.bus,\n+\t\t\tbp->pdev->addr.devid, bp->pdev->addr.function);\n \n \t\trte_free(bp->hwrm_short_cmd_req_addr);\n \n-\t\tbp->hwrm_short_cmd_req_addr = rte_malloc(type,\n-\t\t\t\t\t\t\tbp->max_req_len, 0);\n+\t\tbp->hwrm_short_cmd_req_addr =\n+\t\t\t\trte_malloc(type, bp->hwrm_max_ext_req_len, 0);\n \t\tif (bp->hwrm_short_cmd_req_addr == NULL) {\n \t\t\trc = -ENOMEM;\n \t\t\tgoto error;\n@@ -883,8 +898,6 @@ int bnxt_hwrm_ver_get(struct bnxt *bp)\n \t\t\trc = -ENOMEM;\n \t\t\tgoto error;\n \t\t}\n-\n-\t\tbp->flags |= BNXT_FLAG_SHORT_CMD;\n \t}\n \tif (dev_caps_cfg &\n \t HWRM_VER_GET_OUTPUT_DEV_CAPS_CFG_KONG_MB_CHNL_SUPPORTED) {\n", "prefixes": [ "06/11" ] }