Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54076/?format=api
{ "id": 54076, "url": "http://patches.dpdk.org/api/patches/54076/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190602152434.23996-21-jerinj@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190602152434.23996-21-jerinj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190602152434.23996-21-jerinj@marvell.com", "date": "2019-06-02T15:23:56", "name": "[v1,20/58] net/octeontx2: add queue start and stop operations", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "39e447cb7a749806f22624f3c4c54da65d7c2ae6", "submitter": { "id": 1188, "url": "http://patches.dpdk.org/api/people/1188/?format=api", "name": "Jerin Jacob Kollanukkaran", "email": "jerinj@marvell.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190602152434.23996-21-jerinj@marvell.com/mbox/", "series": [ { "id": 4848, "url": "http://patches.dpdk.org/api/series/4848/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4848", "date": "2019-06-02T15:23:36", "name": "OCTEON TX2 Ethdev driver", "version": 1, "mbox": "http://patches.dpdk.org/series/4848/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54076/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/54076/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1302B1B9E6;\n\tSun, 2 Jun 2019 17:25:40 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n\t[67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 986CC1B95B\n\tfor <dev@dpdk.org>; Sun, 2 Jun 2019 17:25:39 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n\tby mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id\n\tx52FK4jt020253; Sun, 2 Jun 2019 08:25:39 -0700", "from sc-exch01.marvell.com ([199.233.58.181])\n\tby mx0b-0016f401.pphosted.com with ESMTP id 2survk494c-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); \n\tSun, 02 Jun 2019 08:25:38 -0700", "from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH01.marvell.com\n\t(10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3;\n\tSun, 2 Jun 2019 08:25:37 -0700", "from maili.marvell.com (10.93.176.43) by SC-EXCH03.marvell.com\n\t(10.93.176.83) with Microsoft SMTP Server id 15.0.1367.3 via Frontend\n\tTransport; Sun, 2 Jun 2019 08:25:37 -0700", "from jerin-lab.marvell.com (jerin-lab.marvell.com [10.28.34.14])\n\tby maili.marvell.com (Postfix) with ESMTP id A65D03F703F;\n\tSun, 2 Jun 2019 08:25:35 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n\th=from : to : cc :\n\tsubject : date : message-id : in-reply-to : references : mime-version\n\t: content-transfer-encoding : content-type; s=pfpt0818;\n\tbh=QPncdV8ruv6j086dRAmI93+FfoZctL6AiKknNyOUTGs=;\n\tb=P2OZaWQSTBC5mdfXE3eHnLgYbdmtn82R3B7zQKMmUtwdhrSA8wZBXd7hRnxSwqBokum4\n\t+6wRcGpDhIZLkGdWYW34x6VQQUic7Uayv4PxeyWl9cRS1DAbzpQDD3hiLw6Y0Vh3DQ1y\n\tITuALl2MP4qShSBYBc6arqICEgCTwog6GWDmcaxmhwb2AZCMM8TO8qoZQ5RlOuT+68Y7\n\twYVa8G4QXazqoy29rkeguEbiTsiPEE8NGzAy1yMC2u4QMJoFif8/yDt/nR5QjzRO1jiR\n\t0K+ieaDieHWcNuUIwyV39GSvc23e6hojvhvmvxIXksQFohpOrjeK9d9yNg7y1McCeM6p\n\tgA== ", "From": "<jerinj@marvell.com>", "To": "<dev@dpdk.org>, John McNamara <john.mcnamara@intel.com>, Marko Kovacevic\n\t<marko.kovacevic@intel.com>, Jerin Jacob <jerinj@marvell.com>, \"Nithin\n\tDabilpuram\" <ndabilpuram@marvell.com>, Kiran Kumar K\n\t<kirankumark@marvell.com>", "CC": "<ferruh.yigit@intel.com>, Vamsi Attunuru <vattunuru@marvell.com>", "Date": "Sun, 2 Jun 2019 20:53:56 +0530", "Message-ID": "<20190602152434.23996-21-jerinj@marvell.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190602152434.23996-1-jerinj@marvell.com>", "References": "<20190602152434.23996-1-jerinj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:, ,\n\tdefinitions=2019-06-02_09:, , signatures=0", "Subject": "[dpdk-dev] [PATCH v1 20/58] net/octeontx2: add queue start and stop\n\toperations", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Nithin Dabilpuram <ndabilpuram@marvell.com>\n\nAdd queue start and stop operations. Tx queue needs\nto update the flow control value, Which will be\nadded in sub subsequent patch.\n\nSigned-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>\nSigned-off-by: Vamsi Attunuru <vattunuru@marvell.com>\n---\n doc/guides/nics/features/octeontx2.ini | 1 +\n doc/guides/nics/features/octeontx2_vec.ini | 1 +\n doc/guides/nics/features/octeontx2_vf.ini | 1 +\n drivers/net/octeontx2/otx2_ethdev.c | 92 ++++++++++++++++++++++\n drivers/net/octeontx2/otx2_ethdev.h | 2 +\n 5 files changed, 97 insertions(+)", "diff": "diff --git a/doc/guides/nics/features/octeontx2.ini b/doc/guides/nics/features/octeontx2.ini\nindex 48ac58b3a..31816a183 100644\n--- a/doc/guides/nics/features/octeontx2.ini\n+++ b/doc/guides/nics/features/octeontx2.ini\n@@ -12,6 +12,7 @@ SR-IOV = Y\n Multiprocess aware = Y\n Link status = Y\n Link status event = Y\n+Queue start/stop = Y\n Promiscuous mode = Y\n Allmulticast mode = Y\n Unicast MAC filter = Y\ndiff --git a/doc/guides/nics/features/octeontx2_vec.ini b/doc/guides/nics/features/octeontx2_vec.ini\nindex 6fc647af4..d79428652 100644\n--- a/doc/guides/nics/features/octeontx2_vec.ini\n+++ b/doc/guides/nics/features/octeontx2_vec.ini\n@@ -12,6 +12,7 @@ SR-IOV = Y\n Multiprocess aware = Y\n Link status = Y\n Link status event = Y\n+Queue start/stop = Y\n Promiscuous mode = Y\n Allmulticast mode = Y\n Unicast MAC filter = Y\ndiff --git a/doc/guides/nics/features/octeontx2_vf.ini b/doc/guides/nics/features/octeontx2_vf.ini\nindex af3c70269..d4deb52af 100644\n--- a/doc/guides/nics/features/octeontx2_vf.ini\n+++ b/doc/guides/nics/features/octeontx2_vf.ini\n@@ -11,6 +11,7 @@ Lock-free Tx queue = Y\n Multiprocess aware = Y\n Link status = Y\n Link status event = Y\n+Queue start/stop = Y\n RSS hash = Y\n RSS key update = Y\n RSS reta update = Y\ndiff --git a/drivers/net/octeontx2/otx2_ethdev.c b/drivers/net/octeontx2/otx2_ethdev.c\nindex 6e14e12f0..04a953441 100644\n--- a/drivers/net/octeontx2/otx2_ethdev.c\n+++ b/drivers/net/octeontx2/otx2_ethdev.c\n@@ -252,6 +252,26 @@ nix_cq_rq_init(struct rte_eth_dev *eth_dev, struct otx2_eth_dev *dev,\n \treturn rc;\n }\n \n+static int\n+nix_rq_enb_dis(struct rte_eth_dev *eth_dev,\n+\t struct otx2_eth_rxq *rxq, const bool enb)\n+{\n+\tstruct otx2_eth_dev *dev = otx2_eth_pmd_priv(eth_dev);\n+\tstruct otx2_mbox *mbox = dev->mbox;\n+\tstruct nix_aq_enq_req *aq;\n+\n+\t/* Pkts will be dropped silently if RQ is disabled */\n+\taq = otx2_mbox_alloc_msg_nix_aq_enq(mbox);\n+\taq->qidx = rxq->rq;\n+\taq->ctype = NIX_AQ_CTYPE_RQ;\n+\taq->op = NIX_AQ_INSTOP_WRITE;\n+\n+\taq->rq.ena = enb;\n+\taq->rq_mask.ena = ~(aq->rq_mask.ena);\n+\n+\treturn otx2_mbox_process(mbox);\n+}\n+\n static int\n nix_cq_rq_uninit(struct rte_eth_dev *eth_dev, struct otx2_eth_rxq *rxq)\n {\n@@ -1090,6 +1110,74 @@ otx2_nix_configure(struct rte_eth_dev *eth_dev)\n \treturn rc;\n }\n \n+int\n+otx2_nix_tx_queue_start(struct rte_eth_dev *eth_dev, uint16_t qidx)\n+{\n+\tstruct rte_eth_dev_data *data = eth_dev->data;\n+\n+\tif (data->tx_queue_state[qidx] == RTE_ETH_QUEUE_STATE_STARTED)\n+\t\treturn 0;\n+\n+\tdata->tx_queue_state[qidx] = RTE_ETH_QUEUE_STATE_STARTED;\n+\treturn 0;\n+}\n+\n+int\n+otx2_nix_tx_queue_stop(struct rte_eth_dev *eth_dev, uint16_t qidx)\n+{\n+\tstruct rte_eth_dev_data *data = eth_dev->data;\n+\n+\tif (data->tx_queue_state[qidx] == RTE_ETH_QUEUE_STATE_STOPPED)\n+\t\treturn 0;\n+\n+\tdata->tx_queue_state[qidx] = RTE_ETH_QUEUE_STATE_STOPPED;\n+\treturn 0;\n+}\n+\n+static int\n+otx2_nix_rx_queue_start(struct rte_eth_dev *eth_dev, uint16_t qidx)\n+{\n+\tstruct otx2_eth_rxq *rxq = eth_dev->data->rx_queues[qidx];\n+\tstruct rte_eth_dev_data *data = eth_dev->data;\n+\tint rc;\n+\n+\tif (data->rx_queue_state[qidx] == RTE_ETH_QUEUE_STATE_STARTED)\n+\t\treturn 0;\n+\n+\trc = nix_rq_enb_dis(rxq->eth_dev, rxq, true);\n+\tif (rc) {\n+\t\totx2_err(\"Failed to enable rxq=%u, rc=%d\", qidx, rc);\n+\t\tgoto done;\n+\t}\n+\n+\tdata->rx_queue_state[qidx] = RTE_ETH_QUEUE_STATE_STARTED;\n+\n+done:\n+\treturn rc;\n+}\n+\n+static int\n+otx2_nix_rx_queue_stop(struct rte_eth_dev *eth_dev, uint16_t qidx)\n+{\n+\tstruct otx2_eth_rxq *rxq = eth_dev->data->rx_queues[qidx];\n+\tstruct rte_eth_dev_data *data = eth_dev->data;\n+\tint rc;\n+\n+\tif (data->rx_queue_state[qidx] == RTE_ETH_QUEUE_STATE_STOPPED)\n+\t\treturn 0;\n+\n+\trc = nix_rq_enb_dis(rxq->eth_dev, rxq, false);\n+\tif (rc) {\n+\t\totx2_err(\"Failed to disable rxq=%u, rc=%d\", qidx, rc);\n+\t\tgoto done;\n+\t}\n+\n+\tdata->rx_queue_state[qidx] = RTE_ETH_QUEUE_STATE_STOPPED;\n+\n+done:\n+\treturn rc;\n+}\n+\n /* Initialize and register driver with DPDK Application */\n static const struct eth_dev_ops otx2_eth_dev_ops = {\n \t.dev_infos_get = otx2_nix_info_get,\n@@ -1099,6 +1187,10 @@ static const struct eth_dev_ops otx2_eth_dev_ops = {\n \t.tx_queue_release = otx2_nix_tx_queue_release,\n \t.rx_queue_setup = otx2_nix_rx_queue_setup,\n \t.rx_queue_release = otx2_nix_rx_queue_release,\n+\t.tx_queue_start = otx2_nix_tx_queue_start,\n+\t.tx_queue_stop = otx2_nix_tx_queue_stop,\n+\t.rx_queue_start = otx2_nix_rx_queue_start,\n+\t.rx_queue_stop = otx2_nix_rx_queue_stop,\n \t.stats_get = otx2_nix_dev_stats_get,\n \t.stats_reset = otx2_nix_dev_stats_reset,\n \t.get_reg = otx2_nix_dev_get_reg,\ndiff --git a/drivers/net/octeontx2/otx2_ethdev.h b/drivers/net/octeontx2/otx2_ethdev.h\nindex c0568dcd1..7b8c7e1e5 100644\n--- a/drivers/net/octeontx2/otx2_ethdev.h\n+++ b/drivers/net/octeontx2/otx2_ethdev.h\n@@ -246,6 +246,8 @@ void otx2_nix_promisc_enable(struct rte_eth_dev *eth_dev);\n void otx2_nix_promisc_disable(struct rte_eth_dev *eth_dev);\n void otx2_nix_allmulticast_enable(struct rte_eth_dev *eth_dev);\n void otx2_nix_allmulticast_disable(struct rte_eth_dev *eth_dev);\n+int otx2_nix_tx_queue_start(struct rte_eth_dev *eth_dev, uint16_t qidx);\n+int otx2_nix_tx_queue_stop(struct rte_eth_dev *eth_dev, uint16_t qidx);\n uint64_t otx2_nix_rxq_mbuf_setup(struct otx2_eth_dev *dev, uint16_t port_id);\n \n /* Link */\n", "prefixes": [ "v1", "20/58" ] }