Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53986/?format=api
{ "id": 53986, "url": "http://patches.dpdk.org/api/patches/53986/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190601014905.45531-17-jerinj@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190601014905.45531-17-jerinj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190601014905.45531-17-jerinj@marvell.com", "date": "2019-06-01T01:48:54", "name": "[v2,16/27] mempool/octeontx2: add build infra and device probe", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8c16ec64ff67e3f155877d6469662bfcdbb27430", "submitter": { "id": 1188, "url": "http://patches.dpdk.org/api/people/1188/?format=api", "name": "Jerin Jacob Kollanukkaran", "email": "jerinj@marvell.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190601014905.45531-17-jerinj@marvell.com/mbox/", "series": [ { "id": 4844, "url": "http://patches.dpdk.org/api/series/4844/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4844", "date": "2019-06-01T01:48:38", "name": "OCTEON TX2 common and mempool driver", "version": 2, "mbox": "http://patches.dpdk.org/series/4844/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53986/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/53986/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C08321B9C8;\n\tSat, 1 Jun 2019 03:50:08 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n\t[67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 310361B952\n\tfor <dev@dpdk.org>; Sat, 1 Jun 2019 03:50:05 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n\tby mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id\n\tx511mruc004005; Fri, 31 May 2019 18:50:03 -0700", "from sc-exch01.marvell.com ([199.233.58.181])\n\tby mx0b-0016f401.pphosted.com with ESMTP id 2su5xh2bv0-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); \n\tFri, 31 May 2019 18:50:02 -0700", "from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH01.marvell.com\n\t(10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3;\n\tFri, 31 May 2019 18:50:01 -0700", "from maili.marvell.com (10.93.176.43) by SC-EXCH03.marvell.com\n\t(10.93.176.83) with Microsoft SMTP Server id 15.0.1367.3 via Frontend\n\tTransport; Fri, 31 May 2019 18:50:01 -0700", "from jerin-lab.marvell.com (jerin-lab.marvell.com [10.28.34.14])\n\tby maili.marvell.com (Postfix) with ESMTP id 3F7173F703F;\n\tFri, 31 May 2019 18:49:59 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n\th=from : to : cc :\n\tsubject : date : message-id : in-reply-to : references : mime-version\n\t: content-transfer-encoding : content-type; s=pfpt0818;\n\tbh=qFYPCBNF7U5Ce3RpjeTUSndUyDYblhUEUYt1DvAA6LI=;\n\tb=J5Y3X3uCPwwFjAPawt85loOHeEZNdso9amAUbX7IeTU0yISYKhtG6Y3YKEaVmQrYtvCK\n\tm2Es1HleJypc2wqc/zCJIcEhOdJW+Pd/mfcEJuvk2H15HbfgSSUBZtBRSu04QN6Dqp8U\n\tZBp7F7Lyd2VGI1cLyXIyHLFjxCGBWeNrLnygVkOYhzTjammSeDeb8bCOIQRzbi6hMtvU\n\tI0BJ3zpp5Zd5GD6s3zked0r4gFR37DxkypPuxzZS3wIxEnIt+AIAy1/lvkWkqTX0nx24\n\tYAhy0NP3mZUo3IrESDkPei3y8Bj8gBaFQ8mb1ykdvIElhLeZn85AqhANXCCWPm4w9ZCj\n\tBg== ", "From": "<jerinj@marvell.com>", "To": "<dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>, Olivier Matz\n\t<olivier.matz@6wind.com>, Andrew Rybchenko <arybchenko@solarflare.com>,\n\t\"Jerin Jacob\" <jerinj@marvell.com>, Nithin Dabilpuram\n\t<ndabilpuram@marvell.com>, Vamsi Attunuru <vattunuru@marvell.com>,\n\tAnatoly Burakov <anatoly.burakov@intel.com>", "CC": "Pavan Nikhilesh <pbhagavatula@marvell.com>", "Date": "Sat, 1 Jun 2019 07:18:54 +0530", "Message-ID": "<20190601014905.45531-17-jerinj@marvell.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190601014905.45531-1-jerinj@marvell.com>", "References": "<20190523081339.56348-1-jerinj@marvell.com>\n\t<20190601014905.45531-1-jerinj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:, ,\n\tdefinitions=2019-06-01_02:, , signatures=0", "Subject": "[dpdk-dev] [PATCH v2 16/27] mempool/octeontx2: add build infra and\n\tdevice probe", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Jerin Jacob <jerinj@marvell.com>\n\nAdd the make and meson based build infrastructure along\nwith the mempool(NPA) device probe.\n\nSigned-off-by: Jerin Jacob <jerinj@marvell.com>\nSigned-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>\n---\n config/common_base | 5 ++\n drivers/common/Makefile | 3 +\n drivers/mempool/Makefile | 1 +\n drivers/mempool/meson.build | 2 +-\n drivers/mempool/octeontx2/Makefile | 36 ++++++++++++\n drivers/mempool/octeontx2/meson.build | 20 +++++++\n drivers/mempool/octeontx2/otx2_mempool.c | 57 +++++++++++++++++++\n .../rte_mempool_octeontx2_version.map | 4 ++\n mk/rte.app.mk | 4 ++\n 9 files changed, 131 insertions(+), 1 deletion(-)\n create mode 100644 drivers/mempool/octeontx2/Makefile\n create mode 100644 drivers/mempool/octeontx2/meson.build\n create mode 100644 drivers/mempool/octeontx2/otx2_mempool.c\n create mode 100644 drivers/mempool/octeontx2/rte_mempool_octeontx2_version.map", "diff": "diff --git a/config/common_base b/config/common_base\nindex 6f19ad5d2..4a3de0360 100644\n--- a/config/common_base\n+++ b/config/common_base\n@@ -771,6 +771,11 @@ CONFIG_RTE_DRIVER_MEMPOOL_STACK=y\n #\n CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOOL=y\n \n+#\n+# Compile PMD for octeontx2 npa mempool device\n+#\n+CONFIG_RTE_LIBRTE_OCTEONTX2_MEMPOOL=y\n+\n #\n # Compile librte_mbuf\n #\ndiff --git a/drivers/common/Makefile b/drivers/common/Makefile\nindex e7abe210e..05d75568f 100644\n--- a/drivers/common/Makefile\n+++ b/drivers/common/Makefile\n@@ -23,6 +23,9 @@ ifeq ($(CONFIG_RTE_LIBRTE_COMMON_DPAAX),y)\n DIRS-y += dpaax\n endif\n \n+OCTEONTX2-y := $(CONFIG_RTE_LIBRTE_OCTEONTX2_MEMPOOL)\n+ifeq ($(findstring y,$(OCTEONTX2-y)),y)\n DIRS-y += octeontx2\n+endif\n \n include $(RTE_SDK)/mk/rte.subdir.mk\ndiff --git a/drivers/mempool/Makefile b/drivers/mempool/Makefile\nindex 28c2e8360..29ef73bf4 100644\n--- a/drivers/mempool/Makefile\n+++ b/drivers/mempool/Makefile\n@@ -13,5 +13,6 @@ endif\n DIRS-$(CONFIG_RTE_DRIVER_MEMPOOL_RING) += ring\n DIRS-$(CONFIG_RTE_DRIVER_MEMPOOL_STACK) += stack\n DIRS-$(CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOOL) += octeontx\n+DIRS-$(CONFIG_RTE_LIBRTE_OCTEONTX2_MEMPOOL) += octeontx2\n \n include $(RTE_SDK)/mk/rte.subdir.mk\ndiff --git a/drivers/mempool/meson.build b/drivers/mempool/meson.build\nindex 4527d9806..7520e489f 100644\n--- a/drivers/mempool/meson.build\n+++ b/drivers/mempool/meson.build\n@@ -1,7 +1,7 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2017 Intel Corporation\n \n-drivers = ['bucket', 'dpaa', 'dpaa2', 'octeontx', 'ring', 'stack']\n+drivers = ['bucket', 'dpaa', 'dpaa2', 'octeontx', 'octeontx2', 'ring', 'stack']\n std_deps = ['mempool']\n config_flag_fmt = 'RTE_LIBRTE_@0@_MEMPOOL'\n driver_name_fmt = 'rte_mempool_@0@'\ndiff --git a/drivers/mempool/octeontx2/Makefile b/drivers/mempool/octeontx2/Makefile\nnew file mode 100644\nindex 000000000..6fbb6e291\n--- /dev/null\n+++ b/drivers/mempool/octeontx2/Makefile\n@@ -0,0 +1,36 @@\n+# SPDX-License-Identifier: BSD-3-Clause\n+# Copyright(C) 2019 Marvell International Ltd.\n+#\n+\n+include $(RTE_SDK)/mk/rte.vars.mk\n+\n+#\n+# library name\n+#\n+LIB = librte_mempool_octeontx2.a\n+\n+CFLAGS += $(WERROR_FLAGS)\n+CFLAGS += -I$(RTE_SDK)/drivers/common/octeontx2\n+CFLAGS += -I$(RTE_SDK)/drivers/mempool/octeontx2\n+CFLAGS += -I$(RTE_SDK)/drivers/bus/pci\n+CFLAGS += -O3\n+\n+ifneq ($(CONFIG_RTE_ARCH_64),y)\n+CFLAGS += -Wno-int-to-pointer-cast\n+CFLAGS += -Wno-pointer-to-int-cast\n+endif\n+\n+EXPORT_MAP := rte_mempool_octeontx2_version.map\n+\n+LIBABIVER := 1\n+\n+#\n+# all source are stored in SRCS-y\n+#\n+SRCS-$(CONFIG_RTE_LIBRTE_OCTEONTX2_MEMPOOL) += \\\n+\totx2_mempool.c\n+\n+LDLIBS += -lrte_eal -lrte_mempool -lrte_mbuf\n+LDLIBS += -lrte_common_octeontx2 -lrte_kvargs -lrte_bus_pci\n+\n+include $(RTE_SDK)/mk/rte.lib.mk\ndiff --git a/drivers/mempool/octeontx2/meson.build b/drivers/mempool/octeontx2/meson.build\nnew file mode 100644\nindex 000000000..ec3c59eef\n--- /dev/null\n+++ b/drivers/mempool/octeontx2/meson.build\n@@ -0,0 +1,20 @@\n+# SPDX-License-Identifier: BSD-3-Clause\n+# Copyright(C) 2019 Marvell International Ltd.\n+#\n+\n+sources = files('otx2_mempool.c',\n+\t\t)\n+\n+extra_flags = []\n+# This integrated controller runs only on a arm64 machine, remove 32bit warnings\n+if not dpdk_conf.get('RTE_ARCH_64')\n+\textra_flags += ['-Wno-int-to-pointer-cast', '-Wno-pointer-to-int-cast']\n+endif\n+\n+foreach flag: extra_flags\n+\tif cc.has_argument(flag)\n+\t\tcflags += flag\n+\tendif\n+endforeach\n+\n+deps += ['eal', 'mbuf', 'kvargs', 'bus_pci', 'common_octeontx2', 'mempool']\ndiff --git a/drivers/mempool/octeontx2/otx2_mempool.c b/drivers/mempool/octeontx2/otx2_mempool.c\nnew file mode 100644\nindex 000000000..fd8e147f5\n--- /dev/null\n+++ b/drivers/mempool/octeontx2/otx2_mempool.c\n@@ -0,0 +1,57 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(C) 2019 Marvell International Ltd.\n+ */\n+\n+#include <rte_bus_pci.h>\n+#include <rte_common.h>\n+#include <rte_eal.h>\n+#include <rte_pci.h>\n+\n+#include \"otx2_common.h\"\n+\n+static int\n+npa_remove(struct rte_pci_device *pci_dev)\n+{\n+\tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n+\t\treturn 0;\n+\n+\tRTE_SET_USED(pci_dev);\n+\treturn 0;\n+}\n+\n+static int\n+npa_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)\n+{\n+\tRTE_SET_USED(pci_drv);\n+\n+\tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n+\t\treturn 0;\n+\n+\tRTE_SET_USED(pci_dev);\n+\treturn 0;\n+}\n+\n+static const struct rte_pci_id pci_npa_map[] = {\n+\t{\n+\t\tRTE_PCI_DEVICE(PCI_VENDOR_ID_CAVIUM,\n+\t\t\t\t\tPCI_DEVID_OCTEONTX2_RVU_NPA_PF)\n+\t},\n+\t{\n+\t\tRTE_PCI_DEVICE(PCI_VENDOR_ID_CAVIUM,\n+\t\t\t\t\tPCI_DEVID_OCTEONTX2_RVU_NPA_VF)\n+\t},\n+\t{\n+\t\t.vendor_id = 0,\n+\t},\n+};\n+\n+static struct rte_pci_driver pci_npa = {\n+\t.id_table = pci_npa_map,\n+\t.drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_IOVA_AS_VA,\n+\t.probe = npa_probe,\n+\t.remove = npa_remove,\n+};\n+\n+RTE_PMD_REGISTER_PCI(mempool_octeontx2, pci_npa);\n+RTE_PMD_REGISTER_PCI_TABLE(mempool_octeontx2, pci_npa_map);\n+RTE_PMD_REGISTER_KMOD_DEP(mempool_octeontx2, \"vfio-pci\");\ndiff --git a/drivers/mempool/octeontx2/rte_mempool_octeontx2_version.map b/drivers/mempool/octeontx2/rte_mempool_octeontx2_version.map\nnew file mode 100644\nindex 000000000..fc8c95e91\n--- /dev/null\n+++ b/drivers/mempool/octeontx2/rte_mempool_octeontx2_version.map\n@@ -0,0 +1,4 @@\n+DPDK_19.05 {\n+\n+\tlocal: *;\n+};\ndiff --git a/mk/rte.app.mk b/mk/rte.app.mk\nindex 1e9dcd5a1..cd89ccfd5 100644\n--- a/mk/rte.app.mk\n+++ b/mk/rte.app.mk\n@@ -91,6 +91,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_TIMER) += -lrte_timer\n _LDLIBS-$(CONFIG_RTE_LIBRTE_MEMPOOL) += -lrte_mempool\n _LDLIBS-$(CONFIG_RTE_LIBRTE_STACK) += -lrte_stack\n _LDLIBS-$(CONFIG_RTE_DRIVER_MEMPOOL_RING) += -lrte_mempool_ring\n+_LDLIBS-$(CONFIG_RTE_LIBRTE_OCTEONTX2_MEMPOOL) += -lrte_mempool_octeontx2\n _LDLIBS-$(CONFIG_RTE_LIBRTE_RING) += -lrte_ring\n _LDLIBS-$(CONFIG_RTE_LIBRTE_PCI) += -lrte_pci\n _LDLIBS-$(CONFIG_RTE_LIBRTE_EAL) += -lrte_eal\n@@ -125,7 +126,10 @@ ifeq ($(CONFIG_RTE_LIBRTE_FSLMC_BUS),y)\n _LDLIBS-$(CONFIG_RTE_LIBRTE_COMMON_DPAAX) += -lrte_common_dpaax\n endif\n \n+OCTEONTX2-y := $(CONFIG_RTE_LIBRTE_OCTEONTX2_MEMPOOL)\n+ifeq ($(findstring y,$(OCTEONTX2-y)),y)\n _LDLIBS-y += -lrte_common_octeontx2\n+endif\n \n _LDLIBS-$(CONFIG_RTE_LIBRTE_PCI_BUS) += -lrte_bus_pci\n _LDLIBS-$(CONFIG_RTE_LIBRTE_VDEV_BUS) += -lrte_bus_vdev\n", "prefixes": [ "v2", "16/27" ] }