Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53962/?format=api
http://patches.dpdk.org/api/patches/53962/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1559317022-28779-6-git-send-email-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1559317022-28779-6-git-send-email-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1559317022-28779-6-git-send-email-david.marchand@redhat.com", "date": "2019-05-31T15:37:02", "name": "[v5,5/5] test: use lcore accessors", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a0425a6923bb10e80e4471180ec1a27a6aac634f", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1559317022-28779-6-git-send-email-david.marchand@redhat.com/mbox/", "series": [ { "id": 4839, "url": "http://patches.dpdk.org/api/series/4839/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4839", "date": "2019-05-31T15:36:57", "name": "make lcore_config internal", "version": 5, "mbox": "http://patches.dpdk.org/series/4839/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53962/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/53962/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 176E71B9A9;\n\tFri, 31 May 2019 17:37:28 +0200 (CEST)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id B819E1B998\n\tfor <dev@dpdk.org>; Fri, 31 May 2019 17:37:22 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 1ECCB309B7B9;\n\tFri, 31 May 2019 15:37:22 +0000 (UTC)", "from dmarchan.remote.csb (ovpn-116-185.ams2.redhat.com\n\t[10.36.116.185])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id E645860BFC;\n\tFri, 31 May 2019 15:37:19 +0000 (UTC)" ], "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, stephen@networkplumber.org,\n\tbruce.richardson@intel.com,\n\tPablo de Lara <pablo.de.lara.guarch@intel.com>, \n\tDeclan Doherty <declan.doherty@intel.com>,\n\tOlivier Matz <olivier.matz@6wind.com>, Gage Eads <gage.eads@intel.com>", "Date": "Fri, 31 May 2019 17:37:02 +0200", "Message-Id": "<1559317022-28779-6-git-send-email-david.marchand@redhat.com>", "In-Reply-To": "<1559317022-28779-1-git-send-email-david.marchand@redhat.com>", "References": "<20190408182510.16078-1-stephen@networkplumber.org>\n\t<1559317022-28779-1-git-send-email-david.marchand@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.12", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.47]); Fri, 31 May 2019 15:37:22 +0000 (UTC)", "Subject": "[dpdk-dev] [PATCH v5 5/5] test: use lcore accessors", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Stephen Hemminger <stephen@networkplumber.org>\n\nDon't refer to lcore_config directly.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n app/test/test_cryptodev.c | 2 +-\n app/test/test_ring_perf.c | 22 ++++++++++++----------\n app/test/test_stack_perf.c | 20 ++++++++++----------\n 3 files changed, 23 insertions(+), 21 deletions(-)\n\n---\nChangelog since v3:\n- updated title\n- removed parts on test_hash_readwrite_lf", "diff": "diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c\nindex 9f31aaa..eca6d3d 100644\n--- a/app/test/test_cryptodev.c\n+++ b/app/test/test_cryptodev.c\n@@ -378,7 +378,7 @@ struct crypto_unittest_params {\n \t\t\tstrcpy(temp_str, vdev_args);\n \t\t\tstrlcat(temp_str, \";\", sizeof(temp_str));\n \t\t\tslave_core_count++;\n-\t\t\tsocket_id = lcore_config[i].socket_id;\n+\t\t\tsocket_id = rte_lcore_to_socket_id(i);\n \t\t}\n \t\tif (slave_core_count != 2) {\n \t\t\tRTE_LOG(ERR, USER1,\ndiff --git a/app/test/test_ring_perf.c b/app/test/test_ring_perf.c\nindex ebb3939..6eccccf 100644\n--- a/app/test/test_ring_perf.c\n+++ b/app/test/test_ring_perf.c\n@@ -52,10 +52,11 @@ struct lcore_pair {\n \t\tRTE_LCORE_FOREACH(id2) {\n \t\t\tif (id1 == id2)\n \t\t\t\tcontinue;\n-\t\t\tc1 = lcore_config[id1].core_id;\n-\t\t\tc2 = lcore_config[id2].core_id;\n-\t\t\ts1 = lcore_config[id1].socket_id;\n-\t\t\ts2 = lcore_config[id2].socket_id;\n+\n+\t\t\tc1 = rte_lcore_to_cpu_id(id1);\n+\t\t\tc2 = rte_lcore_to_cpu_id(id2);\n+\t\t\ts1 = rte_lcore_to_socket_id(id1);\n+\t\t\ts2 = rte_lcore_to_socket_id(id2);\n \t\t\tif ((c1 == c2) && (s1 == s2)){\n \t\t\t\tlcp->c1 = id1;\n \t\t\t\tlcp->c2 = id2;\n@@ -75,10 +76,11 @@ struct lcore_pair {\n \t\tRTE_LCORE_FOREACH(id2) {\n \t\t\tif (id1 == id2)\n \t\t\t\tcontinue;\n-\t\t\tc1 = lcore_config[id1].core_id;\n-\t\t\tc2 = lcore_config[id2].core_id;\n-\t\t\ts1 = lcore_config[id1].socket_id;\n-\t\t\ts2 = lcore_config[id2].socket_id;\n+\n+\t\t\tc1 = rte_lcore_to_cpu_id(id1);\n+\t\t\tc2 = rte_lcore_to_cpu_id(id2);\n+\t\t\ts1 = rte_lcore_to_socket_id(id1);\n+\t\t\ts2 = rte_lcore_to_socket_id(id2);\n \t\t\tif ((c1 != c2) && (s1 == s2)){\n \t\t\t\tlcp->c1 = id1;\n \t\t\t\tlcp->c2 = id2;\n@@ -98,8 +100,8 @@ struct lcore_pair {\n \t\tRTE_LCORE_FOREACH(id2) {\n \t\t\tif (id1 == id2)\n \t\t\t\tcontinue;\n-\t\t\ts1 = lcore_config[id1].socket_id;\n-\t\t\ts2 = lcore_config[id2].socket_id;\n+\t\t\ts1 = rte_lcore_to_socket_id(id1);\n+\t\t\ts2 = rte_lcore_to_socket_id(id2);\n \t\t\tif (s1 != s2){\n \t\t\t\tlcp->c1 = id1;\n \t\t\t\tlcp->c2 = id2;\ndiff --git a/app/test/test_stack_perf.c b/app/test/test_stack_perf.c\nindex ba27fbf..70561fe 100644\n--- a/app/test/test_stack_perf.c\n+++ b/app/test/test_stack_perf.c\n@@ -44,10 +44,10 @@ struct lcore_pair {\n \t\tRTE_LCORE_FOREACH(id[1]) {\n \t\t\tif (id[0] == id[1])\n \t\t\t\tcontinue;\n-\t\t\tcore[0] = lcore_config[id[0]].core_id;\n-\t\t\tcore[1] = lcore_config[id[1]].core_id;\n-\t\t\tsocket[0] = lcore_config[id[0]].socket_id;\n-\t\t\tsocket[1] = lcore_config[id[1]].socket_id;\n+\t\t\tcore[0] = rte_lcore_to_cpu_id(id[0]);\n+\t\t\tcore[1] = rte_lcore_to_cpu_id(id[1]);\n+\t\t\tsocket[0] = rte_lcore_to_socket_id(id[0]);\n+\t\t\tsocket[1] = rte_lcore_to_socket_id(id[1]);\n \t\t\tif ((core[0] == core[1]) && (socket[0] == socket[1])) {\n \t\t\t\tlcp->c1 = id[0];\n \t\t\t\tlcp->c2 = id[1];\n@@ -70,10 +70,10 @@ struct lcore_pair {\n \t\tRTE_LCORE_FOREACH(id[1]) {\n \t\t\tif (id[0] == id[1])\n \t\t\t\tcontinue;\n-\t\t\tcore[0] = lcore_config[id[0]].core_id;\n-\t\t\tcore[1] = lcore_config[id[1]].core_id;\n-\t\t\tsocket[0] = lcore_config[id[0]].socket_id;\n-\t\t\tsocket[1] = lcore_config[id[1]].socket_id;\n+\t\t\tcore[0] = rte_lcore_to_cpu_id(id[0]);\n+\t\t\tcore[1] = rte_lcore_to_cpu_id(id[1]);\n+\t\t\tsocket[0] = rte_lcore_to_socket_id(id[0]);\n+\t\t\tsocket[1] = rte_lcore_to_socket_id(id[1]);\n \t\t\tif ((core[0] != core[1]) && (socket[0] == socket[1])) {\n \t\t\t\tlcp->c1 = id[0];\n \t\t\t\tlcp->c2 = id[1];\n@@ -95,8 +95,8 @@ struct lcore_pair {\n \t\tRTE_LCORE_FOREACH(id[1]) {\n \t\t\tif (id[0] == id[1])\n \t\t\t\tcontinue;\n-\t\t\tsocket[0] = lcore_config[id[0]].socket_id;\n-\t\t\tsocket[1] = lcore_config[id[1]].socket_id;\n+\t\t\tsocket[0] = rte_lcore_to_socket_id(id[0]);\n+\t\t\tsocket[1] = rte_lcore_to_socket_id(id[1]);\n \t\t\tif (socket[0] != socket[1]) {\n \t\t\t\tlcp->c1 = id[0];\n \t\t\t\tlcp->c2 = id[1];\n", "prefixes": [ "v5", "5/5" ] }{ "id": 53962, "url": "