Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53961/?format=api
{ "id": 53961, "url": "http://patches.dpdk.org/api/patches/53961/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1559317022-28779-5-git-send-email-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1559317022-28779-5-git-send-email-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1559317022-28779-5-git-send-email-david.marchand@redhat.com", "date": "2019-05-31T15:37:01", "name": "[v5,4/5] examples/bond: use lcore accessors", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1032b2023229fb1ad083c808a810dd27cb579288", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1559317022-28779-5-git-send-email-david.marchand@redhat.com/mbox/", "series": [ { "id": 4839, "url": "http://patches.dpdk.org/api/series/4839/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4839", "date": "2019-05-31T15:36:57", "name": "make lcore_config internal", "version": 5, "mbox": "http://patches.dpdk.org/series/4839/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53961/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/53961/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 659011B9A4;\n\tFri, 31 May 2019 17:37:26 +0200 (CEST)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id 0AE662AB\n\tfor <dev@dpdk.org>; Fri, 31 May 2019 17:37:20 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 74D8B309B15E;\n\tFri, 31 May 2019 15:37:19 +0000 (UTC)", "from dmarchan.remote.csb (ovpn-116-185.ams2.redhat.com\n\t[10.36.116.185])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 1915060BFC;\n\tFri, 31 May 2019 15:37:17 +0000 (UTC)" ], "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, stephen@networkplumber.org,\n\tbruce.richardson@intel.com, Chas Williams <chas3@att.com>", "Date": "Fri, 31 May 2019 17:37:01 +0200", "Message-Id": "<1559317022-28779-5-git-send-email-david.marchand@redhat.com>", "In-Reply-To": "<1559317022-28779-1-git-send-email-david.marchand@redhat.com>", "References": "<20190408182510.16078-1-stephen@networkplumber.org>\n\t<1559317022-28779-1-git-send-email-david.marchand@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.12", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.49]); Fri, 31 May 2019 15:37:19 +0000 (UTC)", "Subject": "[dpdk-dev] [PATCH v5 4/5] examples/bond: use lcore accessors", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Stephen Hemminger <stephen@networkplumber.org>\n\nReferring to lcore_config directly is no longer recommended.\nAlso remove unnecessary assignment of slave_core_id.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n examples/bond/main.c | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)\n\n---\nChangelog since v3:\n- updated title", "diff": "diff --git a/examples/bond/main.c b/examples/bond/main.c\nindex 9b9ed56..4c650ef 100644\n--- a/examples/bond/main.c\n+++ b/examples/bond/main.c\n@@ -531,8 +531,9 @@ static void cmd_start_parsed(__attribute__((unused)) void *parsed_result,\n \tint slave_core_id = rte_lcore_id();\n \n \trte_spinlock_trylock(&global_flag_stru_p->lock);\n-\tif (global_flag_stru_p->LcoreMainIsRunning == 0)\t{\n-\t\tif (lcore_config[global_flag_stru_p->LcoreMainCore].state != WAIT)\t{\n+\tif (global_flag_stru_p->LcoreMainIsRunning == 0) {\n+\t\tif (rte_eal_get_lcore_state(global_flag_stru_p->LcoreMainCore)\n+\t\t != WAIT) {\n \t\t\trte_spinlock_unlock(&global_flag_stru_p->lock);\n \t\t\treturn;\n \t\t}\n@@ -765,7 +766,7 @@ static void prompt(__attribute__((unused)) void *arg1)\n int\n main(int argc, char *argv[])\n {\n-\tint ret;\n+\tint ret, slave_core_id;\n \tuint16_t nb_ports, i;\n \n \t/* init EAL */\n@@ -797,13 +798,13 @@ static void prompt(__attribute__((unused)) void *arg1)\n \tbond_port_init(mbuf_pool);\n \n \trte_spinlock_init(&global_flag_stru_p->lock);\n-\tint slave_core_id = rte_lcore_id();\n \n \t/* check state of lcores */\n \tRTE_LCORE_FOREACH_SLAVE(slave_core_id) {\n-\tif (lcore_config[slave_core_id].state != WAIT)\n-\t\treturn -EBUSY;\n+\t\tif (rte_eal_get_lcore_state(slave_core_id) != WAIT)\n+\t\t\treturn -EBUSY;\n \t}\n+\n \t/* start lcore main on core != master_core - ARP response thread */\n \tslave_core_id = rte_get_next_lcore(rte_lcore_id(), 1, 0);\n \tif ((slave_core_id >= RTE_MAX_LCORE) || (slave_core_id == 0))\n", "prefixes": [ "v5", "4/5" ] }