Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53960/?format=api
http://patches.dpdk.org/api/patches/53960/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1559317022-28779-4-git-send-email-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1559317022-28779-4-git-send-email-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1559317022-28779-4-git-send-email-david.marchand@redhat.com", "date": "2019-05-31T15:37:00", "name": "[v5,3/5] drivers/bus: use lcore accessors", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3d857413a83f678c28194ca1f832ab1f5b79ad2b", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1559317022-28779-4-git-send-email-david.marchand@redhat.com/mbox/", "series": [ { "id": 4839, "url": "http://patches.dpdk.org/api/series/4839/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4839", "date": "2019-05-31T15:36:57", "name": "make lcore_config internal", "version": 5, "mbox": "http://patches.dpdk.org/series/4839/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53960/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/53960/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B4F7A1B999;\n\tFri, 31 May 2019 17:37:23 +0200 (CEST)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id 1F8761B993\n\tfor <dev@dpdk.org>; Fri, 31 May 2019 17:37:19 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 68DBB9FFE4;\n\tFri, 31 May 2019 15:37:17 +0000 (UTC)", "from dmarchan.remote.csb (ovpn-116-185.ams2.redhat.com\n\t[10.36.116.185])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id C641A60BFC;\n\tFri, 31 May 2019 15:37:15 +0000 (UTC)" ], "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, stephen@networkplumber.org,\n\tbruce.richardson@intel.com, Hemant Agrawal <hemant.agrawal@nxp.com>, \n\tShreyansh Jain <shreyansh.jain@nxp.com>", "Date": "Fri, 31 May 2019 17:37:00 +0200", "Message-Id": "<1559317022-28779-4-git-send-email-david.marchand@redhat.com>", "In-Reply-To": "<1559317022-28779-1-git-send-email-david.marchand@redhat.com>", "References": "<20190408182510.16078-1-stephen@networkplumber.org>\n\t<1559317022-28779-1-git-send-email-david.marchand@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.12", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]); Fri, 31 May 2019 15:37:17 +0000 (UTC)", "Subject": "[dpdk-dev] [PATCH v5 3/5] drivers/bus: use lcore accessors", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Stephen Hemminger <stephen@networkplumber.org>\n\nThe lcore_config structure will be hidden in future release.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n drivers/bus/dpaa/dpaa_bus.c | 6 ++++--\n drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 4 +++-\n 2 files changed, 7 insertions(+), 3 deletions(-)\n\n---\nChangelog since v3:\n- updated title", "diff": "diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c\nindex ac20ecc..08c8227 100644\n--- a/drivers/bus/dpaa/dpaa_bus.c\n+++ b/drivers/bus/dpaa/dpaa_bus.c\n@@ -254,6 +254,7 @@ int rte_dpaa_portal_init(void *arg)\n \tunsigned int cpu, lcore = rte_lcore_id();\n \tint ret;\n \tstruct dpaa_portal *dpaa_io_portal;\n+\trte_cpuset_t cpuset;\n \n \tBUS_INIT_FUNC_TRACE();\n \n@@ -263,12 +264,13 @@ int rte_dpaa_portal_init(void *arg)\n \t\tif (lcore >= RTE_MAX_LCORE)\n \t\t\treturn -1;\n \n-\tcpu = lcore_config[lcore].core_id;\n+\tcpu = rte_lcore_to_cpu_id(lcore);\n \n \t/* Set CPU affinity for this thread.*/\n \tid = pthread_self();\n+\tcpuset = rte_lcore_cpuset(lcore);\n \tret = pthread_setaffinity_np(id, sizeof(cpu_set_t),\n-\t\t\t&lcore_config[lcore].cpuset);\n+\t\t\t\t &cpuset);\n \tif (ret) {\n \t\tDPAA_BUS_LOG(ERR, \"pthread_setaffinity_np failed on core :%u\"\n \t\t\t \" (lcore=%u) with ret: %d\", cpu, lcore, ret);\ndiff --git a/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c b/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c\nindex 7bcbde8..8efb24a 100644\n--- a/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c\n+++ b/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c\n@@ -366,7 +366,9 @@ static struct dpaa2_dpio_dev *dpaa2_get_qbman_swp(int lcoreid)\n \n \tfor (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {\n \t\tfor (i = 0; i < RTE_MAX_LCORE; i++) {\n-\t\t\tif (CPU_ISSET(i, &lcore_config[lcore_id].cpuset)) {\n+\t\t\trte_cpuset_t cpuset = rte_lcore_cpuset(lcore_id);\n+\n+\t\t\tif (CPU_ISSET(i, &cpuset)) {\n \t\t\t\tRTE_LOG(DEBUG, EAL, \"lcore id = %u cpu=%u\\n\",\n \t\t\t\t\tlcore_id, i);\n \t\t\t\tif (dpaa2_cpu[lcore_id] != 0xffffffff) {\n", "prefixes": [ "v5", "3/5" ] }{ "id": 53960, "url": "