Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53905/?format=api
{ "id": 53905, "url": "http://patches.dpdk.org/api/patches/53905/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190530123836.2620-1-i.maximets@samsung.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190530123836.2620-1-i.maximets@samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190530123836.2620-1-i.maximets@samsung.com", "date": "2019-05-30T12:38:36", "name": "[v2] meson: don't check dependencies for tests if not required", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ab7f9459265911cb15d8bdc6c2dd586826b75043", "submitter": { "id": 323, "url": "http://patches.dpdk.org/api/people/323/?format=api", "name": "Ilya Maximets", "email": "i.maximets@samsung.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190530123836.2620-1-i.maximets@samsung.com/mbox/", "series": [ { "id": 4824, "url": "http://patches.dpdk.org/api/series/4824/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4824", "date": "2019-05-30T12:38:36", "name": "[v2] meson: don't check dependencies for tests if not required", "version": 2, "mbox": "http://patches.dpdk.org/series/4824/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53905/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/53905/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BC8A61B94D;\n\tThu, 30 May 2019 14:38:44 +0200 (CEST)", "from mailout2.w1.samsung.com (mailout2.w1.samsung.com\n\t[210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 235921B94D\n\tfor <dev@dpdk.org>; Thu, 30 May 2019 14:38:43 +0200 (CEST)", "from eucas1p2.samsung.com (unknown [182.198.249.207])\n\tby mailout2.w1.samsung.com (KnoxPortal) with ESMTP id\n\t20190530123842euoutp0295c26d1a021b23c2dd19553237a09a68~jdkIXDnl21844218442euoutp02j\n\tfor <dev@dpdk.org>; Thu, 30 May 2019 12:38:42 +0000 (GMT)", "from eusmges1new.samsung.com (unknown [203.254.199.242]) by\n\teucas1p2.samsung.com (KnoxPortal) with ESMTP id\n\t20190530123841eucas1p29f5511cfd6b46dcf02e4938d3c40587d~jdkH-w9LE2047020470eucas1p2C;\n\tThu, 30 May 2019 12:38:41 +0000 (GMT)", "from eucas1p1.samsung.com ( [182.198.249.206]) by\n\teusmges1new.samsung.com (EUCPMTA) with SMTP id 9B.70.04298.1DECFEC5;\n\tThu, 30 May 2019 13:38:41 +0100 (BST)", "from eusmtrp1.samsung.com (unknown [182.198.249.138]) by\n\teucas1p2.samsung.com (KnoxPortal) with ESMTPA id\n\t20190530123840eucas1p216e6df3737209db26e2b0ce678ba9da4~jdkHMs4Hk2049320493eucas1p25;\n\tThu, 30 May 2019 12:38:40 +0000 (GMT)", "from eusmgms2.samsung.com (unknown [182.198.249.180]) by\n\teusmtrp1.samsung.com (KnoxPortal) with ESMTP id\n\t20190530123840eusmtrp1734d4f134dc20dee12220903f23380b1~jdkG9DCzS1932019320eusmtrp1e;\n\tThu, 30 May 2019 12:38:40 +0000 (GMT)", "from eusmtip2.samsung.com ( [203.254.199.222]) by\n\teusmgms2.samsung.com (EUCPMTA) with SMTP id 06.66.04140.0DECFEC5;\n\tThu, 30 May 2019 13:38:40 +0100 (BST)", "from imaximets.rnd.samsung.ru (unknown [106.109.129.180]) by\n\teusmtip2.samsung.com (KnoxPortal) with ESMTPA id\n\t20190530123840eusmtip237504f6c843061f1256edbe358d4aa29~jdkGgfr682726327263eusmtip2b;\n\tThu, 30 May 2019 12:38:40 +0000 (GMT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com\n\t20190530123842euoutp0295c26d1a021b23c2dd19553237a09a68~jdkIXDnl21844218442euoutp02j", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n\ts=mail20170921; t=1559219922;\n\tbh=55mBaD5C4IuXG8S0afNjbroOauGH8UEMlg+BrOBZQYo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=g3ppzL2JUkpnlJ1H0iExyEOhqjiQjmzSEXqu2Uk+drJ7Fb4cGYzeeG6qBe710WYt3\n\tDad1c/Ib+IvtJB5QhawDWsZDAGpiOc9zBT37V4PY8AeuVNG28Ky72qqjYypitGzlZE\n\trSGKd0uu2laTWv1H+tcNPr4OXDS30nwsHV6jHoMQ=", "X-AuditID": "cbfec7f2-f2dff700000010ca-54-5cefced1a434", "From": "Ilya Maximets <i.maximets@samsung.com>", "To": "dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>", "Cc": "Bruce Richardson <bruce.richardson@intel.com>, Aaron Conole\n\t<aconole@redhat.com>, Kevin Traynor <ktraynor@redhat.com>, Ilya Maximets\n\t<i.maximets@samsung.com>", "Date": "Thu, 30 May 2019 15:38:36 +0300", "Message-Id": "<20190530123836.2620-1-i.maximets@samsung.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190529163958.30796-2-i.maximets@samsung.com>", "X-Brightmail-Tracker": [ "H4sIAAAAAAAAA0VSbUhTYRTu3b27uw4nt6l4MENZCRWljURHSBYJ7Y8U9s+GtfL6kW7arlrT\n\tH4mZ+Z1pNbOvZcnCJQsTtRKdK1QUJkbhtIWWBH5v83sK2rar9O85z/Occx4Oh8SEq3ggmabM\n\tplVKeYaI4ONtvU7zsWGzTXZ8tmC/ZGNugiexNMVIFhbbOZLv95w8SbPJzpMsTvTjpwnphraR\n\tK33dOc2R9o4+5kltXT8IaVVrE7rATeBHJ9EZabm0KvzUFX5qd7mFm9Vw6Nb2lxeoAFWElCEv\n\tEqgIqCuuR2WITwqptwgajJU8tlhGMPVTz2GLJQSWO+Vot2V1bQB3YyGlQ+DUilnTOgJr6RLh\n\tFgjqKAzov3oa/KgoeFBdynWbMKoRQbthDnMLvtR5aG6ZdU0iSZwKBccztZsWUCdh22TA2WXB\n\toH9v9Ni9qGgwPjV64gFlI6BM+5vLmmLh89ou9oWZvlYei4NgsLZiZ9BtGC+aRmxzCQKNaYvD\n\tCjHQOmvmuUNg1GEwfApn6TNQ8XDIQwPlA5b5vW4ac8GaNg3G0gIoKRay7oOw2aPDWBwIowtL\n\tOwmksPl3DGPvc9910flJVI2C6/8v0yLUhALoHEaRQjNiJX0zjJErmBxlSti1TEULcn3D4Fbf\n\tYgda+XbVhCgSibwFVI9NJuTKcxm1woSAxER+AqduQSYUJMnVebQq87IqJ4NmTGgfiYsCBPl7\n\tJi4JqRR5Np1O01m0alflkF6BBQi6N9b1hfLOyXRzcrzVh4FX1qJ1e5S6+EmliPCJdIxZ4a5D\n\t9mvlnKYxzh7r70gs8j6dzyULvTVk1YCl1jbMGbfN5L3TJz1/aX9DnND9GaoJHUkWjzScNXYF\n\tR0x11HH7sfgD04lBvjOGR5G2Gx8Trvc2V8b5fwjBu5YvdsaJcCZVLj6CqRj5P2Q4zUEJAwAA", "H4sIAAAAAAAAA+NgFrrOLMWRmVeSWpSXmKPExsVy+t/xe7oXzr2PMTg+Vcvi15sH7BY3Vtlb\n\tvPu0ncniSvtPdou1hz6wW3x6cILFgc3j14KlrB6L97xk8jh2cxq7x/t9V9k8+rasYgxgjdKz\n\tKcovLUlVyMgvLrFVija0MNIztLTQMzKx1DM0No+1MjJV0rezSUnNySxLLdK3S9DL2N99g7Vg\n\tkUbF/8PzGBsYexS6GDk5JARMJL59P8UCYgsJLGWU+HBCDiIuJfHj1wVWCFtY4s+1LrYuRi6g\n\tmm+MEpcmnwBrYBPQkTi1+ggjiC0iYCnx6MRHVpAiZoHljBK7jvxkA0kIC/hKXLvYB9TAwcEi\n\toCrxcU4lSJhXwEri/6H1LBAL5CVWbzjADGJzCthIHJh9gB3iIGuJL+s3sk9g5FvAyLCKUSS1\n\ttDg3PbfYSK84Mbe4NC9dLzk/dxMjMFC3Hfu5ZQdj17vgQ4wCHIxKPLwCB9/HCLEmlhVX5h5i\n\tlOBgVhLh/bn8XYwQb0piZVVqUX58UWlOavEhRlOgmyYyS4km5wOjKK8k3tDU0NzC0tDc2NzY\n\tzEJJnLdD4GCMkEB6YklqdmpqQWoRTB8TB6dUA2PcIlH2oxEBfU9ner2xY5jHfCw8eI3C+j0P\n\t45/9tA6q0Mw9tDSka8mvnV9Sjyx6dMGP7fyJgq7dT7q12hI87yi6nXihoSstLhMw68Dbqpv/\n\tTi7rOscXuHvvoRyXnf7VB5wi18790hsfYXWiq6/p0Qunp8+0PYO/3zE64SJrPl178o/c6Cqp\n\tT4JKLMUZiYZazEXFiQDy5f9UagIAAA==" ], "X-CMS-MailID": "20190530123840eucas1p216e6df3737209db26e2b0ce678ba9da4", "X-Msg-Generator": "CA", "Content-Type": "text/plain; charset=\"utf-8\"", "X-RootMTR": "20190530123840eucas1p216e6df3737209db26e2b0ce678ba9da4", "X-EPHeader": "CA", "CMS-TYPE": "201P", "X-CMS-RootMailID": "20190530123840eucas1p216e6df3737209db26e2b0ce678ba9da4", "References": "<20190529163958.30796-2-i.maximets@samsung.com>\n\t<CGME20190530123840eucas1p216e6df3737209db26e2b0ce678ba9da4@eucas1p2.samsung.com>", "Subject": "[dpdk-dev] [PATCH v2] meson: don't check dependencies for tests if\n\tnot required", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Don't need to check dependencies if test apps will not be built anyway.\n\nSigned-off-by: Ilya Maximets <i.maximets@samsung.com>\n---\n\nVersion 2:\n - 'get_option('tests')' check moved to the top.\n\n app/test/meson.build | 141 ++++++++++++++++++++++---------------------\n 1 file changed, 72 insertions(+), 69 deletions(-)", "diff": "diff --git a/app/test/meson.build b/app/test/meson.build\nindex 83391cef0..4de856f93 100644\n--- a/app/test/meson.build\n+++ b/app/test/meson.build\n@@ -1,6 +1,10 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2017 Intel Corporation\n \n+if not get_option('tests')\n+\tsubdir_done()\n+endif\n+\n test_sources = files('commands.c',\n \t'packet_burst_generator.c',\n \t'sample_packet_forward.c',\n@@ -335,86 +339,85 @@ if get_option('default_library') == 'static'\n \tlink_libs = dpdk_drivers\n endif\n \n-if get_option('tests')\n-\tdpdk_test = executable('dpdk-test',\n-\t\ttest_sources,\n-\t\tlink_whole: link_libs,\n-\t\tdependencies: test_dep_objs,\n-\t\tc_args: [cflags, '-DALLOW_EXPERIMENTAL_API'],\n-\t\tinstall_rpath: driver_install_path,\n-\t\tinstall: false)\n+dpdk_test = executable('dpdk-test',\n+\ttest_sources,\n+\tlink_whole: link_libs,\n+\tdependencies: test_dep_objs,\n+\tc_args: [cflags, '-DALLOW_EXPERIMENTAL_API'],\n+\tinstall_rpath: driver_install_path,\n+\tinstall: false)\n \n-\t# some perf tests (eg: memcpy perf autotest)take very long\n-\t# to complete, so timeout to 10 minutes\n-\ttimeout_seconds = 600\n-\ttimeout_seconds_fast = 10\n-\n-\t# Retrieve the number of CPU cores, defaulting to 4.\n-\tnum_cores = '0-3'\n-\tif host_machine.system() == 'linux'\n-\t\tnum_cores = run_command('cat',\n-\t\t\t\t\t'/sys/devices/system/cpu/present'\n-\t\t\t\t ).stdout().strip()\n-\telif host_machine.system() == 'freebsd'\n-\t\tsnum_cores = run_command('/sbin/sysctl', '-n',\n-\t\t\t\t\t 'hw.ncpu').stdout().strip()\n-\t\tinum_cores = snum_cores.to_int() - 1\n- num_cores = '0-@0@'.format(inum_cores)\n-\tendif\n+# some perf tests (eg: memcpy perf autotest)take very long\n+# to complete, so timeout to 10 minutes\n+timeout_seconds = 600\n+timeout_seconds_fast = 10\n \n-\tnum_cores_arg = '-l ' + num_cores\n+# Retrieve the number of CPU cores, defaulting to 4.\n+num_cores = '0-3'\n+if host_machine.system() == 'linux'\n+\tnum_cores = run_command('cat',\n+\t\t\t\t'/sys/devices/system/cpu/present'\n+\t\t\t ).stdout().strip()\n+elif host_machine.system() == 'freebsd'\n+\tsnum_cores = run_command('/sbin/sysctl', '-n',\n+\t\t\t\t 'hw.ncpu').stdout().strip()\n+\tinum_cores = snum_cores.to_int() - 1\n+ num_cores = '0-@0@'.format(inum_cores)\n+endif\n \n-\ttest_args = [num_cores_arg, '-n 4']\n-\tforeach arg : fast_parallel_test_names\n-\t\tif host_machine.system() == 'linux'\n-\t\t\ttest(arg, dpdk_test,\n-\t\t\t\t env : ['DPDK_TEST=' + arg],\n-\t\t\t\t args : test_args +\n-\t\t\t\t\t ['--file-prefix=@0@'.format(arg)],\n-\t\t\ttimeout : timeout_seconds_fast,\n-\t\t\tsuite : 'fast-tests')\n-\t\telse\n-\t\t\ttest(arg, dpdk_test,\n-\t\t\t\tenv : ['DPDK_TEST=' + arg],\n-\t\t\t\targs : test_args,\n-\t\t\ttimeout : timeout_seconds_fast,\n-\t\t\tsuite : 'fast-tests')\n-\t\tendif\n-\tendforeach\n+num_cores_arg = '-l ' + num_cores\n \n-\tforeach arg : fast_non_parallel_test_names\n+test_args = [num_cores_arg, '-n 4']\n+foreach arg : fast_parallel_test_names\n+\tif host_machine.system() == 'linux'\n+\t\ttest(arg, dpdk_test,\n+\t\t\t env : ['DPDK_TEST=' + arg],\n+\t\t\t args : test_args +\n+\t\t\t\t ['--file-prefix=@0@'.format(arg)],\n+\t\ttimeout : timeout_seconds_fast,\n+\t\tsuite : 'fast-tests')\n+\telse\n \t\ttest(arg, dpdk_test,\n \t\t\tenv : ['DPDK_TEST=' + arg],\n \t\t\targs : test_args,\n-\t\t\ttimeout : timeout_seconds_fast,\n-\t\t\tis_parallel : false,\n-\t\t\tsuite : 'fast-tests')\n-\tendforeach\n+\t\ttimeout : timeout_seconds_fast,\n+\t\tsuite : 'fast-tests')\n+\tendif\n+endforeach\n \n-\tforeach arg : perf_test_names\n-\t\ttest(arg, dpdk_test,\n+foreach arg : fast_non_parallel_test_names\n+\ttest(arg, dpdk_test,\n+\t\tenv : ['DPDK_TEST=' + arg],\n+\t\targs : test_args,\n+\t\ttimeout : timeout_seconds_fast,\n+\t\tis_parallel : false,\n+\t\tsuite : 'fast-tests')\n+endforeach\n+\n+foreach arg : perf_test_names\n+\ttest(arg, dpdk_test,\n+\tenv : ['DPDK_TEST=' + arg],\n+\targs : test_args,\n+\ttimeout : timeout_seconds,\n+\tis_parallel : false,\n+\tsuite : 'perf-tests')\n+endforeach\n+\n+foreach arg : driver_test_names\n+\ttest(arg, dpdk_test,\n \t\tenv : ['DPDK_TEST=' + arg],\n \t\targs : test_args,\n \t\ttimeout : timeout_seconds,\n \t\tis_parallel : false,\n-\t\tsuite : 'perf-tests')\n-\tendforeach\n+\t\tsuite : 'driver-tests')\n+endforeach\n \n-\tforeach arg : driver_test_names\n-\t\ttest(arg, dpdk_test,\n-\t\t\tenv : ['DPDK_TEST=' + arg],\n-\t\t\targs : test_args,\n-\t\t\ttimeout : timeout_seconds,\n-\t\t\tis_parallel : false,\n-\t\t\tsuite : 'driver-tests')\n-\tendforeach\n+foreach arg : dump_test_names\n+\ttest(arg, dpdk_test,\n+\t\tenv : ['DPDK_TEST=' + arg],\n+\t\targs : test_args,\n+\t\ttimeout : timeout_seconds,\n+\t\tis_parallel : false,\n+\t\tsuite : 'debug-tests')\n+endforeach\n \n-\tforeach arg : dump_test_names\n-\t\ttest(arg, dpdk_test,\n-\t\t\tenv : ['DPDK_TEST=' + arg],\n-\t\t\targs : test_args,\n-\t\t\ttimeout : timeout_seconds,\n-\t\t\tis_parallel : false,\n-\t\t\tsuite : 'debug-tests')\n-\tendforeach\n-endif\n", "prefixes": [ "v2" ] }