Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53868/?format=api
{ "id": 53868, "url": "http://patches.dpdk.org/api/patches/53868/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190529191501.19053-11-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190529191501.19053-11-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190529191501.19053-11-stephen@networkplumber.org", "date": "2019-05-29T19:14:59", "name": "[10/12] net/i40e: remove unnecessary cast", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e95ec6ba7bab77b85842a92cf41b729e87b719e7", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190529191501.19053-11-stephen@networkplumber.org/mbox/", "series": [ { "id": 4816, "url": "http://patches.dpdk.org/api/series/4816/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4816", "date": "2019-05-29T19:14:49", "name": "cleanup useless casts of void *", "version": 1, "mbox": "http://patches.dpdk.org/series/4816/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53868/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/53868/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B50171B9C9;\n\tWed, 29 May 2019 21:15:36 +0200 (CEST)", "from mail-pf1-f193.google.com (mail-pf1-f193.google.com\n\t[209.85.210.193]) by dpdk.org (Postfix) with ESMTP id 1DD721B997\n\tfor <dev@dpdk.org>; Wed, 29 May 2019 21:15:14 +0200 (CEST)", "by mail-pf1-f193.google.com with SMTP id c6so2240632pfa.10\n\tfor <dev@dpdk.org>; Wed, 29 May 2019 12:15:14 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tt18sm142943pgm.69.2019.05.29.12.15.11\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 29 May 2019 12:15:12 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=mBZcXtuhWE0FAr+/NaCVTGXEYT10KCBgHECR7N/Hklg=;\n\tb=BjKBNgE+PCeqWCRZeIcwx7V6lFxJhGWS+rg1kefEkghOuwch1T3XmIrS+zIcrR0cKU\n\t2vc2SBPSO8sl/FcOFvc53z+fkPgcbYHAhwtzZ8wNUpX7AFBV6nA1gETqnBRsjD6QrIQb\n\tk0Dp/1Ub8Y4E0kzRsTsU58kApjG4lTRrb/ecOfX0w7guA0XxZOUbgnZtUNBsH62Zcsvs\n\tQtoV33ExtVA9/9AqKcxNS8JDgwYld4o7MS8f0MCdQ69u0fjByFw+/B9S0lELT9vqoqb6\n\trPRKFrBFlV1xkoVkNYNJFforyQZkj4srQIsHB8fVlS3qFs5cpmEDUMnr60aRwh2PxH11\n\tB7CQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=mBZcXtuhWE0FAr+/NaCVTGXEYT10KCBgHECR7N/Hklg=;\n\tb=RZ9/NCUaKkrT5lz1XFzKk4lEIMCQhtsWMY47w6EftAE7yCvWTsMCXweRcUenMj3eCb\n\t0s54JqWw5o7o7T8f+5uTUJ1MoF2ip9zgMlSLfEPqCfTD8/pC5aNiGbrhPX3UCai0dkB2\n\txhvTYsZ+hbaRhY0Y4eDZsKH6Luqn49CsoAP9fthM4Z+TDzTaTy11Hg35e8QjWSnPAltP\n\tHHl8FKosjBh+xQdAhA3BBAicEy6eXQZBPgoAe8zxJ46cyr22NJqQQZuOakMGnLmWHfQO\n\tCqRbD/aEjhotvK6RhC0iPOyD7TyQ42UliUinhj5PS1nDAskK6z03xEyo+QYL0FmgLAMy\n\t6RsQ==", "X-Gm-Message-State": "APjAAAW0qCVbzkWGOgKcSSQ0YtSRooJRkgj4DpfwgG0Yz1LMC2BaUna8\n\t2BfuO+xOtViN/o8vhaqv797HCJJ9HH0=", "X-Google-Smtp-Source": "APXvYqw6GApXXcPrZxoM7ysWuBit05AkMDlIE9y+vvUHLBM7DFWtmu3+2n7VpsmfbIvw5eqd1NInXg==", "X-Received": "by 2002:a62:1c92:: with SMTP id\n\tc140mr6151973pfc.258.1559157313006; \n\tWed, 29 May 2019 12:15:13 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Wed, 29 May 2019 12:14:59 -0700", "Message-Id": "<20190529191501.19053-11-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190529191501.19053-1-stephen@networkplumber.org>", "References": "<20190529191501.19053-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 10/12] net/i40e: remove unnecessary cast", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The device private pointer (dev_private) is of type void *\ntherefore no cast is necessary in C.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/i40e/i40e_ethdev.c | 24 +++++++-----------------\n 1 file changed, 7 insertions(+), 17 deletions(-)", "diff": "diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex f4d778ea2df7..24b2ce245557 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -1211,11 +1211,9 @@ i40e_parse_latest_vec_handler(__rte_unused const char *key,\n \t\t\t\tconst char *value,\n \t\t\t\tvoid *opaque)\n {\n-\tstruct i40e_adapter *ad;\n+\tstruct i40e_adapter *ad = opaque;\n \tint use_latest_vec;\n \n-\tad = (struct i40e_adapter *)opaque;\n-\n \tuse_latest_vec = atoi(value);\n \n \tif (use_latest_vec != 0 && use_latest_vec != 1)\n@@ -10843,8 +10841,7 @@ static void\n i40e_start_timecounters(struct rte_eth_dev *dev)\n {\n \tstruct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n-\tstruct i40e_adapter *adapter =\n-\t\t\t(struct i40e_adapter *)dev->data->dev_private;\n+\tstruct i40e_adapter *adapter = dev->data->dev_private;\n \tstruct rte_eth_link link;\n \tuint32_t tsync_inc_l;\n \tuint32_t tsync_inc_h;\n@@ -10896,8 +10893,7 @@ i40e_start_timecounters(struct rte_eth_dev *dev)\n static int\n i40e_timesync_adjust_time(struct rte_eth_dev *dev, int64_t delta)\n {\n-\tstruct i40e_adapter *adapter =\n-\t\t\t(struct i40e_adapter *)dev->data->dev_private;\n+\tstruct i40e_adapter *adapter = dev->data->dev_private;\n \n \tadapter->systime_tc.nsec += delta;\n \tadapter->rx_tstamp_tc.nsec += delta;\n@@ -10910,8 +10906,7 @@ static int\n i40e_timesync_write_time(struct rte_eth_dev *dev, const struct timespec *ts)\n {\n \tuint64_t ns;\n-\tstruct i40e_adapter *adapter =\n-\t\t\t(struct i40e_adapter *)dev->data->dev_private;\n+\tstruct i40e_adapter *adapter = dev->data->dev_private;\n \n \tns = rte_timespec_to_ns(ts);\n \n@@ -10927,8 +10922,7 @@ static int\n i40e_timesync_read_time(struct rte_eth_dev *dev, struct timespec *ts)\n {\n \tuint64_t ns, systime_cycles;\n-\tstruct i40e_adapter *adapter =\n-\t\t\t(struct i40e_adapter *)dev->data->dev_private;\n+\tstruct i40e_adapter *adapter = dev->data->dev_private;\n \n \tsystime_cycles = i40e_read_systime_cyclecounter(dev);\n \tns = rte_timecounter_update(&adapter->systime_tc, systime_cycles);\n@@ -11004,9 +10998,7 @@ i40e_timesync_read_rx_timestamp(struct rte_eth_dev *dev,\n \t\t\t\tstruct timespec *timestamp, uint32_t flags)\n {\n \tstruct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n-\tstruct i40e_adapter *adapter =\n-\t\t(struct i40e_adapter *)dev->data->dev_private;\n-\n+\tstruct i40e_adapter *adapter = dev->data->dev_private;\n \tuint32_t sync_status;\n \tuint32_t index = flags & 0x03;\n \tuint64_t rx_tstamp_cycles;\n@@ -11028,9 +11020,7 @@ i40e_timesync_read_tx_timestamp(struct rte_eth_dev *dev,\n \t\t\t\tstruct timespec *timestamp)\n {\n \tstruct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n-\tstruct i40e_adapter *adapter =\n-\t\t(struct i40e_adapter *)dev->data->dev_private;\n-\n+\tstruct i40e_adapter *adapter = dev->data->dev_private;\n \tuint32_t sync_status;\n \tuint64_t tx_tstamp_cycles;\n \tuint64_t ns;\n", "prefixes": [ "10/12" ] }