Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53866/?format=api
{ "id": 53866, "url": "http://patches.dpdk.org/api/patches/53866/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190529191501.19053-9-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190529191501.19053-9-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190529191501.19053-9-stephen@networkplumber.org", "date": "2019-05-29T19:14:57", "name": "[08/12] net/ena: remove unnecessary cast", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "80532e2392a21360ab88fc15c455700fb15c4f5a", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190529191501.19053-9-stephen@networkplumber.org/mbox/", "series": [ { "id": 4816, "url": "http://patches.dpdk.org/api/series/4816/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4816", "date": "2019-05-29T19:14:49", "name": "cleanup useless casts of void *", "version": 1, "mbox": "http://patches.dpdk.org/series/4816/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53866/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/53866/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 806DE1B9BC;\n\tWed, 29 May 2019 21:15:31 +0200 (CEST)", "from mail-pl1-f193.google.com (mail-pl1-f193.google.com\n\t[209.85.214.193]) by dpdk.org (Postfix) with ESMTP id 9F2321B970\n\tfor <dev@dpdk.org>; Wed, 29 May 2019 21:15:12 +0200 (CEST)", "by mail-pl1-f193.google.com with SMTP id go2so1451030plb.9\n\tfor <dev@dpdk.org>; Wed, 29 May 2019 12:15:12 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tt18sm142943pgm.69.2019.05.29.12.15.10\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 29 May 2019 12:15:10 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=QpMJslE7XwRgShDnI9OlHl3W91lMZMNB4fQtflhRRlw=;\n\tb=VYDUJmKFzZI6Ww7pvwU23ojC+JLJT5Hne3/jDiNqNSUqolsNhoHT9rXA20waxLdQx2\n\thR4aVLzYklGw24sACeMStD6aETsgqjla2ADTBsK/rmYmmPrv1XJhVwTo6MNiWvcTgEo5\n\tR+0K1NFOl+Q5QNVC0WOrE8GautqR3XO2Mh+bJlzlRkbBr6bWZYZSQIZ06h2fPy61GOrs\n\tWtOWGj02MGMfNWGIw2g19XwD43syR8vviiqiqLTgqFcDPKmYSkDPvh31HJrlP6YX3NXz\n\tpDGjpYbhZLZ9YEugp0eoGDao2qMOnjmSZxikP95bn6jc3FBtAAl0vAhKtqwQUx/G4tez\n\tA4fg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=QpMJslE7XwRgShDnI9OlHl3W91lMZMNB4fQtflhRRlw=;\n\tb=YPYLTsmsELWfaShKNn8YP/YuZ6T+sU9UlA7tDFuCt6tFOcrbN5jWG5ol4e5cjH/8ES\n\t7zCpfzx4ZdfvX7hzDIS9sa9dYzKCe5HKpluPZJgeBYCogsPEbjkSl9/HoEZtyM4m+OKm\n\tdFKUC+rJBt1BWnHNvp9Z8DpZOn5wmpsM4fSHVy3Jnhpi+ErBglo0ZaeTKJ56+BcShxco\n\tp924/gIAGT7yubzF+9erJNkxPJuZyO9YH2C6zm0h1ZLwDEXn3b2rCQCvQXFT8gYIYGM4\n\t9xBbWQbLsefh3fjtuIIWrsABnJz5UnxSQX07uxJxjFJdnps68ZZDRFcBzh81H0faIm8m\n\tWpoQ==", "X-Gm-Message-State": "APjAAAUhw7nx6nvO6EYSO+wfsAagUp88X5KLxWgipTDpfw455KxPaBKt\n\tS+5whRiBZX/yCqheWeYCLRT2lYFZskI=", "X-Google-Smtp-Source": "APXvYqyV6obERb7c2dya9r7qxzy2rrhCC0LgmzW9K/5thcnJZL/OW6iM6WonkjYKECj4yL1mGU3Diw==", "X-Received": "by 2002:a17:902:aa85:: with SMTP id\n\td5mr142985024plr.245.1559157311027; \n\tWed, 29 May 2019 12:15:11 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Wed, 29 May 2019 12:14:57 -0700", "Message-Id": "<20190529191501.19053-9-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190529191501.19053-1-stephen@networkplumber.org>", "References": "<20190529191501.19053-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 08/12] net/ena: remove unnecessary cast", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The device private pointer (dev_private) is of type void *\ntherefore no cast is necessary in C.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/ena/ena_ethdev.c | 66 +++++++++++++-----------------------\n 1 file changed, 24 insertions(+), 42 deletions(-)", "diff": "diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex b6651fc0fddb..ff88b178afa4 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -493,8 +493,7 @@ static void ena_close(struct rte_eth_dev *dev)\n {\n \tstruct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);\n \tstruct rte_intr_handle *intr_handle = &pci_dev->intr_handle;\n-\tstruct ena_adapter *adapter =\n-\t\t(struct ena_adapter *)(dev->data->dev_private);\n+\tstruct ena_adapter *adapter = dev->data->dev_private;\n \n \tif (adapter->state == ENA_ADAPTER_STATE_RUNNING)\n \t\tena_stop(dev);\n@@ -535,8 +534,7 @@ static int ena_rss_reta_update(struct rte_eth_dev *dev,\n \t\t\t struct rte_eth_rss_reta_entry64 *reta_conf,\n \t\t\t uint16_t reta_size)\n {\n-\tstruct ena_adapter *adapter =\n-\t\t(struct ena_adapter *)(dev->data->dev_private);\n+\tstruct ena_adapter *adapter = dev->data->dev_private;\n \tstruct ena_com_dev *ena_dev = &adapter->ena_dev;\n \tint rc, i;\n \tu16 entry_value;\n@@ -591,8 +589,7 @@ static int ena_rss_reta_query(struct rte_eth_dev *dev,\n \t\t\t struct rte_eth_rss_reta_entry64 *reta_conf,\n \t\t\t uint16_t reta_size)\n {\n-\tstruct ena_adapter *adapter =\n-\t\t(struct ena_adapter *)(dev->data->dev_private);\n+\tstruct ena_adapter *adapter = dev->data->dev_private;\n \tstruct ena_com_dev *ena_dev = &adapter->ena_dev;\n \tint rc;\n \tint i;\n@@ -768,9 +765,7 @@ static int ena_link_update(struct rte_eth_dev *dev,\n \t\t\t __rte_unused int wait_to_complete)\n {\n \tstruct rte_eth_link *link = &dev->data->dev_link;\n-\tstruct ena_adapter *adapter;\n-\n-\tadapter = (struct ena_adapter *)(dev->data->dev_private);\n+\tstruct ena_adapter *adapter =dev->data->dev_private;\n \n \tlink->link_status = adapter->link_status ? ETH_LINK_UP : ETH_LINK_DOWN;\n \tlink->link_speed = ETH_SPEED_NUM_NONE;\n@@ -782,8 +777,7 @@ static int ena_link_update(struct rte_eth_dev *dev,\n static int ena_queue_start_all(struct rte_eth_dev *dev,\n \t\t\t enum ena_ring_type ring_type)\n {\n-\tstruct ena_adapter *adapter =\n-\t\t(struct ena_adapter *)(dev->data->dev_private);\n+\tstruct ena_adapter *adapter = dev->data->dev_private;\n \tstruct ena_ring *queues = NULL;\n \tint nb_queues;\n \tint i = 0;\n@@ -928,8 +922,7 @@ ena_calc_queue_size(struct ena_calc_queue_size_ctx *ctx)\n \n static void ena_stats_restart(struct rte_eth_dev *dev)\n {\n-\tstruct ena_adapter *adapter =\n-\t\t(struct ena_adapter *)(dev->data->dev_private);\n+\tstruct ena_adapter *adapter = dev->data->dev_private;\n \n \trte_atomic64_init(&adapter->drv_stats->ierrors);\n \trte_atomic64_init(&adapter->drv_stats->oerrors);\n@@ -941,8 +934,7 @@ static int ena_stats_get(struct rte_eth_dev *dev,\n \t\t\t struct rte_eth_stats *stats)\n {\n \tstruct ena_admin_basic_stats ena_stats;\n-\tstruct ena_adapter *adapter =\n-\t\t(struct ena_adapter *)(dev->data->dev_private);\n+\tstruct ena_adapter *adapter = dev->data->dev_private;\n \tstruct ena_com_dev *ena_dev = &adapter->ena_dev;\n \tint rc;\n \tint i;\n@@ -1005,7 +997,7 @@ static int ena_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)\n \n \tena_assert_msg(dev->data != NULL, \"Uninitialized device\\n\");\n \tena_assert_msg(dev->data->dev_private != NULL, \"Uninitialized device\\n\");\n-\tadapter = (struct ena_adapter *)(dev->data->dev_private);\n+\tadapter = dev->data->dev_private;\n \n \tena_dev = &adapter->ena_dev;\n \tena_assert_msg(ena_dev != NULL, \"Uninitialized device\\n\");\n@@ -1029,8 +1021,7 @@ static int ena_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)\n \n static int ena_start(struct rte_eth_dev *dev)\n {\n-\tstruct ena_adapter *adapter =\n-\t\t(struct ena_adapter *)(dev->data->dev_private);\n+\tstruct ena_adapter *adapter = dev->data->dev_private;\n \tuint64_t ticks;\n \tint rc = 0;\n \n@@ -1076,8 +1067,7 @@ static int ena_start(struct rte_eth_dev *dev)\n \n static void ena_stop(struct rte_eth_dev *dev)\n {\n-\tstruct ena_adapter *adapter =\n-\t\t(struct ena_adapter *)(dev->data->dev_private);\n+\tstruct ena_adapter *adapter = dev->data->dev_private;\n \tstruct ena_com_dev *ena_dev = &adapter->ena_dev;\n \tint rc;\n \n@@ -1169,8 +1159,7 @@ static void ena_queue_stop(struct ena_ring *ring)\n static void ena_queue_stop_all(struct rte_eth_dev *dev,\n \t\t\t enum ena_ring_type ring_type)\n {\n-\tstruct ena_adapter *adapter =\n-\t\t(struct ena_adapter *)(dev->data->dev_private);\n+\tstruct ena_adapter *adapter = dev->data->dev_private;\n \tstruct ena_ring *queues = NULL;\n \tuint16_t nb_queues, i;\n \n@@ -1228,8 +1217,7 @@ static int ena_tx_queue_setup(struct rte_eth_dev *dev,\n \t\t\t const struct rte_eth_txconf *tx_conf)\n {\n \tstruct ena_ring *txq = NULL;\n-\tstruct ena_adapter *adapter =\n-\t\t(struct ena_adapter *)(dev->data->dev_private);\n+\tstruct ena_adapter *adapter = dev->data->dev_private;\n \tunsigned int i;\n \n \ttxq = &adapter->tx_ring[queue_idx];\n@@ -1313,8 +1301,7 @@ static int ena_rx_queue_setup(struct rte_eth_dev *dev,\n \t\t\t __rte_unused const struct rte_eth_rxconf *rx_conf,\n \t\t\t struct rte_mempool *mp)\n {\n-\tstruct ena_adapter *adapter =\n-\t\t(struct ena_adapter *)(dev->data->dev_private);\n+\tstruct ena_adapter *adapter = dev->data->dev_private;\n \tstruct ena_ring *rxq = NULL;\n \tint i;\n \n@@ -1558,7 +1545,7 @@ static int ena_device_init(struct ena_com_dev *ena_dev,\n \n static void ena_interrupt_handler_rte(void *cb_arg)\n {\n-\tstruct ena_adapter *adapter = (struct ena_adapter *)cb_arg;\n+\tstruct ena_adapter *adapter = cb_arg;\n \tstruct ena_com_dev *ena_dev = &adapter->ena_dev;\n \n \tena_com_admin_q_comp_intr_handler(ena_dev);\n@@ -1596,7 +1583,7 @@ static void check_for_admin_com_state(struct ena_adapter *adapter)\n static void ena_timer_wd_callback(__rte_unused struct rte_timer *timer,\n \t\t\t\t void *arg)\n {\n-\tstruct ena_adapter *adapter = (struct ena_adapter *)arg;\n+\tstruct ena_adapter *adapter = arg;\n \tstruct rte_eth_dev *dev = adapter->rte_dev;\n \n \tcheck_for_missing_keep_alive(adapter);\n@@ -1703,8 +1690,7 @@ static int eth_ena_dev_init(struct rte_eth_dev *eth_dev)\n \tstruct ena_calc_queue_size_ctx calc_queue_ctx = { 0 };\n \tstruct rte_pci_device *pci_dev;\n \tstruct rte_intr_handle *intr_handle;\n-\tstruct ena_adapter *adapter =\n-\t\t(struct ena_adapter *)(eth_dev->data->dev_private);\n+\tstruct ena_adapter *adapter = eth_dev->data->dev_private;\n \tstruct ena_com_dev *ena_dev = &adapter->ena_dev;\n \tstruct ena_com_dev_get_features_ctx get_feat_ctx;\n \tstruct ena_llq_configurations llq_config;\n@@ -1862,8 +1848,7 @@ static int eth_ena_dev_init(struct rte_eth_dev *eth_dev)\n \n static void ena_destroy_device(struct rte_eth_dev *eth_dev)\n {\n-\tstruct ena_adapter *adapter =\n-\t\t(struct ena_adapter *)(eth_dev->data->dev_private);\n+\tstruct ena_adapter *adapter = eth_dev->data->dev_private;\n \tstruct ena_com_dev *ena_dev = &adapter->ena_dev;\n \n \tif (adapter->state == ENA_ADAPTER_STATE_FREE)\n@@ -1902,8 +1887,7 @@ static int eth_ena_dev_uninit(struct rte_eth_dev *eth_dev)\n \n static int ena_dev_configure(struct rte_eth_dev *dev)\n {\n-\tstruct ena_adapter *adapter =\n-\t\t(struct ena_adapter *)(dev->data->dev_private);\n+\tstruct ena_adapter *adapter = dev->data->dev_private;\n \n \tadapter->state = ENA_ADAPTER_STATE_CONFIG;\n \n@@ -1948,7 +1932,7 @@ static void ena_infos_get(struct rte_eth_dev *dev,\n \n \tena_assert_msg(dev->data != NULL, \"Uninitialized device\\n\");\n \tena_assert_msg(dev->data->dev_private != NULL, \"Uninitialized device\\n\");\n-\tadapter = (struct ena_adapter *)(dev->data->dev_private);\n+\tadapter = dev->data->dev_private;\n \n \tena_dev = &adapter->ena_dev;\n \tena_assert_msg(ena_dev != NULL, \"Uninitialized device\\n\");\n@@ -2506,8 +2490,7 @@ static int ena_xstats_get(struct rte_eth_dev *dev,\n \t\t\t struct rte_eth_xstat *xstats,\n \t\t\t unsigned int n)\n {\n-\tstruct ena_adapter *adapter =\n-\t\t\t(struct ena_adapter *)(dev->data->dev_private);\n+\tstruct ena_adapter *adapter =dev->data->dev_private;\n \tunsigned int xstats_count = ena_xstats_calc_num(dev);\n \tunsigned int stat, i, count = 0;\n \tint stat_offset;\n@@ -2558,8 +2541,7 @@ static int ena_xstats_get_by_id(struct rte_eth_dev *dev,\n \t\t\t\tuint64_t *values,\n \t\t\t\tunsigned int n)\n {\n-\tstruct ena_adapter *adapter =\n-\t\t(struct ena_adapter *)(dev->data->dev_private);\n+\tstruct ena_adapter *adapter = dev->data->dev_private;\n \tuint64_t id;\n \tuint64_t rx_entries, tx_entries;\n \tunsigned int i;\n@@ -2649,7 +2631,7 @@ static void ena_update_on_link_change(void *adapter_data,\n \tstruct ena_admin_aenq_link_change_desc *aenq_link_desc;\n \tuint32_t status;\n \n-\tadapter = (struct ena_adapter *)adapter_data;\n+\tadapter = adapter_data;\n \taenq_link_desc = (struct ena_admin_aenq_link_change_desc *)aenq_e;\n \teth_dev = adapter->rte_dev;\n \n@@ -2663,7 +2645,7 @@ static void ena_update_on_link_change(void *adapter_data,\n static void ena_notification(void *data,\n \t\t\t struct ena_admin_aenq_entry *aenq_e)\n {\n-\tstruct ena_adapter *adapter = (struct ena_adapter *)data;\n+\tstruct ena_adapter *adapter = data;\n \tstruct ena_admin_ena_hw_hints *hints;\n \n \tif (aenq_e->aenq_common_desc.group != ENA_ADMIN_NOTIFICATION)\n@@ -2686,7 +2668,7 @@ static void ena_notification(void *data,\n static void ena_keep_alive(void *adapter_data,\n \t\t\t __rte_unused struct ena_admin_aenq_entry *aenq_e)\n {\n-\tstruct ena_adapter *adapter = (struct ena_adapter *)adapter_data;\n+\tstruct ena_adapter *adapter = adapter_data;\n \tstruct ena_admin_aenq_keep_alive_desc *desc;\n \tuint64_t rx_drops;\n \n", "prefixes": [ "08/12" ] }