Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53865/?format=api
{ "id": 53865, "url": "http://patches.dpdk.org/api/patches/53865/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190529191501.19053-8-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190529191501.19053-8-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190529191501.19053-8-stephen@networkplumber.org", "date": "2019-05-29T19:14:56", "name": "[07/12] net/e1000: remove unnecessary cast of void *", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "4496f850771e8bc614fedf51fdffc449da1606d3", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190529191501.19053-8-stephen@networkplumber.org/mbox/", "series": [ { "id": 4816, "url": "http://patches.dpdk.org/api/series/4816/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4816", "date": "2019-05-29T19:14:49", "name": "cleanup useless casts of void *", "version": 1, "mbox": "http://patches.dpdk.org/series/4816/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53865/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/53865/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1AB491B9B4;\n\tWed, 29 May 2019 21:15:29 +0200 (CEST)", "from mail-pg1-f196.google.com (mail-pg1-f196.google.com\n\t[209.85.215.196]) by dpdk.org (Postfix) with ESMTP id A07FE1B95D\n\tfor <dev@dpdk.org>; Wed, 29 May 2019 21:15:11 +0200 (CEST)", "by mail-pg1-f196.google.com with SMTP id 33so444709pgv.9\n\tfor <dev@dpdk.org>; Wed, 29 May 2019 12:15:11 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tt18sm142943pgm.69.2019.05.29.12.15.09\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 29 May 2019 12:15:09 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=idO1HUYY2jPvLY7GL6c2nurc1hpEmi50VV4RzlULMno=;\n\tb=KqxC82x4k6Ehk8/F5ub8sYQJ5/qw30Ew5lNxEWAlwxNkTP7iMeIxJSydTekFEex08W\n\tFQ5G/L1VVRbzydZxOC0sBnfGGlDCsbQYup390LusXN/16YtHpx49yy+kKEL0lHOMXgbC\n\tTB0mtzk6UB29JzUsOmCDoRlkozrbXbZWfxJY6+6fF7e6cXJHWz8fYT9zHA62A+s+UIFc\n\tujTST7U7359GSobUmbNLjV3ayZKZzaNiX24A9BLjyqq2KZv/2M3LNf1mhL6XxJ+9FYI0\n\tfKSRDTi9e+wcgMSmX7lm6wIQF3TfckI0p69TYMlMQNi+AqTfRJjRYHiCO84CIBiyTssa\n\t9Ghw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=idO1HUYY2jPvLY7GL6c2nurc1hpEmi50VV4RzlULMno=;\n\tb=N5lkb9/EWGEl9FH0ayCtGJYYS99nvB9X6sL6CRIxDlxW8u3tTDV+YsR6OnuGOJB4Cu\n\tdebEURYFxEVOhIz86r/FDfnuoIkcySk0SEIbtNE0hlv8GsoSNT8/1TTXwH7zyTqE/rWu\n\tXVxuI03CXJdiKFdRsM0yjWLSR/nhPxV4l81Vu9mXJFdeYJxBm27RXU+ZaVCrvNcFrHrE\n\tO/2vHez63+6Ji8sfybLlOExyn0uV0Dlf5WqB+g5drSbMgnjWsWp9LZBfXCXbI/v3BOqF\n\tA8YQOQpDldAy/S5ygzq7SpSlaM8JHwnDpRnMSbwV+ja2iUc2HCJWGZ1frklKgKumqJw0\n\tPeLw==", "X-Gm-Message-State": "APjAAAUBS35tGRvejspMdR84v6m6Mp9qHK5Lr5E1sdKwdjsL7ZLtH4BC\n\tij816r919gvcsnhi4CrhITXRju8fu0c=", "X-Google-Smtp-Source": "APXvYqz+CrTjvK+rO9/t5zEOzJAnF+FIHanxk6mJKLt6Vd0ASUJGgbHJkPaNuoRxGsFV1mMf60rqAA==", "X-Received": "by 2002:a62:1885:: with SMTP id\n\t127mr94510892pfy.48.1559157310274; \n\tWed, 29 May 2019 12:15:10 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Wed, 29 May 2019 12:14:56 -0700", "Message-Id": "<20190529191501.19053-8-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190529191501.19053-1-stephen@networkplumber.org>", "References": "<20190529191501.19053-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 07/12] net/e1000: remove unnecessary cast of void\n\t*", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "dev_private is void * so cast is unnecessary in C.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/e1000/igb_ethdev.c | 18 ++++++------------\n 1 file changed, 6 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c\nindex bd1c64c0367d..2e9fee6a3674 100644\n--- a/drivers/net/e1000/igb_ethdev.c\n+++ b/drivers/net/e1000/igb_ethdev.c\n@@ -5029,8 +5029,7 @@ static void\n igb_start_timecounters(struct rte_eth_dev *dev)\n {\n \tstruct e1000_hw *hw = E1000_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n-\tstruct e1000_adapter *adapter =\n-\t\t(struct e1000_adapter *)dev->data->dev_private;\n+\tstruct e1000_adapter *adapter = dev->data->dev_private;\n \tuint32_t incval = 1;\n \tuint32_t shift = 0;\n \tuint64_t mask = E1000_CYCLECOUNTER_MASK;\n@@ -5081,8 +5080,7 @@ igb_start_timecounters(struct rte_eth_dev *dev)\n static int\n igb_timesync_adjust_time(struct rte_eth_dev *dev, int64_t delta)\n {\n-\tstruct e1000_adapter *adapter =\n-\t\t\t(struct e1000_adapter *)dev->data->dev_private;\n+\tstruct e1000_adapter *adapter = dev->data->dev_private;\n \n \tadapter->systime_tc.nsec += delta;\n \tadapter->rx_tstamp_tc.nsec += delta;\n@@ -5095,8 +5093,7 @@ static int\n igb_timesync_write_time(struct rte_eth_dev *dev, const struct timespec *ts)\n {\n \tuint64_t ns;\n-\tstruct e1000_adapter *adapter =\n-\t\t\t(struct e1000_adapter *)dev->data->dev_private;\n+\tstruct e1000_adapter *adapter = dev->data->dev_private;\n \n \tns = rte_timespec_to_ns(ts);\n \n@@ -5112,8 +5109,7 @@ static int\n igb_timesync_read_time(struct rte_eth_dev *dev, struct timespec *ts)\n {\n \tuint64_t ns, systime_cycles;\n-\tstruct e1000_adapter *adapter =\n-\t\t\t(struct e1000_adapter *)dev->data->dev_private;\n+\tstruct e1000_adapter *adapter = dev->data->dev_private;\n \n \tsystime_cycles = igb_read_systime_cyclecounter(dev);\n \tns = rte_timecounter_update(&adapter->systime_tc, systime_cycles);\n@@ -5206,8 +5202,7 @@ igb_timesync_read_rx_timestamp(struct rte_eth_dev *dev,\n \t\t\t uint32_t flags __rte_unused)\n {\n \tstruct e1000_hw *hw = E1000_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n-\tstruct e1000_adapter *adapter =\n-\t\t\t(struct e1000_adapter *)dev->data->dev_private;\n+\tstruct e1000_adapter *adapter = dev->data->dev_private;\n \tuint32_t tsync_rxctl;\n \tuint64_t rx_tstamp_cycles;\n \tuint64_t ns;\n@@ -5228,8 +5223,7 @@ igb_timesync_read_tx_timestamp(struct rte_eth_dev *dev,\n \t\t\t struct timespec *timestamp)\n {\n \tstruct e1000_hw *hw = E1000_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n-\tstruct e1000_adapter *adapter =\n-\t\t\t(struct e1000_adapter *)dev->data->dev_private;\n+\tstruct e1000_adapter *adapter = dev->data->dev_private;\n \tuint32_t tsync_txctl;\n \tuint64_t tx_tstamp_cycles;\n \tuint64_t ns;\n", "prefixes": [ "07/12" ] }