Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53861/?format=api
{ "id": 53861, "url": "http://patches.dpdk.org/api/patches/53861/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190529191501.19053-4-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190529191501.19053-4-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190529191501.19053-4-stephen@networkplumber.org", "date": "2019-05-29T19:14:52", "name": "[03/12] net/axgbe: remove unnecessary cast", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9eb559ee32035f2f30634ea0e3022b88e59b4e90", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190529191501.19053-4-stephen@networkplumber.org/mbox/", "series": [ { "id": 4816, "url": "http://patches.dpdk.org/api/series/4816/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4816", "date": "2019-05-29T19:14:49", "name": "cleanup useless casts of void *", "version": 1, "mbox": "http://patches.dpdk.org/series/4816/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53861/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/53861/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A86551B994;\n\tWed, 29 May 2019 21:15:13 +0200 (CEST)", "from mail-pf1-f194.google.com (mail-pf1-f194.google.com\n\t[209.85.210.194]) by dpdk.org (Postfix) with ESMTP id 3127C1B953\n\tfor <dev@dpdk.org>; Wed, 29 May 2019 21:15:07 +0200 (CEST)", "by mail-pf1-f194.google.com with SMTP id r22so2239228pfh.9\n\tfor <dev@dpdk.org>; Wed, 29 May 2019 12:15:07 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tt18sm142943pgm.69.2019.05.29.12.15.05\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 29 May 2019 12:15:05 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=IMK3r+wfq74TxvgCCn9/fCes/WIOvHDAB6oWuzMMj8Y=;\n\tb=zRmTBE2i+CRhLHe5x9zOi+cho569bGBDSmlk4NnY9Qe1r1tKpRdOdMqpSgXvaqibDV\n\tbuI0HT4/hEOJQNkBEH4jXkTJTpVjDys8Qe34hNvFcAzY7dt10i7yvQfMfL9NZrfUmx7y\n\tBlHhbreLBvkSDABSrjgMPCIv1XTkq4mx87d4K1Vmak+D6fQIw5REOTJkk763MsP2yTYC\n\tAW73wpPgucjPko4MOJQAFdp/p0s1N2sCnW4s3p12Nc5iHw0zCrU5dtVz5h1w9OVJ+Ler\n\t3D28uANI7gQsEEtM/i7sgta6p7IYF/x0iLRom6UvGv/xJOZ2J5XxY5NSljTVJELWLfN6\n\tXAgA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=IMK3r+wfq74TxvgCCn9/fCes/WIOvHDAB6oWuzMMj8Y=;\n\tb=DOlR9Lglb2Y0MVUVNuAaDVu+nO5B9osrVeHeCqnn1itUB3/bt7afsBF89SVVET8vVm\n\tRTuJhknIMEhcWRO0CUFPcdKjVMl4cAwofTB8ANI78DquXVSTQTTkfHGO5/vKHweFfe/q\n\tKs6mhzrp6LKwNqlRDUW3hJXMf7u1pFnG19gSLbqM/zFdnBSgnORLgwu43eRbK05GOkiV\n\tBK50T1VfmA3HlPRwW22BaO67g4vSVIeXYjMWVuKbsnn3vusgVTi5ides7lTKiy+Eu1hR\n\tN0PWulw/xLG+vHr/c4VUfpOGQ3JSPQSxBIne4mcvwgIAPG0eCbOIScnf9aAk4HACcqs9\n\tYOYw==", "X-Gm-Message-State": "APjAAAUbMvvbLR2g95zMTdyWllC0v43g/JyBgddiVrJvXflnJaCOBmfp\n\tITgoAqmVa8YwsYUzzmOeKTgoxtgaGRs=", "X-Google-Smtp-Source": "APXvYqxU6f7t0F5C/KReJ3XrJG4BS4UzbyPQD35UEW0Ht/1En2B4aaURIsBXlGjDlC29FdehcTBlJA==", "X-Received": "by 2002:a63:fa16:: with SMTP id\n\ty22mr101245037pgh.15.1559157306042; \n\tWed, 29 May 2019 12:15:06 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Wed, 29 May 2019 12:14:52 -0700", "Message-Id": "<20190529191501.19053-4-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190529191501.19053-1-stephen@networkplumber.org>", "References": "<20190529191501.19053-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 03/12] net/axgbe: remove unnecessary cast", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The device private pointer (dev_private) is of type void *\ntherefore no cast is necessary in C.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/axgbe/axgbe_ethdev.c | 24 +++++++++++++++---------\n drivers/net/axgbe/axgbe_rxtx.c | 2 +-\n 2 files changed, 16 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c\nindex 221979c5e9f5..6b3bc3eea34f 100644\n--- a/drivers/net/axgbe/axgbe_ethdev.c\n+++ b/drivers/net/axgbe/axgbe_ethdev.c\n@@ -157,7 +157,7 @@ axgbe_dev_configure(struct rte_eth_dev *dev)\n static int\n axgbe_dev_rx_mq_config(struct rte_eth_dev *dev)\n {\n-\tstruct axgbe_port *pdata = (struct axgbe_port *)dev->data->dev_private;\n+\tstruct axgbe_port *pdata = dev->data->dev_private;\n \n \tif (dev->data->dev_conf.rxmode.mq_mode == ETH_MQ_RX_RSS)\n \t\tpdata->rss_enable = 1;\n@@ -171,10 +171,11 @@ axgbe_dev_rx_mq_config(struct rte_eth_dev *dev)\n static int\n axgbe_dev_start(struct rte_eth_dev *dev)\n {\n-\tPMD_INIT_FUNC_TRACE();\n-\tstruct axgbe_port *pdata = (struct axgbe_port *)dev->data->dev_private;\n+\tstruct axgbe_port *pdata = dev->data->dev_private;\n \tint ret;\n \n+\tPMD_INIT_FUNC_TRACE();\n+\n \t/* Multiqueue RSS */\n \tret = axgbe_dev_rx_mq_config(dev);\n \tif (ret) {\n@@ -209,9 +210,10 @@ axgbe_dev_start(struct rte_eth_dev *dev)\n static void\n axgbe_dev_stop(struct rte_eth_dev *dev)\n {\n-\tPMD_INIT_FUNC_TRACE();\n \tstruct axgbe_port *pdata = dev->data->dev_private;\n \n+\tPMD_INIT_FUNC_TRACE();\n+\n \trte_intr_disable(&pdata->pci_dev->intr_handle);\n \n \tif (axgbe_test_bit(AXGBE_STOPPED, &pdata->dev_state))\n@@ -237,27 +239,30 @@ axgbe_dev_close(struct rte_eth_dev *dev)\n static void\n axgbe_dev_promiscuous_enable(struct rte_eth_dev *dev)\n {\n-\tPMD_INIT_FUNC_TRACE();\n \tstruct axgbe_port *pdata = dev->data->dev_private;\n \n+\tPMD_INIT_FUNC_TRACE();\n+\n \tAXGMAC_IOWRITE_BITS(pdata, MAC_PFR, PR, 1);\n }\n \n static void\n axgbe_dev_promiscuous_disable(struct rte_eth_dev *dev)\n {\n-\tPMD_INIT_FUNC_TRACE();\n \tstruct axgbe_port *pdata = dev->data->dev_private;\n \n+\tPMD_INIT_FUNC_TRACE();\n+\n \tAXGMAC_IOWRITE_BITS(pdata, MAC_PFR, PR, 0);\n }\n \n static void\n axgbe_dev_allmulticast_enable(struct rte_eth_dev *dev)\n {\n-\tPMD_INIT_FUNC_TRACE();\n \tstruct axgbe_port *pdata = dev->data->dev_private;\n \n+\tPMD_INIT_FUNC_TRACE();\n+\n \tif (AXGMAC_IOREAD_BITS(pdata, MAC_PFR, PM))\n \t\treturn;\n \tAXGMAC_IOWRITE_BITS(pdata, MAC_PFR, PM, 1);\n@@ -266,9 +271,10 @@ axgbe_dev_allmulticast_enable(struct rte_eth_dev *dev)\n static void\n axgbe_dev_allmulticast_disable(struct rte_eth_dev *dev)\n {\n-\tPMD_INIT_FUNC_TRACE();\n \tstruct axgbe_port *pdata = dev->data->dev_private;\n \n+\tPMD_INIT_FUNC_TRACE();\n+\n \tif (!AXGMAC_IOREAD_BITS(pdata, MAC_PFR, PM))\n \t\treturn;\n \tAXGMAC_IOWRITE_BITS(pdata, MAC_PFR, PM, 0);\n@@ -578,7 +584,7 @@ eth_axgbe_dev_init(struct rte_eth_dev *eth_dev)\n \tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n \t\treturn 0;\n \n-\tpdata = (struct axgbe_port *)eth_dev->data->dev_private;\n+\tpdata = eth_dev->data->dev_private;\n \t/* initial state */\n \taxgbe_set_bit(AXGBE_DOWN, &pdata->dev_state);\n \taxgbe_set_bit(AXGBE_STOPPED, &pdata->dev_state);\ndiff --git a/drivers/net/axgbe/axgbe_rxtx.c b/drivers/net/axgbe/axgbe_rxtx.c\nindex e76601d149d5..cfc55b359ae8 100644\n--- a/drivers/net/axgbe/axgbe_rxtx.c\n+++ b/drivers/net/axgbe/axgbe_rxtx.c\n@@ -342,7 +342,7 @@ int axgbe_dev_tx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,\n \tconst struct rte_memzone *tz;\n \n \ttx_desc = nb_desc;\n-\tpdata = (struct axgbe_port *)dev->data->dev_private;\n+\tpdata = dev->data->dev_private;\n \n \t/*\n \t * validate tx descriptors count\n", "prefixes": [ "03/12" ] }