Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53860/?format=api
{ "id": 53860, "url": "http://patches.dpdk.org/api/patches/53860/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190529191501.19053-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190529191501.19053-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190529191501.19053-3-stephen@networkplumber.org", "date": "2019-05-29T19:14:51", "name": "[02/12] net/ark: remove unnecessary cast", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "5b770353353f8b8ae4681dca9633fcdae0629d15", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190529191501.19053-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 4816, "url": "http://patches.dpdk.org/api/series/4816/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4816", "date": "2019-05-29T19:14:49", "name": "cleanup useless casts of void *", "version": 1, "mbox": "http://patches.dpdk.org/series/4816/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53860/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/53860/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A236F1B964;\n\tWed, 29 May 2019 21:15:11 +0200 (CEST)", "from mail-pg1-f196.google.com (mail-pg1-f196.google.com\n\t[209.85.215.196]) by dpdk.org (Postfix) with ESMTP id CD33E378B\n\tfor <dev@dpdk.org>; Wed, 29 May 2019 21:15:06 +0200 (CEST)", "by mail-pg1-f196.google.com with SMTP id t1so468591pgc.2\n\tfor <dev@dpdk.org>; Wed, 29 May 2019 12:15:06 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tt18sm142943pgm.69.2019.05.29.12.15.04\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 29 May 2019 12:15:04 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=mZI+E/vvhT7YcobCcTP6W38kBjjfmvFJvTpM1g7Mr/o=;\n\tb=R4pUv9YxHm35ni11l2chQ/l9YhfKTbaZH4DMOUN+0WRp0Ti22fel/msbo9+m1VUgna\n\tkSu7VRy7UGWMfbej8aRUMH81KfFurckZ1I7vWrZNnuUvQdjn0DIEz65KAeCJdB0HSzl3\n\txMyL/njgL/SJQuB3+YW88xr8+zmfyIbbdmCt38QW1k3J74JVmKZCMyIN3q3JICN/jyVA\n\tkoU/fFO2lZxjzVfthYlnqG31VUyOh2mtBruD5Q+zHZEBD+UqlgSO/SrVHI8WSB70lrea\n\t3CBYl9s/YLdd8vQmcIszQqe8JMtw1GsNkEXm8UYxE5rIVwLiZLwi1QU35BvDMcuLCxP7\n\tNgwg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=mZI+E/vvhT7YcobCcTP6W38kBjjfmvFJvTpM1g7Mr/o=;\n\tb=WfcoA0a3LpsqehN8MyntrtdHoeL0cv+KMB6fgcXyQmi30sNSVmXt57l+0mai3sLxqd\n\tHEPsq+2eF2gxc2eP63s4T2myl1/1oaudi22GsuMkKLnE4rEectZId9xw5LeCW1MLj0y8\n\t2vc0WPkvLq45/xMGS/t6tybJrFkT05jwQe28+k11N6qeGsi7q1iIEfzSNTg4KUDG0KxN\n\tlr5vdhIRgwYBJh0kpvC/eIGQUd3UgXKyU8lspLuIS9lBrWb1eDLpnm6hP0Ni7M6a3UXl\n\tih9+2i8G/nzYvwkv7PM0/aywmLjudDG1chet8iEbmzVAdQqQiuG4a5D9SKB+MVwDGS5D\n\tVMMg==", "X-Gm-Message-State": "APjAAAVQIgkh2fdLVqa1IJF1SSllqcRzTYeQpdC5GRKEDqXC2DEioY0u\n\tgqiepl4fCh8veUhKzgby+ul+EuD1VlM=", "X-Google-Smtp-Source": "APXvYqzqWmjRSbiFevfAuJE9ZvbH7X/CqnPnUp6reVfutNCrhVrUm89uZtnEvyav3mXRisT2bgnulg==", "X-Received": "by 2002:aa7:9e0a:: with SMTP id y10mr100724pfq.190.1559157305333;\n\tWed, 29 May 2019 12:15:05 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Wed, 29 May 2019 12:14:51 -0700", "Message-Id": "<20190529191501.19053-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190529191501.19053-1-stephen@networkplumber.org>", "References": "<20190529191501.19053-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 02/12] net/ark: remove unnecessary cast", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The device private pointer (dev_private) is of type void *\ntherefore no cast is necessary in C.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/ark/ark_ethdev.c | 51 +++++++++++----------------------\n drivers/net/ark/ark_ethdev_rx.c | 4 +--\n drivers/net/ark/ark_ethdev_tx.c | 2 +-\n 3 files changed, 20 insertions(+), 37 deletions(-)", "diff": "diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c\nindex 7692aa2d9571..7fd784cd0e30 100644\n--- a/drivers/net/ark/ark_ethdev.c\n+++ b/drivers/net/ark/ark_ethdev.c\n@@ -241,8 +241,7 @@ check_for_ext(struct ark_adapter *ark)\n static int\n eth_ark_dev_init(struct rte_eth_dev *dev)\n {\n-\tstruct ark_adapter *ark =\n-\t\t(struct ark_adapter *)dev->data->dev_private;\n+\tstruct ark_adapter *ark = dev->data->dev_private;\n \tstruct rte_pci_device *pci_dev;\n \tint ret;\n \tint port_count = 1;\n@@ -418,8 +417,7 @@ eth_ark_dev_init(struct rte_eth_dev *dev)\n static int\n ark_config_device(struct rte_eth_dev *dev)\n {\n-\tstruct ark_adapter *ark =\n-\t\t(struct ark_adapter *)dev->data->dev_private;\n+\tstruct ark_adapter *ark = dev->data->dev_private;\n \tuint16_t num_q, i;\n \tstruct ark_mpu_t *mpu;\n \n@@ -494,8 +492,7 @@ ark_config_device(struct rte_eth_dev *dev)\n static int\n eth_ark_dev_uninit(struct rte_eth_dev *dev)\n {\n-\tstruct ark_adapter *ark =\n-\t\t(struct ark_adapter *)dev->data->dev_private;\n+\tstruct ark_adapter *ark = dev->data->dev_private;\n \n \tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n \t\treturn 0;\n@@ -517,8 +514,7 @@ static int\n eth_ark_dev_configure(struct rte_eth_dev *dev)\n {\n \tPMD_FUNC_LOG(DEBUG, \"\\n\");\n-\tstruct ark_adapter *ark =\n-\t\t(struct ark_adapter *)dev->data->dev_private;\n+\tstruct ark_adapter *ark = dev->data->dev_private;\n \n \teth_ark_dev_set_link_up(dev);\n \tif (ark->user_ext.dev_configure)\n@@ -544,8 +540,7 @@ delay_pg_start(void *arg)\n static int\n eth_ark_dev_start(struct rte_eth_dev *dev)\n {\n-\tstruct ark_adapter *ark =\n-\t\t(struct ark_adapter *)dev->data->dev_private;\n+\tstruct ark_adapter *ark = dev->data->dev_private;\n \tint i;\n \n \tPMD_FUNC_LOG(DEBUG, \"\\n\");\n@@ -597,8 +592,7 @@ eth_ark_dev_stop(struct rte_eth_dev *dev)\n {\n \tuint16_t i;\n \tint status;\n-\tstruct ark_adapter *ark =\n-\t\t(struct ark_adapter *)dev->data->dev_private;\n+\tstruct ark_adapter *ark = dev->data->dev_private;\n \tstruct ark_mpu_t *mpu;\n \n \tPMD_FUNC_LOG(DEBUG, \"\\n\");\n@@ -688,8 +682,7 @@ eth_ark_dev_stop(struct rte_eth_dev *dev)\n static void\n eth_ark_dev_close(struct rte_eth_dev *dev)\n {\n-\tstruct ark_adapter *ark =\n-\t\t(struct ark_adapter *)dev->data->dev_private;\n+\tstruct ark_adapter *ark = dev->data->dev_private;\n \tuint16_t i;\n \n \tif (ark->user_ext.dev_close)\n@@ -719,8 +712,7 @@ static void\n eth_ark_dev_info_get(struct rte_eth_dev *dev,\n \t\t struct rte_eth_dev_info *dev_info)\n {\n-\tstruct ark_adapter *ark =\n-\t\t(struct ark_adapter *)dev->data->dev_private;\n+\tstruct ark_adapter *ark = dev->data->dev_private;\n \tstruct ark_mpu_t *tx_mpu = RTE_PTR_ADD(ark->bar0, ARK_MPU_TX_BASE);\n \tstruct ark_mpu_t *rx_mpu = RTE_PTR_ADD(ark->bar0, ARK_MPU_RX_BASE);\n \tuint16_t ports = ark->num_ports;\n@@ -755,8 +747,7 @@ eth_ark_dev_link_update(struct rte_eth_dev *dev, int wait_to_complete)\n {\n \tPMD_DEBUG_LOG(DEBUG, \"link status = %d\\n\",\n \t\t\tdev->data->dev_link.link_status);\n-\tstruct ark_adapter *ark =\n-\t\t(struct ark_adapter *)dev->data->dev_private;\n+\tstruct ark_adapter *ark = dev->data->dev_private;\n \n \tif (ark->user_ext.link_update) {\n \t\treturn ark->user_ext.link_update\n@@ -770,8 +761,7 @@ static int\n eth_ark_dev_set_link_up(struct rte_eth_dev *dev)\n {\n \tdev->data->dev_link.link_status = 1;\n-\tstruct ark_adapter *ark =\n-\t\t(struct ark_adapter *)dev->data->dev_private;\n+\tstruct ark_adapter *ark = dev->data->dev_private;\n \n \tif (ark->user_ext.dev_set_link_up)\n \t\treturn ark->user_ext.dev_set_link_up(dev,\n@@ -783,8 +773,7 @@ static int\n eth_ark_dev_set_link_down(struct rte_eth_dev *dev)\n {\n \tdev->data->dev_link.link_status = 0;\n-\tstruct ark_adapter *ark =\n-\t\t(struct ark_adapter *)dev->data->dev_private;\n+\tstruct ark_adapter *ark = dev->data->dev_private;\n \n \tif (ark->user_ext.dev_set_link_down)\n \t\treturn ark->user_ext.dev_set_link_down(dev,\n@@ -796,8 +785,7 @@ static int\n eth_ark_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n {\n \tuint16_t i;\n-\tstruct ark_adapter *ark =\n-\t\t(struct ark_adapter *)dev->data->dev_private;\n+\tstruct ark_adapter *ark = dev->data->dev_private;\n \n \tstats->ipackets = 0;\n \tstats->ibytes = 0;\n@@ -820,8 +808,7 @@ static void\n eth_ark_dev_stats_reset(struct rte_eth_dev *dev)\n {\n \tuint16_t i;\n-\tstruct ark_adapter *ark =\n-\t\t(struct ark_adapter *)dev->data->dev_private;\n+\tstruct ark_adapter *ark = dev->data->dev_private;\n \n \tfor (i = 0; i < dev->data->nb_tx_queues; i++)\n \t\teth_tx_queue_stats_reset(dev->data->tx_queues[i]);\n@@ -838,8 +825,7 @@ eth_ark_macaddr_add(struct rte_eth_dev *dev,\n \t\t uint32_t index,\n \t\t uint32_t pool)\n {\n-\tstruct ark_adapter *ark =\n-\t\t(struct ark_adapter *)dev->data->dev_private;\n+\tstruct ark_adapter *ark = dev->data->dev_private;\n \n \tif (ark->user_ext.mac_addr_add) {\n \t\tark->user_ext.mac_addr_add(dev,\n@@ -855,8 +841,7 @@ eth_ark_macaddr_add(struct rte_eth_dev *dev,\n static void\n eth_ark_macaddr_remove(struct rte_eth_dev *dev, uint32_t index)\n {\n-\tstruct ark_adapter *ark =\n-\t\t(struct ark_adapter *)dev->data->dev_private;\n+\tstruct ark_adapter *ark = dev->data->dev_private;\n \n \tif (ark->user_ext.mac_addr_remove)\n \t\tark->user_ext.mac_addr_remove(dev, index,\n@@ -867,8 +852,7 @@ static int\n eth_ark_set_default_mac_addr(struct rte_eth_dev *dev,\n \t\t\t struct rte_ether_addr *mac_addr)\n {\n-\tstruct ark_adapter *ark =\n-\t\t(struct ark_adapter *)dev->data->dev_private;\n+\tstruct ark_adapter *ark = dev->data->dev_private;\n \n \tif (ark->user_ext.mac_addr_set) {\n \t\tark->user_ext.mac_addr_set(dev, mac_addr,\n@@ -881,8 +865,7 @@ eth_ark_set_default_mac_addr(struct rte_eth_dev *dev,\n static int\n eth_ark_set_mtu(struct rte_eth_dev *dev, uint16_t size)\n {\n-\tstruct ark_adapter *ark =\n-\t\t(struct ark_adapter *)dev->data->dev_private;\n+\tstruct ark_adapter *ark = dev->data->dev_private;\n \n \tif (ark->user_ext.set_mtu)\n \t\treturn ark->user_ext.set_mtu(dev, size,\ndiff --git a/drivers/net/ark/ark_ethdev_rx.c b/drivers/net/ark/ark_ethdev_rx.c\nindex 300029d6b86e..7de1a9851683 100644\n--- a/drivers/net/ark/ark_ethdev_rx.c\n+++ b/drivers/net/ark/ark_ethdev_rx.c\n@@ -121,7 +121,7 @@ eth_ark_dev_rx_queue_setup(struct rte_eth_dev *dev,\n \t\t\t struct rte_mempool *mb_pool)\n {\n \tstatic int warning1;\t\t/* = 0 */\n-\tstruct ark_adapter *ark = (struct ark_adapter *)dev->data->dev_private;\n+\tstruct ark_adapter *ark = dev->data->dev_private;\n \n \tstruct ark_rx_queue *queue;\n \tuint32_t i;\n@@ -611,7 +611,7 @@ eth_rx_queue_stats_reset(void *vqueue)\n void\n eth_ark_udm_force_close(struct rte_eth_dev *dev)\n {\n-\tstruct ark_adapter *ark = (struct ark_adapter *)dev->data->dev_private;\n+\tstruct ark_adapter *ark = dev->data->dev_private;\n \tstruct ark_rx_queue *queue;\n \tuint32_t index;\n \tuint16_t i;\ndiff --git a/drivers/net/ark/ark_ethdev_tx.c b/drivers/net/ark/ark_ethdev_tx.c\nindex 94da5f9580a2..1967655707aa 100644\n--- a/drivers/net/ark/ark_ethdev_tx.c\n+++ b/drivers/net/ark/ark_ethdev_tx.c\n@@ -207,7 +207,7 @@ eth_ark_tx_queue_setup(struct rte_eth_dev *dev,\n \t\t unsigned int socket_id,\n \t\t const struct rte_eth_txconf *tx_conf __rte_unused)\n {\n-\tstruct ark_adapter *ark = (struct ark_adapter *)dev->data->dev_private;\n+\tstruct ark_adapter *ark = dev->data->dev_private;\n \tstruct ark_tx_queue *queue;\n \tint status;\n \n", "prefixes": [ "02/12" ] }