Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53859/?format=api
{ "id": 53859, "url": "http://patches.dpdk.org/api/patches/53859/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190529191501.19053-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190529191501.19053-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190529191501.19053-2-stephen@networkplumber.org", "date": "2019-05-29T19:14:50", "name": "[01/12] net/atlantic: remove unnecessary cast", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "295d0d971400f4bb5bb32a89e42cfa78d09716d1", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190529191501.19053-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 4816, "url": "http://patches.dpdk.org/api/series/4816/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4816", "date": "2019-05-29T19:14:49", "name": "cleanup useless casts of void *", "version": 1, "mbox": "http://patches.dpdk.org/series/4816/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53859/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/53859/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7E0FA1B958;\n\tWed, 29 May 2019 21:15:09 +0200 (CEST)", "from mail-pg1-f196.google.com (mail-pg1-f196.google.com\n\t[209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 6D24A1B94A\n\tfor <dev@dpdk.org>; Wed, 29 May 2019 21:15:05 +0200 (CEST)", "by mail-pg1-f196.google.com with SMTP id d30so452833pgm.7\n\tfor <dev@dpdk.org>; Wed, 29 May 2019 12:15:05 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tt18sm142943pgm.69.2019.05.29.12.15.03\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 29 May 2019 12:15:03 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=/WyC+7OA5STF4b9iqyxFBYuEJjkONb2wmxa+LHXlZ7M=;\n\tb=wFEuuGZ/7cShHqIfubm+aTJnp+Y3Wf0B1Y0kxwwpjX357zvQIvT0LDFwCDs3VtfhR5\n\tReptRIDoHFKL9rTylEaPK7FlpenmxXy4VW69zcR9m+OKowo6vY+6q0oCaF4Do6CW+/1w\n\tXSwqf8/lqqrQK38ljFAZZ+3RUykwZsqyeHnSlKlsTUbjYro7h2N/hPfnYPppg36iPaqw\n\twu3qW1NHJ7Nw8OApI3AHLlRaxEFtBGFrNSb1ma/7dNrgG7wXQ21MwFoLH8eJhgNES4K/\n\txRtypwd8cu5q3GyKliVbsGJ09w4+UG8wtjUPtdxwJAqXjts92JYoLeENFPeWziKZgrhv\n\tOzdQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=/WyC+7OA5STF4b9iqyxFBYuEJjkONb2wmxa+LHXlZ7M=;\n\tb=AcnXUX40NTf1KvxkvQBafN6XTJx4U+Pq4DMrmZrXrif/lR2jHcPtHEEUTBfqQ9t8pU\n\tr8l2FK5xPyP0IAS5FsD8xfy3mzhrtwpL75ZebcqD1o3KgUag5APKVbxHj9ipmhExWTHF\n\tOSpvXnUodpVmd4g12+HX95/r2JNSVmg+RKk+07tGZ/ab9Tzn54beFCqTZ+NAwVe7it2d\n\tRZM3pTrZKzueCNBO2CjPMAXA4NcQNcaLozhRT6WB26O2vJww7MuR9t9B5KhaZfaLmFma\n\tLkrjs5gE2gBtNBI2uhYBpTEIgJ8G+Ld/8ez0oACrr1VKx/FpuZFA0RUI/FfYu6FbPWCe\n\t1vEw==", "X-Gm-Message-State": "APjAAAU1iYP+D2ySXJaYm/BTULaNw1fkGCk0i14CHyq0QLaH1Lx2KJDQ\n\tEQXaSWSJJUctEeDUuM4vCx42q8FoXVQ=", "X-Google-Smtp-Source": "APXvYqyAVHd/Z+mIGcPIP59LfFOp4hPa68F70n/0R0YHXqpYZOSjQmlRS7m1/TTOln1T3HNCaPkSjA==", "X-Received": "by 2002:aa7:8a87:: with SMTP id\n\ta7mr114268090pfc.53.1559157304305; \n\tWed, 29 May 2019 12:15:04 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Wed, 29 May 2019 12:14:50 -0700", "Message-Id": "<20190529191501.19053-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190529191501.19053-1-stephen@networkplumber.org>", "References": "<20190529191501.19053-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 01/12] net/atlantic: remove unnecessary cast", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The device private pointer (dev_private) is of type void *\ntherefore no cast is necessary in C.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/atlantic/atl_ethdev.c | 9 +++------\n 1 file changed, 3 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/atlantic/atl_ethdev.c b/drivers/net/atlantic/atl_ethdev.c\nindex d110e351ec03..fdc0a7f2db96 100644\n--- a/drivers/net/atlantic/atl_ethdev.c\n+++ b/drivers/net/atlantic/atl_ethdev.c\n@@ -371,8 +371,7 @@ atl_disable_intr(struct aq_hw_s *hw)\n static int\n eth_atl_dev_init(struct rte_eth_dev *eth_dev)\n {\n-\tstruct atl_adapter *adapter =\n-\t\t(struct atl_adapter *)eth_dev->data->dev_private;\n+\tstruct atl_adapter *adapter = eth_dev->data->dev_private;\n \tstruct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(eth_dev);\n \tstruct rte_intr_handle *intr_handle = &pci_dev->intr_handle;\n \tstruct aq_hw_s *hw = ATL_DEV_PRIVATE_TO_HW(eth_dev->data->dev_private);\n@@ -1015,8 +1014,7 @@ static int\n atl_dev_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *stats,\n \t\t unsigned int n)\n {\n-\tstruct atl_adapter *adapter =\n-\t(struct atl_adapter *)dev->data->dev_private;\n+\tstruct atl_adapter *adapter = dev->data->dev_private;\n \tstruct aq_hw_s *hw = &adapter->hw;\n \tstruct get_stats req = { 0 };\n \tstruct macsec_msg_fw_request msg = { 0 };\n@@ -1352,8 +1350,7 @@ atl_dev_interrupt_action(struct rte_eth_dev *dev,\n {\n \tstruct atl_interrupt *intr =\n \t\tATL_DEV_PRIVATE_TO_INTR(dev->data->dev_private);\n-\tstruct atl_adapter *adapter =\n-\t\t(struct atl_adapter *)dev->data->dev_private;\n+\tstruct atl_adapter *adapter = dev->data->dev_private;\n \tstruct aq_hw_s *hw = &adapter->hw;\n \n \tif (!(intr->flags & ATL_FLAG_NEED_LINK_UPDATE))\n", "prefixes": [ "01/12" ] }