Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53855/?format=api
http://patches.dpdk.org/api/patches/53855/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190529163958.30796-2-i.maximets@samsung.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190529163958.30796-2-i.maximets@samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190529163958.30796-2-i.maximets@samsung.com", "date": "2019-05-29T16:39:57", "name": "[1/2] meson: don't check dependencies for tests if not required", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "04b12c60974580e8cfe03c1e547e5d263d0f4da7", "submitter": { "id": 323, "url": "http://patches.dpdk.org/api/people/323/?format=api", "name": "Ilya Maximets", "email": "i.maximets@samsung.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190529163958.30796-2-i.maximets@samsung.com/mbox/", "series": [ { "id": 4814, "url": "http://patches.dpdk.org/api/series/4814/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4814", "date": "2019-05-29T16:39:56", "name": "Make meson configurable.", "version": 1, "mbox": "http://patches.dpdk.org/series/4814/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53855/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/53855/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6D6071B95D;\n\tWed, 29 May 2019 18:40:11 +0200 (CEST)", "from mailout2.w1.samsung.com (mailout2.w1.samsung.com\n\t[210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 1B0D91B956\n\tfor <dev@dpdk.org>; Wed, 29 May 2019 18:40:08 +0200 (CEST)", "from eucas1p1.samsung.com (unknown [182.198.249.206])\n\tby mailout2.w1.samsung.com (KnoxPortal) with ESMTP id\n\t20190529164007euoutp02d3253b6b96b85fa072773248bde9e7a9~jNNpA_QFv2258622586euoutp02O\n\tfor <dev@dpdk.org>; Wed, 29 May 2019 16:40:07 +0000 (GMT)", "from eusmges3new.samsung.com (unknown [203.254.199.245]) by\n\teucas1p1.samsung.com (KnoxPortal) with ESMTP id\n\t20190529164007eucas1p1135e0485b091382ecc425a8bd6702606~jNNohNeQB0827108271eucas1p11;\n\tWed, 29 May 2019 16:40:07 +0000 (GMT)", "from eucas1p2.samsung.com ( [182.198.249.207]) by\n\teusmges3new.samsung.com (EUCPMTA) with SMTP id 50.80.04325.7E5BEEC5;\n\tWed, 29 May 2019 17:40:07 +0100 (BST)", "from eusmtrp1.samsung.com (unknown [182.198.249.138]) by\n\teucas1p2.samsung.com (KnoxPortal) with ESMTPA id\n\t20190529164006eucas1p296e902a46cb3ef7ac436d619f9e55d5b~jNNnrIqqz0279902799eucas1p2f;\n\tWed, 29 May 2019 16:40:06 +0000 (GMT)", "from eusmgms2.samsung.com (unknown [182.198.249.180]) by\n\teusmtrp1.samsung.com (KnoxPortal) with ESMTP id\n\t20190529164006eusmtrp1f6e2591dfb7d9870756b0362d995decf~jNNnbmH4a1240812408eusmtrp1H;\n\tWed, 29 May 2019 16:40:06 +0000 (GMT)", "from eusmtip2.samsung.com ( [203.254.199.222]) by\n\teusmgms2.samsung.com (EUCPMTA) with SMTP id FF.22.04140.6E5BEEC5;\n\tWed, 29 May 2019 17:40:06 +0100 (BST)", "from imaximets.rnd.samsung.ru (unknown [106.109.129.180]) by\n\teusmtip2.samsung.com (KnoxPortal) with ESMTPA id\n\t20190529164005eusmtip205d16f43fcd3d63727633d6df9ffe153~jNNm-t0Rf2748427484eusmtip2C;\n\tWed, 29 May 2019 16:40:05 +0000 (GMT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com\n\t20190529164007euoutp02d3253b6b96b85fa072773248bde9e7a9~jNNpA_QFv2258622586euoutp02O", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n\ts=mail20170921; t=1559148008;\n\tbh=fuIVcKPPXHF/fkWrEL9v7X8LuWw2qxpn1agTeV99i7E=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=DmJLBwD6rmOjEXjbVsT8G2VlxG6A2gdVXw83uSt8GQupkmnwW+RbKf12KLxXz4Y+S\n\tInyWAHoUwP2ecx40mUClZrt3oIMRNEU8488REyIshphdjwQ71YbF89t3mGUVsyNIs9\n\tx69spJTPI3dZWrL8pCtNGFFnab2j20Pt1Y7etFWk=", "X-AuditID": "cbfec7f5-b8fff700000010e5-bf-5ceeb5e783c0", "From": "Ilya Maximets <i.maximets@samsung.com>", "To": "dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>", "Cc": "Bruce Richardson <bruce.richardson@intel.com>, Aaron Conole\n\t<aconole@redhat.com>, Kevin Traynor <ktraynor@redhat.com>, Ilya Maximets\n\t<i.maximets@samsung.com>", "Date": "Wed, 29 May 2019 19:39:57 +0300", "Message-Id": "<20190529163958.30796-2-i.maximets@samsung.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190529163958.30796-1-i.maximets@samsung.com>", "X-Brightmail-Tracker": [ "H4sIAAAAAAAAA+NgFvrOIsWRmVeSWpSXmKPExsWy7djP87rPt76LMTi8j93i15sH7BY3Vtlb\n\tvPu0ncniSvtPdou1hz6wW3x6cILFgc3j14KlrB6L97xk8jh2cxq7x/t9V9k8+rasYgxgjeKy\n\tSUnNySxLLdK3S+DK6H8zm6lgOX9F+8E1bA2MX3i6GDk5JARMJJ4v2sLaxcjFISSwglFi/bcj\n\tbBDOF0aJKX+nMUI4nxkl5mx/wALTsmHTVFYQW0hgOaPE/ZM5EEU/GCWe7dnBDpJgE9CROLX6\n\tCCOILSJgLjFxQifYDmaBpYwS29e/YQZJCAsESCxb8wRsKouAqsTmQ0fBpvIKWEus+t/MBLFN\n\tXmL1hgNg9ZwCNhKN7TPA7pMQeM0msWr/LnaIIheJr5f2MUPYwhKvjm+BistInJ7cA3V2vcT9\n\tlpeMEM0djBLTD/2D2mAvseX1OaAGDqDzNCXW79KHCDtK/JuymQkkLCHAJ3HjrSBImBnInLRt\n\tOjNEmFeio00IolpF4vfB5VAXSEncfPcZ6gIPiVdTL0BDsZ9R4sLdN2wTGOVnISxbwMi4ilE8\n\ttbQ4Nz212DgvtVyvODG3uDQvXS85P3cTIzA5nP53/OsOxn1/kg4xCnAwKvHwTsh/FyPEmlhW\n\tXJl7iFGCg1lJhPfncqAQb0piZVVqUX58UWlOavEhRmkOFiVx3mqGB9FCAumJJanZqakFqUUw\n\tWSYOTqkGxkMs70MfNDVvtoxNt0zKn88ZNefzT+tTIjaTL5h2Cbd1XuCauVUhXKSPre9okvSl\n\tW3bG4t+XOy3fO3vmryfrf/RtmN0orPqh1mNOyLxr505L1G7I2mvnNXuRVwLrM6usGwveKf7w\n\t3BKlvrKwM9il1SqVdVmbk+jMDY8vG/wKn+Ckz5Ldc0iUQYmlOCPRUIu5qDgRAO7PMlMKAwAA", "H4sIAAAAAAAAA+NgFrrBLMWRmVeSWpSXmKPExsVy+t/xe7rPtr6LMbj2W8Di15sH7BY3Vtlb\n\tvPu0ncniSvtPdou1hz6wW3x6cILFgc3j14KlrB6L97xk8jh2cxq7x/t9V9k8+rasYgxgjdKz\n\tKcovLUlVyMgvLrFVija0MNIztLTQMzKx1DM0No+1MjJV0rezSUnNySxLLdK3S9DL6H8zm6lg\n\tOX9F+8E1bA2MX3i6GDk5JARMJDZsmsoKYgsJLGWUOLSxCiIuJfHj1wVWCFtY4s+1LrYuRi6g\n\tmm+MEpeuzWQESbAJ6EicWn0EzBYRsJR4dOIjK0gRs8ByRoldR36ygSSEBfwk3h37zwRiswio\n\tSmw+dBRsKq+AtcSq/81MEBvkJVZvOMAMYnMK2Eg0ts9gg7jIWqJhxz7mCYx8CxgZVjGKpJYW\n\t56bnFhvpFSfmFpfmpesl5+duYgSG6rZjP7fsYOx6F3yIUYCDUYmHd0L+uxgh1sSy4srcQ4wS\n\tHMxKIrw/lwOFeFMSK6tSi/Lji0pzUosPMZoCHTWRWUo0OR8YR3kl8YamhuYWlobmxubGZhZK\n\t4rwdAgdjhATSE0tSs1NTC1KLYPqYODilGhib1y89XVejcHL6rPX2zb7RyjGCj6O1434q5U24\n\tmL4rzuxBi+Qq/d6c7e815MW6uWPiLqwKWWgc0WtwR7sqUi35ETefdu7qx+fSd090CJz1qECt\n\t6IRBceiUDc6KL/JSLrjIG9W8S17+59KVBy2vn198Zn59B1uf6UG5pe+3t5qy50kmP2t6UaXE\n\tUpyRaKjFXFScCAC2yzCaawIAAA==" ], "X-CMS-MailID": "20190529164006eucas1p296e902a46cb3ef7ac436d619f9e55d5b", "X-Msg-Generator": "CA", "Content-Type": "text/plain; charset=\"utf-8\"", "X-RootMTR": "20190529164006eucas1p296e902a46cb3ef7ac436d619f9e55d5b", "X-EPHeader": "CA", "CMS-TYPE": "201P", "X-CMS-RootMailID": "20190529164006eucas1p296e902a46cb3ef7ac436d619f9e55d5b", "References": "<20190529163958.30796-1-i.maximets@samsung.com>\n\t<CGME20190529164006eucas1p296e902a46cb3ef7ac436d619f9e55d5b@eucas1p2.samsung.com>", "Subject": "[dpdk-dev] [PATCH 1/2] meson: don't check dependencies for tests if\n\tnot required", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Don't need to check dependencies if test apps will not be built anyway.\n\nSigned-off-by: Ilya Maximets <i.maximets@samsung.com>\n---\n app/test/meson.build | 38 +++++++++++++++++++-------------------\n 1 file changed, 19 insertions(+), 19 deletions(-)", "diff": "diff --git a/app/test/meson.build b/app/test/meson.build\nindex 83391cef0..7a529b644 100644\n--- a/app/test/meson.build\n+++ b/app/test/meson.build\n@@ -313,29 +313,29 @@ endif\n # specify -D_GNU_SOURCE unconditionally\n cflags += '-D_GNU_SOURCE'\n \n-test_dep_objs = []\n-if dpdk_conf.has('RTE_LIBRTE_COMPRESSDEV')\n-\tcompress_test_dep = dependency('zlib', required: false)\n-\tif compress_test_dep.found()\n-\t\ttest_dep_objs += compress_test_dep\n-\t\ttest_sources += 'test_compressdev.c'\n-\t\ttest_deps += 'compressdev'\n-\t\tfast_non_parallel_test_names += 'compressdev_autotest'\n+if get_option('tests')\n+\ttest_dep_objs = []\n+\tif dpdk_conf.has('RTE_LIBRTE_COMPRESSDEV')\n+\t\tcompress_test_dep = dependency('zlib', required: false)\n+\t\tif compress_test_dep.found()\n+\t\t\ttest_dep_objs += compress_test_dep\n+\t\t\ttest_sources += 'test_compressdev.c'\n+\t\t\ttest_deps += 'compressdev'\n+\t\t\tfast_non_parallel_test_names += 'compressdev_autotest'\n+\t\tendif\n \tendif\n-endif\n \n-foreach d:test_deps\n-\tdef_lib = get_option('default_library')\n-\ttest_dep_objs += get_variable(def_lib + '_rte_' + d)\n-endforeach\n-test_dep_objs += cc.find_library('execinfo', required: false)\n+\tforeach d:test_deps\n+\t\tdef_lib = get_option('default_library')\n+\t\ttest_dep_objs += get_variable(def_lib + '_rte_' + d)\n+\tendforeach\n+\ttest_dep_objs += cc.find_library('execinfo', required: false)\n \n-link_libs = []\n-if get_option('default_library') == 'static'\n-\tlink_libs = dpdk_drivers\n-endif\n+\tlink_libs = []\n+\tif get_option('default_library') == 'static'\n+\t\tlink_libs = dpdk_drivers\n+\tendif\n \n-if get_option('tests')\n \tdpdk_test = executable('dpdk-test',\n \t\ttest_sources,\n \t\tlink_whole: link_libs,\n", "prefixes": [ "1/2" ] }{ "id": 53855, "url": "