Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53831/?format=api
{ "id": 53831, "url": "http://patches.dpdk.org/api/patches/53831/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/f0ca9ec8d6dc7300a94102bdf8935849b1584d16.1559147228.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<f0ca9ec8d6dc7300a94102bdf8935849b1584d16.1559147228.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/f0ca9ec8d6dc7300a94102bdf8935849b1584d16.1559147228.git.anatoly.burakov@intel.com", "date": "2019-05-29T16:30:49", "name": "[03/25] net/mlx4: use new memory locking API", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ab0ba41b914b299f0863ccd736c2a3dbc5a5f779", "submitter": { "id": 4, "url": "http://patches.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/f0ca9ec8d6dc7300a94102bdf8935849b1584d16.1559147228.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 4813, "url": "http://patches.dpdk.org/api/series/4813/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4813", "date": "2019-05-29T16:30:46", "name": "Make shared memory config non-public", "version": 1, "mbox": "http://patches.dpdk.org/series/4813/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53831/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/53831/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 79C951B96B;\n\tWed, 29 May 2019 18:31:23 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id 83BE71B952\n\tfor <dev@dpdk.org>; Wed, 29 May 2019 18:31:19 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t29 May 2019 09:31:18 -0700", "from silpixa00399498.ir.intel.com (HELO\n\tsilpixa00399498.ger.corp.intel.com) ([10.237.223.125])\n\tby orsmga005.jf.intel.com with ESMTP; 29 May 2019 09:31:16 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "Matan Azrad <matan@mellanox.com>, Shahaf Shuler <shahafs@mellanox.com>, \n\tstephen@networkplumber.org, thomas@monjalon.net,\n\tdavid.marchand@redhat.com", "Date": "Wed, 29 May 2019 17:30:49 +0100", "Message-Id": "<f0ca9ec8d6dc7300a94102bdf8935849b1584d16.1559147228.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": [ "<cover.1559147228.git.anatoly.burakov@intel.com>", "<cover.1559147228.git.anatoly.burakov@intel.com>" ], "References": [ "<cover.1559147228.git.anatoly.burakov@intel.com>", "<cover.1559147228.git.anatoly.burakov@intel.com>" ], "Subject": "[dpdk-dev] [PATCH 03/25] net/mlx4: use new memory locking API", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Replace usages of direct access to shared memory config with\ncalls to the new API.\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n drivers/net/mlx4/mlx4_mr.c | 11 +++++------\n 1 file changed, 5 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/mlx4/mlx4_mr.c b/drivers/net/mlx4/mlx4_mr.c\nindex 48d458ad4..636d241e3 100644\n--- a/drivers/net/mlx4/mlx4_mr.c\n+++ b/drivers/net/mlx4/mlx4_mr.c\n@@ -593,7 +593,6 @@ mlx4_mr_create_primary(struct rte_eth_dev *dev, struct mlx4_mr_cache *entry,\n \t\t uintptr_t addr)\n {\n \tstruct mlx4_priv *priv = dev->data->dev_private;\n-\tstruct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;\n \tconst struct rte_memseg_list *msl;\n \tconst struct rte_memseg *ms;\n \tstruct mlx4_mr *mr = NULL;\n@@ -696,7 +695,7 @@ mlx4_mr_create_primary(struct rte_eth_dev *dev, struct mlx4_mr_cache *entry,\n \t * just single page. If not, go on with the big chunk atomically from\n \t * here.\n \t */\n-\trte_rwlock_read_lock(&mcfg->memory_hotplug_lock);\n+\trte_eal_mcfg_mem_read_lock();\n \tdata_re = data;\n \tif (len > msl->page_sz &&\n \t !rte_memseg_contig_walk(mr_find_contig_memsegs_cb, &data_re)) {\n@@ -714,7 +713,7 @@ mlx4_mr_create_primary(struct rte_eth_dev *dev, struct mlx4_mr_cache *entry,\n \t\t */\n \t\tdata.start = RTE_ALIGN_FLOOR(addr, msl->page_sz);\n \t\tdata.end = data.start + msl->page_sz;\n-\t\trte_rwlock_read_unlock(&mcfg->memory_hotplug_lock);\n+\t\trte_eal_mcfg_mem_read_unlock();\n \t\tmr_free(mr);\n \t\tgoto alloc_resources;\n \t}\n@@ -734,7 +733,7 @@ mlx4_mr_create_primary(struct rte_eth_dev *dev, struct mlx4_mr_cache *entry,\n \t\tDEBUG(\"port %u found MR for %p on final lookup, abort\",\n \t\t dev->data->port_id, (void *)addr);\n \t\trte_rwlock_write_unlock(&priv->mr.rwlock);\n-\t\trte_rwlock_read_unlock(&mcfg->memory_hotplug_lock);\n+\t\trte_eal_mcfg_mem_read_unlock();\n \t\t/*\n \t\t * Must be unlocked before calling rte_free() because\n \t\t * mlx4_mr_mem_event_free_cb() can be called inside.\n@@ -802,12 +801,12 @@ mlx4_mr_create_primary(struct rte_eth_dev *dev, struct mlx4_mr_cache *entry,\n \t/* Lookup can't fail. */\n \tassert(entry->lkey != UINT32_MAX);\n \trte_rwlock_write_unlock(&priv->mr.rwlock);\n-\trte_rwlock_read_unlock(&mcfg->memory_hotplug_lock);\n+\trte_eal_mcfg_mem_read_unlock();\n \treturn entry->lkey;\n err_mrlock:\n \trte_rwlock_write_unlock(&priv->mr.rwlock);\n err_memlock:\n-\trte_rwlock_read_unlock(&mcfg->memory_hotplug_lock);\n+\trte_eal_mcfg_mem_read_unlock();\n err_nolock:\n \t/*\n \t * In case of error, as this can be called in a datapath, a warning\n", "prefixes": [ "03/25" ] }