Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53829/?format=api
{ "id": 53829, "url": "http://patches.dpdk.org/api/patches/53829/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/6473125811ac8ed499079652b7f3c32907155fc9.1559147228.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<6473125811ac8ed499079652b7f3c32907155fc9.1559147228.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/6473125811ac8ed499079652b7f3c32907155fc9.1559147228.git.anatoly.burakov@intel.com", "date": "2019-05-29T16:30:47", "name": "[01/25] eal: add API to lock/unlock memory hotplug", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ead3d7871287f8241f35c241f059c37f9f7579ca", "submitter": { "id": 4, "url": "http://patches.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/6473125811ac8ed499079652b7f3c32907155fc9.1559147228.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 4813, "url": "http://patches.dpdk.org/api/series/4813/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4813", "date": "2019-05-29T16:30:46", "name": "Make shared memory config non-public", "version": 1, "mbox": "http://patches.dpdk.org/series/4813/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53829/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/53829/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2FF781B94F;\n\tWed, 29 May 2019 18:31:18 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id 357363576\n\tfor <dev@dpdk.org>; Wed, 29 May 2019 18:31:15 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t29 May 2019 09:31:14 -0700", "from silpixa00399498.ir.intel.com (HELO\n\tsilpixa00399498.ger.corp.intel.com) ([10.237.223.125])\n\tby orsmga005.jf.intel.com with ESMTP; 29 May 2019 09:31:13 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "stephen@networkplumber.org, thomas@monjalon.net,\n\tdavid.marchand@redhat.com", "Date": "Wed, 29 May 2019 17:30:47 +0100", "Message-Id": "<6473125811ac8ed499079652b7f3c32907155fc9.1559147228.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": [ "<cover.1559147228.git.anatoly.burakov@intel.com>", "<cover.1559147228.git.anatoly.burakov@intel.com>" ], "References": [ "<cover.1559147228.git.anatoly.burakov@intel.com>", "<cover.1559147228.git.anatoly.burakov@intel.com>" ], "Subject": "[dpdk-dev] [PATCH 01/25] eal: add API to lock/unlock memory hotplug", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently, the memory hotplug is locked automatically by all\nmemory-related _walk() functions, but sometimes locking the\nmemory subsystem outside of them is needed. There is no\npublic API to do that, so it creates a dependency on shared\nmemory config to be public. Fix this by introducing a new\nAPI to lock/unlock the memory hotplug subsystem.\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/librte_eal/common/eal_common_memory.c | 28 +++++++++++++++++++\n .../common/include/rte_eal_memconfig.h | 24 ++++++++++++++++\n lib/librte_eal/rte_eal_version.map | 10 +++++++\n 3 files changed, 62 insertions(+)", "diff": "diff --git a/lib/librte_eal/common/eal_common_memory.c b/lib/librte_eal/common/eal_common_memory.c\nindex 5ae8d0124..3baa2f23a 100644\n--- a/lib/librte_eal/common/eal_common_memory.c\n+++ b/lib/librte_eal/common/eal_common_memory.c\n@@ -682,6 +682,34 @@ rte_memseg_list_walk(rte_memseg_list_walk_t func, void *arg)\n \treturn ret;\n }\n \n+void\n+rte_eal_mcfg_mem_read_lock(void)\n+{\n+\tstruct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;\n+\trte_rwlock_read_lock(&mcfg->memory_hotplug_lock);\n+}\n+\n+void\n+rte_eal_mcfg_mem_read_unlock(void)\n+{\n+\tstruct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;\n+\trte_rwlock_read_unlock(&mcfg->memory_hotplug_lock);\n+}\n+\n+void\n+rte_eal_mcfg_mem_write_lock(void)\n+{\n+\tstruct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;\n+\trte_rwlock_write_lock(&mcfg->memory_hotplug_lock);\n+}\n+\n+void\n+rte_eal_mcfg_mem_write_unlock(void)\n+{\n+\tstruct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;\n+\trte_rwlock_write_unlock(&mcfg->memory_hotplug_lock);\n+}\n+\n int __rte_experimental\n rte_memseg_get_fd_thread_unsafe(const struct rte_memseg *ms)\n {\ndiff --git a/lib/librte_eal/common/include/rte_eal_memconfig.h b/lib/librte_eal/common/include/rte_eal_memconfig.h\nindex 84aabe36c..ef7d4f81a 100644\n--- a/lib/librte_eal/common/include/rte_eal_memconfig.h\n+++ b/lib/librte_eal/common/include/rte_eal_memconfig.h\n@@ -100,6 +100,30 @@ rte_eal_mcfg_wait_complete(struct rte_mem_config* mcfg)\n \t\trte_pause();\n }\n \n+/**\n+ * Lock the internal EAL shared memory configuration for shared access.\n+ */\n+void\n+rte_eal_mcfg_mem_read_lock(void);\n+\n+/**\n+ * Unlock the internal EAL shared memory configuration for shared access.\n+ */\n+void\n+rte_eal_mcfg_mem_read_unlock(void);\n+\n+/**\n+ * Lock the internal EAL shared memory configuration for exclusive access.\n+ */\n+void\n+rte_eal_mcfg_mem_write_lock(void);\n+\n+/**\n+ * Unlock the internal EAL shared memory configuration for exclusive access.\n+ */\n+void\n+rte_eal_mcfg_mem_write_unlock(void);\n+\n #ifdef __cplusplus\n }\n #endif\ndiff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map\nindex 245493461..690176fbf 100644\n--- a/lib/librte_eal/rte_eal_version.map\n+++ b/lib/librte_eal/rte_eal_version.map\n@@ -287,6 +287,16 @@ DPDK_19.05 {\n \n } DPDK_18.11;\n \n+DPDK_19.08 {\n+\tglobal:\n+\n+\trte_eal_mcfg_mem_read_lock;\n+\trte_eal_mcfg_mem_read_unlock;\n+\trte_eal_mcfg_mem_write_lock;\n+\trte_eal_mcfg_mem_write_unlock;\n+\n+} DPDK_19.05;\n+\n EXPERIMENTAL {\n \tglobal:\n \n", "prefixes": [ "01/25" ] }