Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53823/?format=api
{ "id": 53823, "url": "http://patches.dpdk.org/api/patches/53823/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190529154132.49955-2-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190529154132.49955-2-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190529154132.49955-2-bruce.richardson@intel.com", "date": "2019-05-29T15:41:29", "name": "[1/4] build: fix quoting on RTE_ARCH string value", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "4a7b0e9d85783ea6bd835b9ab082f222bbac0cb6", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190529154132.49955-2-bruce.richardson@intel.com/mbox/", "series": [ { "id": 4811, "url": "http://patches.dpdk.org/api/series/4811/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4811", "date": "2019-05-29T15:41:28", "name": "Enhance CPU flag support", "version": 1, "mbox": "http://patches.dpdk.org/series/4811/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53823/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/53823/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 139321B9A0;\n\tWed, 29 May 2019 17:41:45 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby dpdk.org (Postfix) with ESMTP id 3D8F91B99C;\n\tWed, 29 May 2019 17:41:43 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t29 May 2019 08:41:41 -0700", "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.223.2])\n\tby FMSMGA003.fm.intel.com with ESMTP; 29 May 2019 08:41:41 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>, bluca@debian.org,\n\tstable@dpdk.org", "Date": "Wed, 29 May 2019 16:41:29 +0100", "Message-Id": "<20190529154132.49955-2-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190529154132.49955-1-bruce.richardson@intel.com>", "References": "<20190529154132.49955-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 1/4] build: fix quoting on RTE_ARCH string value", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The value for RTE_ARCH needs to be quoted when output to the\nrte_build_config.h file, so use \"set_quoted\" rather than \"set\" when\nassigning it.\n\nFixes: a25a650be5f0 (\"build: add infrastructure for meson and ninja builds\")\nFixes: 54d609a13876 (\"build: add ppc64 meson build\")\nCc: bluca@debian.org\nCc: stable@dpdk.org\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n config/ppc_64/meson.build | 2 +-\n config/x86/meson.build | 4 ++--\n 2 files changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/config/ppc_64/meson.build b/config/ppc_64/meson.build\nindex 7ceae1d39..9246d319c 100644\n--- a/config/ppc_64/meson.build\n+++ b/config/ppc_64/meson.build\n@@ -4,7 +4,7 @@\n if not dpdk_conf.get('RTE_ARCH_64')\n \terror('Only 64-bit compiles are supported for this platform type')\n endif\n-dpdk_conf.set('RTE_ARCH', 'ppc_64')\n+dpdk_conf.set_quoted('RTE_ARCH', 'ppc_64')\n dpdk_conf.set('RTE_ARCH_PPC_64', 1)\n \n # overrides specific to ppc64\ndiff --git a/config/x86/meson.build b/config/x86/meson.build\nindex bb23771b4..1a88e52d9 100644\n--- a/config/x86/meson.build\n+++ b/config/x86/meson.build\n@@ -31,10 +31,10 @@ endforeach\n dpdk_conf.set('RTE_ARCH_X86', 1)\n if dpdk_conf.get('RTE_ARCH_64')\n \tdpdk_conf.set('RTE_ARCH_X86_64', 1)\n-\tdpdk_conf.set('RTE_ARCH', 'x86_64')\n+\tdpdk_conf.set_quoted('RTE_ARCH', 'x86_64')\n else\n \tdpdk_conf.set('RTE_ARCH_I686', 1)\n-\tdpdk_conf.set('RTE_ARCH', 'i686')\n+\tdpdk_conf.set_quoted('RTE_ARCH', 'i686')\n endif\n \n if cc.get_define('__AES__', args: machine_args) != ''\n", "prefixes": [ "1/4" ] }