Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53733/?format=api
{ "id": 53733, "url": "http://patches.dpdk.org/api/patches/53733/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1559042301-73445-2-git-send-email-motih@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1559042301-73445-2-git-send-email-motih@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1559042301-73445-2-git-send-email-motih@mellanox.com", "date": "2019-05-28T11:18:45", "name": "[1/2] net/mlx5: fix testpmd crash on null-flow drv opts", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ba047fd1330e781adffcd0a8302cfcb38fb136b4", "submitter": { "id": 748, "url": "http://patches.dpdk.org/api/people/748/?format=api", "name": "Moti Haimovsky", "email": "motih@mellanox.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1559042301-73445-2-git-send-email-motih@mellanox.com/mbox/", "series": [ { "id": 4793, "url": "http://patches.dpdk.org/api/series/4793/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4793", "date": "2019-05-28T11:18:44", "name": "net/mlx5: remove TCF support from PMD", "version": 1, "mbox": "http://patches.dpdk.org/series/4793/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53733/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/53733/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 01B301B949;\n\tTue, 28 May 2019 13:18:50 +0200 (CEST)", "from EUR04-VI1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr80089.outbound.protection.outlook.com [40.107.8.89])\n\tby dpdk.org (Postfix) with ESMTP id BD42D137D;\n\tTue, 28 May 2019 13:18:46 +0200 (CEST)", "from AM0PR05MB4435.eurprd05.prod.outlook.com (52.134.95.151) by\n\tAM0PR05MB5633.eurprd05.prod.outlook.com (20.178.115.210) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1922.20; Tue, 28 May 2019 11:18:45 +0000", "from AM0PR05MB4435.eurprd05.prod.outlook.com\n\t([fe80::c40a:d6fe:1246:7278]) by\n\tAM0PR05MB4435.eurprd05.prod.outlook.com\n\t([fe80::c40a:d6fe:1246:7278%4]) with mapi id 15.20.1922.021;\n\tTue, 28 May 2019 11:18:45 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector2;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=jNQYdlJOwAAmjjLwhUSMDiWzG1uDiEUqDFJTFnVdrPM=;\n\tb=jDCRYJFZsoo2EuXDJ5Qe0UMX2/Galr/4gKMNINBN3uENBAKeguqXhDBja/Zqf/34uHOvG2OuFXk8Tz0J8xhGCl0bJ2FrmdLcHqtM7eahlRwkd0LWZxzOkcFHvdf75/PxF4EN8EQjO4N+46u+PDkEO3M0UpX79gcXQwFVy69z1i8=", "From": "Moti Haimovsky <motih@mellanox.com>", "To": "Shahaf Shuler <shahafs@mellanox.com>", "CC": "\"dev@dpdk.org\" <dev@dpdk.org>, Moti Haimovsky <motih@mellanox.com>,\n\t\"stable@dpdk.org\" <stable@dpdk.org>", "Thread-Topic": "[PATCH 1/2] net/mlx5: fix testpmd crash on null-flow drv opts", "Thread-Index": "AQHVFUcdCM97Lgqwj0+oXUdRUvst0A==", "Date": "Tue, 28 May 2019 11:18:45 +0000", "Message-ID": "<1559042301-73445-2-git-send-email-motih@mellanox.com>", "References": "<1559042301-73445-1-git-send-email-motih@mellanox.com>", "In-Reply-To": "<1559042301-73445-1-git-send-email-motih@mellanox.com>", "Accept-Language": "he-IL, en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-clientproxiedby": "LO2P265CA0318.GBRP265.PROD.OUTLOOK.COM\n\t(2603:10a6:600:a4::18) To AM0PR05MB4435.eurprd05.prod.outlook.com\n\t(2603:10a6:208:61::23)", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=motih@mellanox.com; ", "x-ms-exchange-messagesentrepresentingtype": "1", "x-mailer": "git-send-email 1.8.3.1", "x-originating-ip": "[37.142.13.130]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "3742a8b9-e71e-4553-df90-08d6e35e3fbc", "x-ms-office365-filtering-ht": "Tenant", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);\n\tSRVR:AM0PR05MB5633; ", "x-ms-traffictypediagnostic": "AM0PR05MB5633:", "x-microsoft-antispam-prvs": "<AM0PR05MB5633CB4BA61069BD4E9D5128D21E0@AM0PR05MB5633.eurprd05.prod.outlook.com>", "x-ms-oob-tlc-oobclassifiers": "OLM:612;", "x-forefront-prvs": "00514A2FE6", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(366004)(376002)(346002)(396003)(39860400002)(136003)(199004)(189003)(8676002)(186003)(8936002)(37006003)(26005)(81166006)(81156014)(5660300002)(3846002)(6116002)(450100002)(54906003)(50226002)(4326008)(36756003)(305945005)(6436002)(478600001)(53936002)(86362001)(14454004)(6862004)(25786009)(6512007)(6486002)(486006)(316002)(2616005)(476003)(2906002)(71200400001)(256004)(4720700003)(6636002)(386003)(52116002)(76176011)(68736007)(102836004)(99286004)(6506007)(66476007)(73956011)(66946007)(7736002)(66556008)(64756008)(66446008)(66066001)(11346002)(446003)(71190400001);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR05MB5633;\n\tH:AM0PR05MB4435.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; A:1; MX:1; ", "received-spf": "None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "qgV6hccUuf0L+FQJ/TuaNcAoL+Ta6g6cpwWdTAyce3av6F/cCwDu9ucz5ZcbJ70s3lOqazF/ePCBB9d4QSFTSq+Ob7T6wGfqTnTX8y+z5FamWomKrLKdLOGP0oivBlSH640Zhs9vqmP2kupbU3VUuEToS497OGvm+y/lvabf1i98w772ijoKPkNJcxqWgUJJxze4ZE+q+N7tQND0/z7oZnhlwX+1HrnoPm5Uhrd1BwPyo4fTnAP0mJ8QkbKdF9Gauax3nKgG6zybsZEuep6vcFEi3OgyON0aGXRlGD32UVKCeluf0OlMgIOujpGCcVN5UKTIJmCKuRhPFItd+L9uI8FA6tBOFgkrkYB5ZYs0l6JshiNVTn/VMBgQ0bO+/x7vkiWPcbh4qyPVL4erj1dBfgCtzQPjEqtslELl0iGg554=", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "MIME-Version": "1.0", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "3742a8b9-e71e-4553-df90-08d6e35e3fbc", "X-MS-Exchange-CrossTenant-originalarrivaltime": "28 May 2019 11:18:45.8085\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "motih@mellanox.com", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM0PR05MB5633", "Subject": "[dpdk-dev] [PATCH 1/2] net/mlx5: fix testpmd crash on null-flow drv\n\topts", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "mlx5 implements mlx5_flow_null_drv_ops to be used when a specific\nflow typei/driver is not available or invalid.\nThis routines return error without modifying the rte_flow_error\nparameter passed to them which causes testpmd, for example, to crash.\nThis commit addresses the issue by modifying the rte_flow_error\nparameter in theses routines.\n\nFixes: 0c76d1c9a18d (\"net/mlx5: add abstraction for multiple flow drivers\")\nFixes: 684dafe795d0 (\"net/mlx5: add flow query abstraction interface\")\nCc: stable@dpdk.org\n\nSigned-off-by: Moti Haimovsky <motih@mellanox.com>\n---\n drivers/net/mlx5/mlx5_flow.c | 29 +++++++++++++++--------------\n 1 file changed, 15 insertions(+), 14 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c\r\nindex 9887018..e5a8e33 100644\r\n--- a/drivers/net/mlx5/mlx5_flow.c\r\n+++ b/drivers/net/mlx5/mlx5_flow.c\r\n@@ -1694,19 +1694,20 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev *dev, int32_t priority,\r\n \t\t const struct rte_flow_attr *attr __rte_unused,\r\n \t\t const struct rte_flow_item items[] __rte_unused,\r\n \t\t const struct rte_flow_action actions[] __rte_unused,\r\n-\t\t struct rte_flow_error *error __rte_unused)\r\n+\t\t struct rte_flow_error *error)\r\n {\r\n-\trte_errno = ENOTSUP;\r\n-\treturn -rte_errno;\r\n+\treturn rte_flow_error_set(error, ENOTSUP,\r\n+\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, NULL);\r\n }\r\n \r\n static struct mlx5_flow *\r\n flow_null_prepare(const struct rte_flow_attr *attr __rte_unused,\r\n \t\t const struct rte_flow_item items[] __rte_unused,\r\n \t\t const struct rte_flow_action actions[] __rte_unused,\r\n-\t\t struct rte_flow_error *error __rte_unused)\r\n+\t\t struct rte_flow_error *error)\r\n {\r\n-\trte_errno = ENOTSUP;\r\n+\trte_flow_error_set(error, ENOTSUP,\r\n+\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, NULL);\r\n \treturn NULL;\r\n }\r\n \r\n@@ -1716,19 +1717,19 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev *dev, int32_t priority,\r\n \t\t const struct rte_flow_attr *attr __rte_unused,\r\n \t\t const struct rte_flow_item items[] __rte_unused,\r\n \t\t const struct rte_flow_action actions[] __rte_unused,\r\n-\t\t struct rte_flow_error *error __rte_unused)\r\n+\t\t struct rte_flow_error *error)\r\n {\r\n-\trte_errno = ENOTSUP;\r\n-\treturn -rte_errno;\r\n+\treturn rte_flow_error_set(error, ENOTSUP,\r\n+\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, NULL);\r\n }\r\n \r\n static int\r\n flow_null_apply(struct rte_eth_dev *dev __rte_unused,\r\n \t\tstruct rte_flow *flow __rte_unused,\r\n-\t\tstruct rte_flow_error *error __rte_unused)\r\n+\t\tstruct rte_flow_error *error)\r\n {\r\n-\trte_errno = ENOTSUP;\r\n-\treturn -rte_errno;\r\n+\treturn rte_flow_error_set(error, ENOTSUP,\r\n+\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, NULL);\r\n }\r\n \r\n static void\r\n@@ -1748,10 +1749,10 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev *dev, int32_t priority,\r\n \t\tstruct rte_flow *flow __rte_unused,\r\n \t\tconst struct rte_flow_action *actions __rte_unused,\r\n \t\tvoid *data __rte_unused,\r\n-\t\tstruct rte_flow_error *error __rte_unused)\r\n+\t\tstruct rte_flow_error *error)\r\n {\r\n-\trte_errno = ENOTSUP;\r\n-\treturn -rte_errno;\r\n+\treturn rte_flow_error_set(error, ENOTSUP,\r\n+\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, NULL);\r\n }\r\n \r\n /* Void driver to protect from null pointer reference. */\r\n", "prefixes": [ "1/2" ] }