Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53731/?format=api
http://patches.dpdk.org/api/patches/53731/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190528110748.10772-6-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190528110748.10772-6-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190528110748.10772-6-bruce.richardson@intel.com", "date": "2019-05-28T11:07:48", "name": "[v2,5/5] build: add libatomic dependency for 32-bit clang compile", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f85aa4c8d1b678af4511a5787c44981182b84f20", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190528110748.10772-6-bruce.richardson@intel.com/mbox/", "series": [ { "id": 4792, "url": "http://patches.dpdk.org/api/series/4792/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4792", "date": "2019-05-28T11:07:43", "name": "fix 32-bit meson builds", "version": 2, "mbox": "http://patches.dpdk.org/series/4792/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53731/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/53731/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7C3C61B998;\n\tTue, 28 May 2019 13:08:19 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby dpdk.org (Postfix) with ESMTP id D0DB91B94E;\n\tTue, 28 May 2019 13:08:15 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t28 May 2019 04:08:15 -0700", "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.223.2])\n\tby orsmga007.jf.intel.com with ESMTP; 28 May 2019 04:08:13 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Shreyansh Jain <shreyansh.jain@nxp.com>,\n\tAlejandro Lucero <alejandro.lucero@netronome.com>,\n\tAnatoly Burakov <anatoly.burakov@intel.com>, stable@dpdk.org,\n\tMaxime Coquelin <maxime.coquelin@redhat.com>,\n\tZhihong Wang <zhihong.wang@intel.com>, Luca Boccassi <bluca@debian.org>, \n\tZhang XuemingX <xuemingx.zhang@intel.com>,\n\tBruce Richardson <bruce.richardson@intel.com>", "Date": "Tue, 28 May 2019 12:07:48 +0100", "Message-Id": "<20190528110748.10772-6-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190528110748.10772-1-bruce.richardson@intel.com>", "References": "<20190527161509.50252-1-bruce.richardson@intel.com>\n\t<20190528110748.10772-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 5/5] build: add libatomic dependency for\n\t32-bit clang compile", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When compiling with clang on 32-bit platforms, we are missing copies\nof 64-bit atomic functions. We can solve this by linking against\nlibatomic for the drivers and libs which need those atomic ops.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/event/octeontx/meson.build | 5 +++++\n drivers/event/opdl/meson.build | 5 +++++\n lib/librte_rcu/meson.build | 5 +++++\n 3 files changed, 15 insertions(+)", "diff": "diff --git a/drivers/event/octeontx/meson.build b/drivers/event/octeontx/meson.build\nindex 2b74bb6..3f83be6 100644\n--- a/drivers/event/octeontx/meson.build\n+++ b/drivers/event/octeontx/meson.build\n@@ -11,3 +11,8 @@ sources = files('ssovf_worker.c',\n )\n \n deps += ['common_octeontx', 'mempool_octeontx', 'bus_vdev', 'pmd_octeontx']\n+\n+# for clang 32-bit compiles we need libatomic for 64-bit atomic ops\n+if cc.get_id() == 'clang' and dpdk_conf.get('RTE_ARCH_64') == false\n+\text_deps += cc.find_library('atomic')\n+endif\ndiff --git a/drivers/event/opdl/meson.build b/drivers/event/opdl/meson.build\nindex cc6029c..e1cfb2d 100644\n--- a/drivers/event/opdl/meson.build\n+++ b/drivers/event/opdl/meson.build\n@@ -9,3 +9,8 @@ sources = files(\n \t'opdl_test.c',\n )\n deps += ['bus_vdev']\n+\n+# for clang 32-bit compiles we need libatomic for 64-bit atomic ops\n+if cc.get_id() == 'clang' and dpdk_conf.get('RTE_ARCH_64') == false\n+\text_deps += cc.find_library('atomic')\n+endif\ndiff --git a/lib/librte_rcu/meson.build b/lib/librte_rcu/meson.build\nindex 0c2d5a2..43edb87 100644\n--- a/lib/librte_rcu/meson.build\n+++ b/lib/librte_rcu/meson.build\n@@ -5,3 +5,8 @@ allow_experimental_apis = true\n \n sources = files('rte_rcu_qsbr.c')\n headers = files('rte_rcu_qsbr.h')\n+\n+# for clang 32-bit compiles we need libatomic for 64-bit atomic ops\n+if cc.get_id() == 'clang' and dpdk_conf.get('RTE_ARCH_64') == false\n+\text_deps += cc.find_library('atomic')\n+endif\n", "prefixes": [ "v2", "5/5" ] }{ "id": 53731, "url": "