Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53728/?format=api
{ "id": 53728, "url": "http://patches.dpdk.org/api/patches/53728/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190528110748.10772-3-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190528110748.10772-3-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190528110748.10772-3-bruce.richardson@intel.com", "date": "2019-05-28T11:07:45", "name": "[v2,2/5] build: enable large file support on 32-bit", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b4a33ddec1046714035b0eb1a3179d439fe08de9", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190528110748.10772-3-bruce.richardson@intel.com/mbox/", "series": [ { "id": 4792, "url": "http://patches.dpdk.org/api/series/4792/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4792", "date": "2019-05-28T11:07:43", "name": "fix 32-bit meson builds", "version": 2, "mbox": "http://patches.dpdk.org/series/4792/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53728/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/53728/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5DC101B952;\n\tTue, 28 May 2019 13:08:12 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby dpdk.org (Postfix) with ESMTP id 0BEB64C8B;\n\tTue, 28 May 2019 13:08:06 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t28 May 2019 04:08:06 -0700", "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.223.2])\n\tby orsmga007.jf.intel.com with ESMTP; 28 May 2019 04:08:04 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Shreyansh Jain <shreyansh.jain@nxp.com>,\n\tAlejandro Lucero <alejandro.lucero@netronome.com>,\n\tAnatoly Burakov <anatoly.burakov@intel.com>, stable@dpdk.org,\n\tMaxime Coquelin <maxime.coquelin@redhat.com>,\n\tZhihong Wang <zhihong.wang@intel.com>, Luca Boccassi <bluca@debian.org>, \n\tZhang XuemingX <xuemingx.zhang@intel.com>,\n\tBruce Richardson <bruce.richardson@intel.com>", "Date": "Tue, 28 May 2019 12:07:45 +0100", "Message-Id": "<20190528110748.10772-3-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190528110748.10772-1-bruce.richardson@intel.com>", "References": "<20190527161509.50252-1-bruce.richardson@intel.com>\n\t<20190528110748.10772-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 2/5] build: enable large file support on 32-bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "By default on 32-bit systems, file offsets are given as 32-bit values\nwhich prevents support for large files. While this is unlikely to be\na problem, enabling large file support globally makes \"make\" and\n\"meson\" builds consistent, since meson always enables large file\nsupport, and without this change, the size of \"struct stat\" fields\nwill be different between the two builds.\n\nThe only location where this appears to be significant is in the\ndpaax common code, where a printf needs to be updated for 32-bit\nbuilds.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nAcked-by: Luca Boccassi <bluca@debian.org>\n---\n drivers/common/dpaax/dpaax_iova_table.c | 4 ++--\n mk/arch/arm/rte.vars.mk | 2 +-\n mk/arch/i686/rte.vars.mk | 2 +-\n 3 files changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/common/dpaax/dpaax_iova_table.c b/drivers/common/dpaax/dpaax_iova_table.c\nindex 2dd38a9..ae0af09 100644\n--- a/drivers/common/dpaax/dpaax_iova_table.c\n+++ b/drivers/common/dpaax/dpaax_iova_table.c\n@@ -99,7 +99,7 @@ read_memory_node(unsigned int *count)\n \t\tgoto cleanup;\n \t}\n \n-\tDPAAX_DEBUG(\"Size of device-tree mem node: %lu\", statbuf.st_size);\n+\tDPAAX_DEBUG(\"Size of device-tree mem node: %\" PRIu64, statbuf.st_size);\n \tif (statbuf.st_size > MEM_NODE_FILE_LEN) {\n \t\tDPAAX_DEBUG(\"More memory nodes available than assumed.\");\n \t\tDPAAX_DEBUG(\"System may not work properly!\");\n@@ -118,7 +118,7 @@ read_memory_node(unsigned int *count)\n \t */\n \t*count = (statbuf.st_size / 16);\n \tif ((*count) <= 0 || (statbuf.st_size % 16 != 0)) {\n-\t\tDPAAX_DEBUG(\"Invalid memory node values or count. (size=%lu)\",\n+\t\tDPAAX_DEBUG(\"Invalid memory node values or count. (size=%\" PRIu64 \")\",\n \t\t\t statbuf.st_size);\n \t\tgoto cleanup;\n \t}\ndiff --git a/mk/arch/arm/rte.vars.mk b/mk/arch/arm/rte.vars.mk\nindex 27b1147..dc8c10a 100644\n--- a/mk/arch/arm/rte.vars.mk\n+++ b/mk/arch/arm/rte.vars.mk\n@@ -4,7 +4,7 @@\n ARCH ?= arm\n CROSS ?=\n \n-CPU_CFLAGS ?= -marm -munaligned-access\n+CPU_CFLAGS ?= -marm -munaligned-access -D_FILE_OFFSET_BITS=64\n CPU_LDFLAGS ?=\n CPU_ASFLAGS ?= -felf\n \ndiff --git a/mk/arch/i686/rte.vars.mk b/mk/arch/i686/rte.vars.mk\nindex 3f48f67..c867883 100644\n--- a/mk/arch/i686/rte.vars.mk\n+++ b/mk/arch/i686/rte.vars.mk\n@@ -24,7 +24,7 @@ ARCH ?= i386\n ARCH_DIR := x86\n CROSS ?=\n \n-CPU_CFLAGS ?= -m32\n+CPU_CFLAGS ?= -m32 -D_FILE_OFFSET_BITS=64\n CPU_LDFLAGS ?= -melf_i386\n CPU_ASFLAGS ?= -felf\n \n", "prefixes": [ "v2", "2/5" ] }