Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53713/?format=api
{ "id": 53713, "url": "http://patches.dpdk.org/api/patches/53713/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190527161509.50252-4-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190527161509.50252-4-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190527161509.50252-4-bruce.richardson@intel.com", "date": "2019-05-27T16:15:09", "name": "[3/3] build: remove unnecessary large file support defines", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ab996ccf8b09d141fb278f0abfa161ab5a51bc6d", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190527161509.50252-4-bruce.richardson@intel.com/mbox/", "series": [ { "id": 4783, "url": "http://patches.dpdk.org/api/series/4783/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4783", "date": "2019-05-27T16:15:06", "name": "fix 32-bit meson builds", "version": 1, "mbox": "http://patches.dpdk.org/series/4783/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53713/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/53713/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BFFCF1B955;\n\tMon, 27 May 2019 18:15:48 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id 5FDBD1B952;\n\tMon, 27 May 2019 18:15:47 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t27 May 2019 09:15:46 -0700", "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.223.2])\n\tby fmsmga004.fm.intel.com with ESMTP; 27 May 2019 09:15:44 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Shreyansh Jain <shreyansh.jain@nxp.com>,\n\tAlejandro Lucero <alejandro.lucero@netronome.com>,\n\tAnatoly Burakov <anatoly.burakov@intel.com>, stable@dpdk.org,\n\tMaxime Coquelin <maxime.coquelin@redhat.com>,\n\tZhihong Wang <zhihong.wang@intel.com>, Luca Boccassi <bluca@debian.org>, \n\tZhang XuemingX <xuemingx.zhang@intel.com>,\n\tBruce Richardson <bruce.richardson@intel.com>", "Date": "Mon, 27 May 2019 17:15:09 +0100", "Message-Id": "<20190527161509.50252-4-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190527161509.50252-1-bruce.richardson@intel.com>", "References": "<20190527161509.50252-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 3/3] build: remove unnecessary large file support\n\tdefines", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Since we now always use _FILE_OFFSET_BITS=64 flag when building\nDPDK, we can remove the Makefile and C-file #defines setting it\nindividually for parts of the build.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n examples/vhost_crypto/meson.build | 1 -\n examples/vhost_scsi/meson.build | 1 -\n lib/librte_eal/linux/eal/eal_memalloc.c | 1 -\n lib/librte_eal/linux/eal/eal_memory.c | 1 -\n lib/librte_vhost/Makefile | 2 +-\n 5 files changed, 1 insertion(+), 5 deletions(-)", "diff": "diff --git a/examples/vhost_crypto/meson.build b/examples/vhost_crypto/meson.build\nindex 8e9860f03..2485f3bd1 100644\n--- a/examples/vhost_crypto/meson.build\n+++ b/examples/vhost_crypto/meson.build\n@@ -9,7 +9,6 @@\n build = dpdk_conf.has('RTE_LIBRTE_VHOST')\n allow_experimental_apis = true\n deps += ['vhost', 'cryptodev']\n-cflags += ['-D_FILE_OFFSET_BITS=64']\n sources = files(\n \t'main.c'\n )\ndiff --git a/examples/vhost_scsi/meson.build b/examples/vhost_scsi/meson.build\nindex 2972e4d61..77e5201bd 100644\n--- a/examples/vhost_scsi/meson.build\n+++ b/examples/vhost_scsi/meson.build\n@@ -15,7 +15,6 @@ if not cc.has_header('linux/virtio_scsi.h')\n endif\n \n deps += 'vhost'\n-cflags += ['-D_FILE_OFFSET_BITS=64']\n sources = files(\n \t'scsi.c', 'vhost_scsi.c'\n )\ndiff --git a/lib/librte_eal/linux/eal/eal_memalloc.c b/lib/librte_eal/linux/eal/eal_memalloc.c\nindex 1e9ebb86d..b1849a28a 100644\n--- a/lib/librte_eal/linux/eal/eal_memalloc.c\n+++ b/lib/librte_eal/linux/eal/eal_memalloc.c\n@@ -2,7 +2,6 @@\n * Copyright(c) 2017-2018 Intel Corporation\n */\n \n-#define _FILE_OFFSET_BITS 64\n #include <errno.h>\n #include <stdarg.h>\n #include <stdbool.h>\ndiff --git a/lib/librte_eal/linux/eal/eal_memory.c b/lib/librte_eal/linux/eal/eal_memory.c\nindex 416dad898..40a0f687a 100644\n--- a/lib/librte_eal/linux/eal/eal_memory.c\n+++ b/lib/librte_eal/linux/eal/eal_memory.c\n@@ -3,7 +3,6 @@\n * Copyright(c) 2013 6WIND S.A.\n */\n \n-#define _FILE_OFFSET_BITS 64\n #include <errno.h>\n #include <fcntl.h>\n #include <stdarg.h>\ndiff --git a/lib/librte_vhost/Makefile b/lib/librte_vhost/Makefile\nindex 5dd318987..8623e91c0 100644\n--- a/lib/librte_vhost/Makefile\n+++ b/lib/librte_vhost/Makefile\n@@ -11,7 +11,7 @@ EXPORT_MAP := rte_vhost_version.map\n LIBABIVER := 4\n \n CFLAGS += -DALLOW_EXPERIMENTAL_API\n-CFLAGS += $(WERROR_FLAGS) -I$(SRCDIR) -O3 -D_FILE_OFFSET_BITS=64\n+CFLAGS += $(WERROR_FLAGS) -I$(SRCDIR) -O3\n CFLAGS += -I vhost_user\n CFLAGS += -fno-strict-aliasing\n LDLIBS += -lpthread\n", "prefixes": [ "3/3" ] }