Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 53686,
    "url": "http://patches.dpdk.org/api/patches/53686/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190524144935.18765-7-lance.richardson@broadcom.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190524144935.18765-7-lance.richardson@broadcom.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190524144935.18765-7-lance.richardson@broadcom.com",
    "date": "2019-05-24T14:49:31",
    "name": "[v2,06/10] net/bnxt: fix reta query op",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "9cff9892c9ec41603ef00438854429e4c255fbaf",
    "submitter": {
        "id": 1323,
        "url": "http://patches.dpdk.org/api/people/1323/?format=api",
        "name": "Lance Richardson",
        "email": "lance.richardson@broadcom.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190524144935.18765-7-lance.richardson@broadcom.com/mbox/",
    "series": [
        {
            "id": 4767,
            "url": "http://patches.dpdk.org/api/series/4767/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4767",
            "date": "2019-05-24T14:49:25",
            "name": "bnxt patchset",
            "version": 2,
            "mbox": "http://patches.dpdk.org/series/4767/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/53686/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/53686/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D8CF01B996;\n\tFri, 24 May 2019 16:50:24 +0200 (CEST)",
            "from mail-pl1-f194.google.com (mail-pl1-f194.google.com\n\t[209.85.214.194]) by dpdk.org (Postfix) with ESMTP id 5DCF71B951\n\tfor <dev@dpdk.org>; Fri, 24 May 2019 16:50:12 +0200 (CEST)",
            "by mail-pl1-f194.google.com with SMTP id f97so4281278plb.5\n\tfor <dev@dpdk.org>; Fri, 24 May 2019 07:50:12 -0700 (PDT)",
            "from localhost.localdomain ([192.19.231.250])\n\tby smtp.gmail.com with ESMTPSA id\n\tx23sm2723705pfn.160.2019.05.24.07.50.09\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 24 May 2019 07:50:10 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=o/WkUVY2zE6MWdpaxuDke01F8QkmuMiegWL+O/xJf90=;\n\tb=Ann6Sq37Ek/XZTVe7BcCZZJbs+v+y6ridbegMRlPGox+Wmz7QHKSalG2DpGo+BTIcs\n\tXcmIMrh5l5EKsXOcY+202MyetRohIW+UunFkp3rR/SJxjF+kpMegYQ1WO0Jqfu7YkKRw\n\tIPEHgognGLclma6r+OtZEX0oN0SIZrNnWUs5U=",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=o/WkUVY2zE6MWdpaxuDke01F8QkmuMiegWL+O/xJf90=;\n\tb=F4ukheGKopQF10JzvyUOpx9sCTMiF9Q1Fuxl67k4qCuQ8xhEqHRIZwLQcCyMu/DpRO\n\tySmA2Ih/qtPlu0Pav/ZIp4/UlqYIW1ZMq+pvh6qKcBT8obE8uOLOtv93JsGxKC1rPk2y\n\tfQM5NVgFvrhvpgmWoLZ1PKbVpB+ewzFxMCPXRTUGB8Fy/Ea8cGRQaXzhspBrzbNS5T1M\n\tkkKhuxqDFuHXbgx8yiolM1F5xFrQamip0Tept+qxvmi/HCzMufttRH+v9AUSpk/OBGDN\n\tnW7ZSwpJd1TgtqepGlicV4703uMEcZAJcudZMRclUXnkiXgD5vCQ+6QKr6pbjeRG/IRQ\n\tWewQ==",
        "X-Gm-Message-State": "APjAAAVVkNu9xi1MwG0gGDxhebhZ6BuVoS4Qp/vkhvDP63haztbuN9QU\n\tqoEOoDFrXPSTwgS3jmbrZcggCvedIlOFvxXKXr9p/qutaulwCVo2LqNM2mTeWjS+kIo3p7RoNma\n\tl6pqRGnWAklHeIcBosGQ+vo5X860n/kFc8LDFAQbDQZYPozmm3vgq+RaqLAc/hU78",
        "X-Google-Smtp-Source": "APXvYqx3ROk02FMDr88maXNYNywLL/fqk7/ErqMlK7TRDRkPXoK7SN51kVKdHdKe+X6FCpIwmYpF/w==",
        "X-Received": "by 2002:a17:902:158b:: with SMTP id\n\tm11mr65768024pla.268.1558709411354; \n\tFri, 24 May 2019 07:50:11 -0700 (PDT)",
        "From": "Lance Richardson <lance.richardson@broadcom.com>",
        "To": "dev@dpdk.org",
        "Cc": "ajit.khaparde@broadcom.com, ferruh.yigit@intel.com,\n\tmaxime.coquelin@redhat.com,\n\tLance Richardson <lance.richardson@broadcom.com>",
        "Date": "Fri, 24 May 2019 10:49:31 -0400",
        "Message-Id": "<20190524144935.18765-7-lance.richardson@broadcom.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "In-Reply-To": "<20190524144935.18765-1-lance.richardson@broadcom.com>",
        "References": "<20190521213953.25425-1-ajit.khaparde@broadcom.com>\n\t<20190524144935.18765-1-lance.richardson@broadcom.com>",
        "Subject": "[dpdk-dev] [PATCH v2 06/10] net/bnxt: fix reta query op",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Fix reta query op to only return table entries as identfied by the\nprovided mask. Translate firmware group IDs to queue numbers.\n\nRemoved extraneous code from bnxt_reta_query_op().\n\nFixes: d819382543f3 (\"net/bnxt: add RSS redirection table operations\")\nSigned-off-by: Lance Richardson <lance.richardson@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 47 +++++++++++++++++++++++-----------\n 1 file changed, 32 insertions(+), 15 deletions(-)",
    "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex d2b89a217..70924d93d 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -618,12 +618,6 @@ static void bnxt_print_link_info(struct rte_eth_dev *eth_dev)\n \t\t\teth_dev->data->port_id);\n }\n \n-static int bnxt_dev_lsc_intr_setup(struct rte_eth_dev *eth_dev)\n-{\n-\tbnxt_print_link_info(eth_dev);\n-\treturn 0;\n-}\n-\n /*\n  * Determine whether the current configuration requires support for scattered\n  * receive; return 1 if scattered receive is required and 0 if not.\n@@ -986,6 +980,19 @@ static struct bnxt_rx_queue *bnxt_qid_to_rxq(struct bnxt *bp, uint16_t qid)\n \treturn bp->eth_dev->data->rx_queues[qid];\n }\n \n+/* Return rxq corresponding to a given rss table ring/group ID. */\n+static uint16_t bnxt_rss_to_qid(struct bnxt *bp, uint16_t fwr)\n+{\n+\tunsigned int i;\n+\n+\tfor (i = 0; i < bp->rx_nr_rings; i++) {\n+\t\tif (bp->grp_info[i].fw_grp_id == fwr)\n+\t\t\treturn i;\n+\t}\n+\n+\treturn INVALID_HW_RING_ID;\n+}\n+\n static int bnxt_reta_update_op(struct rte_eth_dev *eth_dev,\n \t\t\t    struct rte_eth_rss_reta_entry64 *reta_conf,\n \t\t\t    uint16_t reta_size)\n@@ -1039,8 +1046,8 @@ static int bnxt_reta_query_op(struct rte_eth_dev *eth_dev,\n {\n \tstruct bnxt *bp = (struct bnxt *)eth_dev->data->dev_private;\n \tstruct bnxt_vnic_info *vnic = &bp->vnic_info[0];\n-\tstruct rte_intr_handle *intr_handle\n-\t\t= &bp->pdev->intr_handle;\n+\tuint16_t tbl_size = HW_HASH_INDEX_SIZE;\n+\tuint16_t idx, sft, i;\n \n \t/* Retrieve from the default VNIC */\n \tif (!vnic)\n@@ -1048,18 +1055,28 @@ static int bnxt_reta_query_op(struct rte_eth_dev *eth_dev,\n \tif (!vnic->rss_table)\n \t\treturn -EINVAL;\n \n-\tif (reta_size != HW_HASH_INDEX_SIZE) {\n+\tif (reta_size != tbl_size) {\n \t\tPMD_DRV_LOG(ERR, \"The configured hash table lookup size \"\n \t\t\t\"(%d) must equal the size supported by the hardware \"\n-\t\t\t\"(%d)\\n\", reta_size, HW_HASH_INDEX_SIZE);\n+\t\t\t\"(%d)\\n\", reta_size, tbl_size);\n \t\treturn -EINVAL;\n \t}\n-\t/* EW - need to revisit here copying from uint64_t to uint16_t */\n-\tmemcpy(reta_conf, vnic->rss_table, reta_size);\n \n-\tif (rte_intr_allow_others(intr_handle)) {\n-\t\tif (eth_dev->data->dev_conf.intr_conf.lsc != 0)\n-\t\t\tbnxt_dev_lsc_intr_setup(eth_dev);\n+\tfor (idx = 0, i = 0; i < reta_size; i++) {\n+\t\tidx = i / RTE_RETA_GROUP_SIZE;\n+\t\tsft = i % RTE_RETA_GROUP_SIZE;\n+\n+\t\tif (reta_conf[idx].mask & (1ULL << sft)) {\n+\t\t\tuint16_t qid;\n+\n+\t\t\tqid = bnxt_rss_to_qid(bp, vnic->rss_table[i]);\n+\n+\t\t\tif (qid == INVALID_HW_RING_ID) {\n+\t\t\t\tPMD_DRV_LOG(ERR, \"Inv. entry in rss table.\\n\");\n+\t\t\t\treturn -EINVAL;\n+\t\t\t}\n+\t\t\treta_conf[idx].reta[sft] = qid;\n+\t\t}\n \t}\n \n \treturn 0;\n",
    "prefixes": [
        "v2",
        "06/10"
    ]
}