Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53684/?format=api
{ "id": 53684, "url": "http://patches.dpdk.org/api/patches/53684/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190524144935.18765-5-lance.richardson@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190524144935.18765-5-lance.richardson@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190524144935.18765-5-lance.richardson@broadcom.com", "date": "2019-05-24T14:49:29", "name": "[v2,04/10] net/bnxt: fix RSS reta indirection table update", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "61af459c0d67766060e6cbb3e21766b98f32d317", "submitter": { "id": 1323, "url": "http://patches.dpdk.org/api/people/1323/?format=api", "name": "Lance Richardson", "email": "lance.richardson@broadcom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190524144935.18765-5-lance.richardson@broadcom.com/mbox/", "series": [ { "id": 4767, "url": "http://patches.dpdk.org/api/series/4767/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4767", "date": "2019-05-24T14:49:25", "name": "bnxt patchset", "version": 2, "mbox": "http://patches.dpdk.org/series/4767/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53684/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/53684/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4A1E51B957;\n\tFri, 24 May 2019 16:50:16 +0200 (CEST)", "from mail-pl1-f195.google.com (mail-pl1-f195.google.com\n\t[209.85.214.195]) by dpdk.org (Postfix) with ESMTP id 526CC1B94B\n\tfor <dev@dpdk.org>; Fri, 24 May 2019 16:50:09 +0200 (CEST)", "by mail-pl1-f195.google.com with SMTP id f12so4256903plt.8\n\tfor <dev@dpdk.org>; Fri, 24 May 2019 07:50:09 -0700 (PDT)", "from localhost.localdomain ([192.19.231.250])\n\tby smtp.gmail.com with ESMTPSA id\n\tx23sm2723705pfn.160.2019.05.24.07.50.07\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 24 May 2019 07:50:07 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=D4Tf/76sTCwdVK8N3lPMjHIiIX+BSo+aSnWSOcDxKtY=;\n\tb=h1uB+MAKrMWe/qUcqrVV3xbRzkFKlLhUoTzwvrmEqvIlqxvL2fz+yxzYqWJS2GNiit\n\tIcQ9nW8JV0zYPRyW+JXoHMsi9Ibu8uN+2nfyA0gId52hVYIdJyoxSnnPhHP243DArIy9\n\tTPzKdOcJVwdAhKAqP6yqdMWZUapBWzTi4gZrU=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=D4Tf/76sTCwdVK8N3lPMjHIiIX+BSo+aSnWSOcDxKtY=;\n\tb=XJ/c2En3G2/omINzW2m8Q6ZLzXciv+//2rSjFM2NEFmNtPadFaZJY642zFqQQEFLuL\n\tvQQfGbZPqD+TNknNpY0qRkvWq5cwtgmhvjUnaiLZVajBBTHdcV5QB3dwjgBsFkw+MNFg\n\tJOS+FJD+UL9c9BmBYpYERJ32qGNkP9o+T1UDI5uI91+tmMp30gAeUDsM/hWYiQs5wLdd\n\tPyRaKRW15oC+kHc3gnI5w8EHvjyLmxZs3ooEMA6cDU/XhEeGfwrHXM1uJ1mENmYnEcYH\n\tvHS+2hh2LFmEAH2tav/pPphzzWcGIgxbRVSWDmoWKyTQQds1lYG76FV7KWCgIkjhqk6Q\n\tRFbA==", "X-Gm-Message-State": "APjAAAVogDygMOC+HRIw4/XrWxliBz4eKE7RNRHz+Fqkz9GYNOAblo6S\n\tJkwFv2k/pxWJhOx+pO3uBf2DDucKKLqOfVZVIvD6wzsIfTnS5QVLA226f2FXGSUtK/Iq+KifVRA\n\t3rTLt/Ow1/04+5ZToMpNc8mP62PiN7sBrbWZkI1dmEBQyRI/n1OBHDkiGXsrOW3D+", "X-Google-Smtp-Source": "APXvYqzhKlcTM9dpqsV4TtBbjqqN7v3E9iD/aQqqInQjI77zGD3GSBEVndhcy+AItLd0BrA21xVl9Q==", "X-Received": "by 2002:a17:902:324:: with SMTP id\n\t33mr107541535pld.284.1558709408336; \n\tFri, 24 May 2019 07:50:08 -0700 (PDT)", "From": "Lance Richardson <lance.richardson@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ajit.khaparde@broadcom.com, ferruh.yigit@intel.com,\n\tmaxime.coquelin@redhat.com", "Date": "Fri, 24 May 2019 10:49:29 -0400", "Message-Id": "<20190524144935.18765-5-lance.richardson@broadcom.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190524144935.18765-1-lance.richardson@broadcom.com>", "References": "<20190521213953.25425-1-ajit.khaparde@broadcom.com>\n\t<20190524144935.18765-1-lance.richardson@broadcom.com>", "Subject": "[dpdk-dev] [PATCH v2 04/10] net/bnxt: fix RSS reta indirection\n\ttable update", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ajit Khaparde <ajit.khaparde@broadcom.com>\n\nWe are trying to update the indirection table for all the VNICs.\nWe should update the table only for the default vnic0.\nThis patch fixes the above issue.\n\nFixes: d819382543f3 (\"net/bnxt: add RSS redirection table operations\")\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nReviewed-by: Rahul Gupta <rahul.gupta@broadcom.com>\nReviewed-by: Lance Richardson <lance.richardson@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 18 ++++++++++--------\n drivers/net/bnxt/bnxt_hwrm.c | 1 +\n 2 files changed, 11 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 52a6b94e0..2d892cd4f 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -983,8 +983,13 @@ static int bnxt_reta_update_op(struct rte_eth_dev *eth_dev,\n {\n \tstruct bnxt *bp = (struct bnxt *)eth_dev->data->dev_private;\n \tstruct rte_eth_conf *dev_conf = &bp->eth_dev->data->dev_conf;\n-\tstruct bnxt_vnic_info *vnic;\n-\tint i;\n+\tstruct bnxt_vnic_info *vnic = &bp->vnic_info[0];\n+\n+\t/* Update the default RSS VNIC */\n+\tif (!vnic)\n+\t\treturn -EINVAL;\n+\tif (!vnic->rss_table)\n+\t\treturn -EINVAL;\n \n \tif (!(dev_conf->rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG))\n \t\treturn -EINVAL;\n@@ -995,12 +1000,9 @@ static int bnxt_reta_update_op(struct rte_eth_dev *eth_dev,\n \t\t\t\"(%d)\\n\", reta_size, HW_HASH_INDEX_SIZE);\n \t\treturn -EINVAL;\n \t}\n-\t/* Update the RSS VNIC(s) */\n-\tfor (i = 0; i < bp->max_vnics; i++) {\n-\t\tvnic = &bp->vnic_info[i];\n-\t\tmemcpy(vnic->rss_table, reta_conf, reta_size);\n-\t\tbnxt_hwrm_vnic_rss_cfg(bp, vnic);\n-\t}\n+\n+\tmemcpy(vnic->rss_table, reta_conf, reta_size);\n+\tbnxt_hwrm_vnic_rss_cfg(bp, vnic);\n \treturn 0;\n }\n \ndiff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex eb5c41ebb..8c4fa556d 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -1607,6 +1607,7 @@ int bnxt_hwrm_vnic_rss_cfg(struct bnxt *bp,\n \treq.hash_key_tbl_addr =\n \t rte_cpu_to_le_64(vnic->rss_hash_key_dma_addr);\n \treq.rss_ctx_idx = rte_cpu_to_le_16(vnic->rss_rule);\n+\treq.vnic_id = rte_cpu_to_le_16(vnic->fw_vnic_id);\n \n \trc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB);\n \n", "prefixes": [ "v2", "04/10" ] }