Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53600/?format=api
{ "id": 53600, "url": "http://patches.dpdk.org/api/patches/53600/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190521213953.25425-8-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190521213953.25425-8-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190521213953.25425-8-ajit.khaparde@broadcom.com", "date": "2019-05-21T21:39:49", "name": "[07/11] net/bnxt: fix reta query op", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9cff9892c9ec41603ef00438854429e4c255fbaf", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190521213953.25425-8-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 4736, "url": "http://patches.dpdk.org/api/series/4736/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4736", "date": "2019-05-21T21:39:43", "name": "bnxt patchset", "version": 1, "mbox": "http://patches.dpdk.org/series/4736/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53600/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/53600/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 84CE35F51;\n\tTue, 21 May 2019 23:40:21 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id E01104C9D\n\tfor <dev@dpdk.org>; Tue, 21 May 2019 23:39:58 +0200 (CEST)", "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 680B630C0DF;\n\tTue, 21 May 2019 14:39:56 -0700 (PDT)", "from C02VPB22HTD6.wifi.broadcom.net (c02vpb22htd6.wifi.broadcom.net\n\t[10.69.74.102])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id 2728BAC07C3;\n\tTue, 21 May 2019 14:39:56 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 680B630C0DF", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1558474796;\n\tbh=oqddp6Q/NdN8prH3HVtVtFlJsUJzcrEg/1SzsWb7Jm4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=gv7GKycf4lIX6QmCuinTGVbJtUKeuv5GJTFQSbUb2YvG+RPvJAbSklkjHdcxv35xk\n\tnocT2aj2U8jyuF5lOUwxeKjAvdQSmt8yN+uhAajUFKfUd6fv+m6UrTysPpi0fyfkrL\n\tUJsj5FB/Sphk7qKdf3o8vkj8zwoE9kaQhYvSKr4E=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, Lance Richardson <lance.richardson@broadcom.com>", "Date": "Tue, 21 May 2019 14:39:49 -0700", "Message-Id": "<20190521213953.25425-8-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.20.1 (Apple Git-117)", "In-Reply-To": "<20190521213953.25425-1-ajit.khaparde@broadcom.com>", "References": "<20190521213953.25425-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 07/11] net/bnxt: fix reta query op", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Lance Richardson <lance.richardson@broadcom.com>\n\nFix reta query op to only return table entries as identfied by the\nprovided mask. Translate firmware group IDs to queue numbers.\n\nRemoved extraneous code from bnxt_reta_query_op().\n\nFixes: d819382543f3 (\"net/bnxt: add RSS redirection table operations\")\nSigned-off-by: Lance Richardson <lance.richardson@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 47 +++++++++++++++++++++++-----------\n 1 file changed, 32 insertions(+), 15 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex d2b89a217..70924d93d 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -618,12 +618,6 @@ static void bnxt_print_link_info(struct rte_eth_dev *eth_dev)\n \t\t\teth_dev->data->port_id);\n }\n \n-static int bnxt_dev_lsc_intr_setup(struct rte_eth_dev *eth_dev)\n-{\n-\tbnxt_print_link_info(eth_dev);\n-\treturn 0;\n-}\n-\n /*\n * Determine whether the current configuration requires support for scattered\n * receive; return 1 if scattered receive is required and 0 if not.\n@@ -986,6 +980,19 @@ static struct bnxt_rx_queue *bnxt_qid_to_rxq(struct bnxt *bp, uint16_t qid)\n \treturn bp->eth_dev->data->rx_queues[qid];\n }\n \n+/* Return rxq corresponding to a given rss table ring/group ID. */\n+static uint16_t bnxt_rss_to_qid(struct bnxt *bp, uint16_t fwr)\n+{\n+\tunsigned int i;\n+\n+\tfor (i = 0; i < bp->rx_nr_rings; i++) {\n+\t\tif (bp->grp_info[i].fw_grp_id == fwr)\n+\t\t\treturn i;\n+\t}\n+\n+\treturn INVALID_HW_RING_ID;\n+}\n+\n static int bnxt_reta_update_op(struct rte_eth_dev *eth_dev,\n \t\t\t struct rte_eth_rss_reta_entry64 *reta_conf,\n \t\t\t uint16_t reta_size)\n@@ -1039,8 +1046,8 @@ static int bnxt_reta_query_op(struct rte_eth_dev *eth_dev,\n {\n \tstruct bnxt *bp = (struct bnxt *)eth_dev->data->dev_private;\n \tstruct bnxt_vnic_info *vnic = &bp->vnic_info[0];\n-\tstruct rte_intr_handle *intr_handle\n-\t\t= &bp->pdev->intr_handle;\n+\tuint16_t tbl_size = HW_HASH_INDEX_SIZE;\n+\tuint16_t idx, sft, i;\n \n \t/* Retrieve from the default VNIC */\n \tif (!vnic)\n@@ -1048,18 +1055,28 @@ static int bnxt_reta_query_op(struct rte_eth_dev *eth_dev,\n \tif (!vnic->rss_table)\n \t\treturn -EINVAL;\n \n-\tif (reta_size != HW_HASH_INDEX_SIZE) {\n+\tif (reta_size != tbl_size) {\n \t\tPMD_DRV_LOG(ERR, \"The configured hash table lookup size \"\n \t\t\t\"(%d) must equal the size supported by the hardware \"\n-\t\t\t\"(%d)\\n\", reta_size, HW_HASH_INDEX_SIZE);\n+\t\t\t\"(%d)\\n\", reta_size, tbl_size);\n \t\treturn -EINVAL;\n \t}\n-\t/* EW - need to revisit here copying from uint64_t to uint16_t */\n-\tmemcpy(reta_conf, vnic->rss_table, reta_size);\n \n-\tif (rte_intr_allow_others(intr_handle)) {\n-\t\tif (eth_dev->data->dev_conf.intr_conf.lsc != 0)\n-\t\t\tbnxt_dev_lsc_intr_setup(eth_dev);\n+\tfor (idx = 0, i = 0; i < reta_size; i++) {\n+\t\tidx = i / RTE_RETA_GROUP_SIZE;\n+\t\tsft = i % RTE_RETA_GROUP_SIZE;\n+\n+\t\tif (reta_conf[idx].mask & (1ULL << sft)) {\n+\t\t\tuint16_t qid;\n+\n+\t\t\tqid = bnxt_rss_to_qid(bp, vnic->rss_table[i]);\n+\n+\t\t\tif (qid == INVALID_HW_RING_ID) {\n+\t\t\t\tPMD_DRV_LOG(ERR, \"Inv. entry in rss table.\\n\");\n+\t\t\t\treturn -EINVAL;\n+\t\t\t}\n+\t\t\treta_conf[idx].reta[sft] = qid;\n+\t\t}\n \t}\n \n \treturn 0;\n", "prefixes": [ "07/11" ] }