Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53599/?format=api
http://patches.dpdk.org/api/patches/53599/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190521213953.25425-7-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190521213953.25425-7-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190521213953.25425-7-ajit.khaparde@broadcom.com", "date": "2019-05-21T21:39:48", "name": "[06/11] net/bnxt: use reta update mask and translate qid to grp id", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2a5c7d240a5653b395f1f165666454d111f2d6d4", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190521213953.25425-7-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 4736, "url": "http://patches.dpdk.org/api/series/4736/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4736", "date": "2019-05-21T21:39:43", "name": "bnxt patchset", "version": 1, "mbox": "http://patches.dpdk.org/series/4736/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53599/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/53599/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BDB5B5F2E;\n\tTue, 21 May 2019 23:40:19 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id E03584CA7\n\tfor <dev@dpdk.org>; Tue, 21 May 2019 23:39:58 +0200 (CEST)", "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 52D3D30C0DE;\n\tTue, 21 May 2019 14:39:56 -0700 (PDT)", "from C02VPB22HTD6.wifi.broadcom.net (c02vpb22htd6.wifi.broadcom.net\n\t[10.69.74.102])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id 0F11DAC074E;\n\tTue, 21 May 2019 14:39:56 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 52D3D30C0DE", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1558474796;\n\tbh=wJmRQNCM1yjIMwa9TBsKbwsPJQCjyS0BMBhlhZqkVAE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=GXGpDP3D94Fg02HM0CzS05xeGzGLA3GQsFJ3IZjacMqTcstsTYurTUL7f3Xc8cEG0\n\tckouRABtAnOaYRUWxBvCB0bmyEu4pTYO/p3aKWRubvcEQKrVO+AXEBpE1izwiJSzFO\n\tdhLku1+wLwc/KlXrKGMXgNWuafU/0jQT3Q9DZxx0=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, Lance Richardson <lance.richardson@broadcom.com>", "Date": "Tue, 21 May 2019 14:39:48 -0700", "Message-Id": "<20190521213953.25425-7-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.20.1 (Apple Git-117)", "In-Reply-To": "<20190521213953.25425-1-ajit.khaparde@broadcom.com>", "References": "<20190521213953.25425-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 06/11] net/bnxt: use reta update mask and\n\ttranslate qid to grp id", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Lance Richardson <lance.richardson@broadcom.com>\n\nFix the reta update function to only update table entries that are\nselected by the update mask. Translate queue number to firmware\ngroup ID when updating an entry.\n\nFixes: d819382543f3 (\"net/bnxt: add RSS redirection table operations\")\nSigned-off-by: Lance Richardson <lance.richardson@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 39 ++++++++++++++++++++++++++++------\n 1 file changed, 33 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 2d892cd4f..d2b89a217 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -977,6 +977,15 @@ static void bnxt_allmulticast_disable_op(struct rte_eth_dev *eth_dev)\n \tbnxt_hwrm_cfa_l2_set_rx_mask(bp, vnic, 0, NULL);\n }\n \n+/* Return bnxt_rx_queue pointer corresponding to a given rxq. */\n+static struct bnxt_rx_queue *bnxt_qid_to_rxq(struct bnxt *bp, uint16_t qid)\n+{\n+\tif (qid >= bp->rx_nr_rings)\n+\t\treturn NULL;\n+\n+\treturn bp->eth_dev->data->rx_queues[qid];\n+}\n+\n static int bnxt_reta_update_op(struct rte_eth_dev *eth_dev,\n \t\t\t struct rte_eth_rss_reta_entry64 *reta_conf,\n \t\t\t uint16_t reta_size)\n@@ -984,24 +993,42 @@ static int bnxt_reta_update_op(struct rte_eth_dev *eth_dev,\n \tstruct bnxt *bp = (struct bnxt *)eth_dev->data->dev_private;\n \tstruct rte_eth_conf *dev_conf = &bp->eth_dev->data->dev_conf;\n \tstruct bnxt_vnic_info *vnic = &bp->vnic_info[0];\n+\tuint16_t tbl_size = HW_HASH_INDEX_SIZE;\n+\tuint16_t idx, sft;\n+\tint i;\n \n-\t/* Update the default RSS VNIC */\n-\tif (!vnic)\n-\t\treturn -EINVAL;\n \tif (!vnic->rss_table)\n \t\treturn -EINVAL;\n \n \tif (!(dev_conf->rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG))\n \t\treturn -EINVAL;\n \n-\tif (reta_size != HW_HASH_INDEX_SIZE) {\n+\tif (reta_size != tbl_size) {\n \t\tPMD_DRV_LOG(ERR, \"The configured hash table lookup size \"\n \t\t\t\"(%d) must equal the size supported by the hardware \"\n-\t\t\t\"(%d)\\n\", reta_size, HW_HASH_INDEX_SIZE);\n+\t\t\t\"(%d)\\n\", reta_size, tbl_size);\n \t\treturn -EINVAL;\n \t}\n \n-\tmemcpy(vnic->rss_table, reta_conf, reta_size);\n+\tfor (i = 0; i < reta_size; i++) {\n+\t\tstruct bnxt_rx_queue *rxq;\n+\n+\t\tidx = i / RTE_RETA_GROUP_SIZE;\n+\t\tsft = i % RTE_RETA_GROUP_SIZE;\n+\n+\t\tif (!(reta_conf[idx].mask & (1ULL << sft)))\n+\t\t\tcontinue;\n+\n+\t\trxq = bnxt_qid_to_rxq(bp, reta_conf[idx].reta[sft]);\n+\t\tif (!rxq) {\n+\t\t\tPMD_DRV_LOG(ERR, \"Invalid ring in reta_conf.\\n\");\n+\t\t\treturn -EINVAL;\n+\t\t}\n+\n+\t\tvnic->rss_table[i] =\n+\t\t vnic->fw_grp_ids[reta_conf[idx].reta[sft]];\n+\t}\n+\n \tbnxt_hwrm_vnic_rss_cfg(bp, vnic);\n \treturn 0;\n }\n", "prefixes": [ "06/11" ] }{ "id": 53599, "url": "