Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53591/?format=api
{ "id": 53591, "url": "http://patches.dpdk.org/api/patches/53591/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190521212712.29357-1-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190521212712.29357-1-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190521212712.29357-1-stephen@networkplumber.org", "date": "2019-05-21T21:27:12", "name": "net/mlx4: use dynamic log type", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "63eaec111bd60019185232a7db079183cd0d4b47", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 6624, "url": "http://patches.dpdk.org/api/users/6624/?format=api", "username": "shahafs", "first_name": "Shahaf", "last_name": "Shuler", "email": "shahafs@mellanox.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190521212712.29357-1-stephen@networkplumber.org/mbox/", "series": [ { "id": 4735, "url": "http://patches.dpdk.org/api/series/4735/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4735", "date": "2019-05-21T21:27:12", "name": "net/mlx4: use dynamic log type", "version": 1, "mbox": "http://patches.dpdk.org/series/4735/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53591/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/53591/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E27874C9D;\n\tTue, 21 May 2019 23:27:16 +0200 (CEST)", "from mail-pf1-f194.google.com (mail-pf1-f194.google.com\n\t[209.85.210.194]) by dpdk.org (Postfix) with ESMTP id 82DEA4C96\n\tfor <dev@dpdk.org>; Tue, 21 May 2019 23:27:15 +0200 (CEST)", "by mail-pf1-f194.google.com with SMTP id v80so115914pfa.3\n\tfor <dev@dpdk.org>; Tue, 21 May 2019 14:27:15 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tw12sm33606399pfj.41.2019.05.21.14.27.13\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 21 May 2019 14:27:14 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=yG667BhGjztcj6Deq7/Ez6qgvlh3Ty4IsBBOp0s6kwU=;\n\tb=Lo77u2TlMOjdT7cl0zoVFewUV/pjlo4kBucmnFe3EATxHpsi+rHH9JBfmhO9B2RKBK\n\tV4pBM0B6ibSA3iWogJiP25jsnXKVC0s190+fn9mlr0wkA0snEHZN3FKpHpkgX1oFJOeo\n\teS4peXw6K4PZcPZMZ0HI8rFBcOkVFPfr2sEWUn6ZQL/QLmwLkReG1orVeviqIn8YyRTW\n\tG2pgUA1o8ZFS+QOMEyJBdEFtMeCZaHWA62MRaIv9ZcAiEdxVTOkBHFVBcNcGrC05xdcr\n\tb1QGLtDGkCz4Ib+mynWKnJy11VleIpAyah889XNIriqVJFy1JqmRpOl0cCx5hLD0EPsx\n\tEPrw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=yG667BhGjztcj6Deq7/Ez6qgvlh3Ty4IsBBOp0s6kwU=;\n\tb=blMM23FWuJy0/M8ctSzC1vGZZUn5jRJ4FWEJw4UbbPDRndV1GQ3nqrPVbkLjm9E+DQ\n\tA8ycZ7aHE0RLb1KdTai/t/KOOODbzDRGvk7mMCceHDNwxOKddlvjaA4dfsyVYBhTeTg4\n\tkpSyRMGLihHtL3O7eSN2M/SAqvwjfLgdP9MWnJnLUDg8GW8gyRE4jHxj33PZFqQDRZke\n\tvLtoid17kQvpv2Xn/v4bpXUs+2ceVwq79JG9YNqLbMOU2ciB6mNfWNa9Ve0BQJKTvUxK\n\tRcxbuErtM8r0MpYKJlJMeIcw9UI79jgflOg1Gv7jYTLSIF/Y1wZ0fG+PyxAMAmbNbNsW\n\tAepA==", "X-Gm-Message-State": "APjAAAVjp4UnpoI74Vo2pGOH9uO5hkq277LRE+VU/aNW3L14RUVu8XTy\n\tYGG3lm9pYf5DGRAAnac5WQA6xA==", "X-Google-Smtp-Source": "APXvYqywgQa4+RmtRz2EOScN4efahrTr6PVaKB01RlZwzuOC6fpDhgXTGXkETeOqpvbarDxmnXbveg==", "X-Received": "by 2002:a63:1d05:: with SMTP id\n\td5mr84705344pgd.157.1558474034551; \n\tTue, 21 May 2019 14:27:14 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "matan@mellanox.com,\n\tshahafs@mellanox.com", "Cc": "dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>,\n\tStephen Hemminger <sthemmin@microsoft.com>", "Date": "Tue, 21 May 2019 14:27:12 -0700", "Message-Id": "<20190521212712.29357-1-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] net/mlx4: use dynamic log type", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This driver should use dynamic log level not RTE_LOGTYPE_PMD.\nOther drivers were converted back in 18.02.\n\nThis is really a bug, all other drivers use dynamic log levels\nby now.\n\nSigned-off-by: Stephen Hemminger <sthemmin@microsoft.com>\n---\n drivers/net/mlx4/mlx4.c | 8 ++++++++\n drivers/net/mlx4/mlx4_utils.h | 6 ++++--\n 2 files changed, 12 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c\nindex fe559c040706..e532dc53738f 100644\n--- a/drivers/net/mlx4/mlx4.c\n+++ b/drivers/net/mlx4/mlx4.c\n@@ -60,6 +60,9 @@ static rte_spinlock_t mlx4_shared_data_lock = RTE_SPINLOCK_INITIALIZER;\n /* Process local data for secondary processes. */\n static struct mlx4_local_data mlx4_local_data;\n \n+/** Driver-specific log messages type. */\n+int mlx4_logtype;\n+\n /** Configuration structure for device arguments. */\n struct mlx4_conf {\n \tstruct {\n@@ -1272,6 +1275,11 @@ mlx4_glue_init(void)\n */\n RTE_INIT(rte_mlx4_pmd_init)\n {\n+\t/* Initialize driver log type. */\n+\tmlx4_logtype = rte_log_register(\"pmd.net.mlx4\");\n+\tif (mlx4_logtype >= 0)\n+\t\trte_log_set_level(mlx4_logtype, RTE_LOG_NOTICE);\n+\n \t/*\n \t * MLX4_DEVICE_FATAL_CLEANUP tells ibv_destroy functions we\n \t * want to get success errno value in case of calling them\ndiff --git a/drivers/net/mlx4/mlx4_utils.h b/drivers/net/mlx4/mlx4_utils.h\nindex 86abb3b7e376..9d3d2a4e32a1 100644\n--- a/drivers/net/mlx4/mlx4_utils.h\n+++ b/drivers/net/mlx4/mlx4_utils.h\n@@ -15,6 +15,8 @@\n \n #include \"mlx4.h\"\n \n+extern int mlx4_logtype;\n+\n #ifndef NDEBUG\n \n /*\n@@ -35,7 +37,7 @@ pmd_drv_log_basename(const char *s)\n }\n \n #define PMD_DRV_LOG(level, ...) \\\n-\tRTE_LOG(level, PMD, \\\n+\tRTE_LOG(level, mlx4_logtype, \\\n \t\tRTE_FMT(\"%s:%u: %s(): \" RTE_FMT_HEAD(__VA_ARGS__,) \"\\n\", \\\n \t\t\tpmd_drv_log_basename(__FILE__), \\\n \t\t\t__LINE__, \\\n@@ -52,7 +54,7 @@ pmd_drv_log_basename(const char *s)\n */\n \n #define PMD_DRV_LOG(level, ...) \\\n-\tRTE_LOG(level, PMD, \\\n+\tRTE_LOG(level, mlx4_logtype, \\\n \t\tRTE_FMT(MLX4_DRIVER_NAME \": \" \\\n \t\t\tRTE_FMT_HEAD(__VA_ARGS__,) \"\\n\", \\\n \t\tRTE_FMT_TAIL(__VA_ARGS__,)))\n", "prefixes": [] }