Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53527/?format=api
{ "id": 53527, "url": "http://patches.dpdk.org/api/patches/53527/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190517134529.18160-4-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190517134529.18160-4-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190517134529.18160-4-bruce.richardson@intel.com", "date": "2019-05-17T13:45:29", "name": "[v2,3/3] kernel/linux: remove unneeded local variables", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "76f47dcb4370062fdbad054a47b0ffc39efce6c4", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190517134529.18160-4-bruce.richardson@intel.com/mbox/", "series": [ { "id": 4708, "url": "http://patches.dpdk.org/api/series/4708/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4708", "date": "2019-05-17T13:45:26", "name": "cleanup kernel meson.build file for linux", "version": 2, "mbox": "http://patches.dpdk.org/series/4708/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53527/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/53527/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C20C58E76;\n\tFri, 17 May 2019 15:45:49 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id 004297D4A\n\tfor <dev@dpdk.org>; Fri, 17 May 2019 15:45:47 +0200 (CEST)", "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t17 May 2019 06:45:47 -0700", "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.223.2])\n\tby orsmga004.jf.intel.com with ESMTP; 17 May 2019 06:45:45 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "david.marchand@redhat.com, bluca@debian.org,\n\tBruce Richardson <bruce.richardson@intel.com>", "Date": "Fri, 17 May 2019 14:45:29 +0100", "Message-Id": "<20190517134529.18160-4-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190517134529.18160-1-bruce.richardson@intel.com>", "References": "<20190430140325.45537-1-bruce.richardson@intel.com>\n\t<20190517134529.18160-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 3/3] kernel/linux: remove unneeded local\n\tvariables", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The local variables for the error message aren't needed, since the messages\naren't used more than once, and the indent levels are now such that the\nlines printing the message are not much longer than the lines defining the\nvariables to hold the messages themselves. Therefore the use of the\nvariables is pointless.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nReviewed-by: David Marchand <david.marchand@redhat.com>\n---\n kernel/linux/meson.build | 7 ++-----\n 1 file changed, 2 insertions(+), 5 deletions(-)", "diff": "diff --git a/kernel/linux/meson.build b/kernel/linux/meson.build\nindex d31fc8f80..a37c95752 100644\n--- a/kernel/linux/meson.build\n+++ b/kernel/linux/meson.build\n@@ -3,12 +3,9 @@\n \n subdirs = ['igb_uio', 'kni']\n \n-WARN_CROSS_COMPILE='Need \"kernel_dir\" option for kmod compilation when cross-compiling'\n-WARN_NO_HEADERS='Cannot compile kernel modules as requested - are kernel headers installed?'\n-\n # if we are cross-compiling we need kernel_dir specified\n if get_option('kernel_dir') == '' and meson.is_cross_build()\n-\twarning(WARN_CROSS_COMPILE)\n+\twarning('Need \"kernel_dir\" option for kmod compilation when cross-compiling')\n \tsubdir_done()\n endif\n \n@@ -23,7 +20,7 @@ endif\n make_returncode = run_command('make', '-sC', kernel_dir,\n \t\t'kernelversion').returncode()\n if make_returncode != 0\n-\twarning(WARN_NO_HEADERS)\n+\twarning('Cannot compile kernel modules as requested - are kernel headers installed?')\n \tsubdir_done()\n endif\n \n", "prefixes": [ "v2", "3/3" ] }