Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53526/?format=api
{ "id": 53526, "url": "http://patches.dpdk.org/api/patches/53526/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190517134529.18160-3-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190517134529.18160-3-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190517134529.18160-3-bruce.richardson@intel.com", "date": "2019-05-17T13:45:28", "name": "[v2,2/3] kernel/linux: reduce unneeded indents in meson build file", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "28cbda36643a4f687e6220dc330967b7550cccc4", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190517134529.18160-3-bruce.richardson@intel.com/mbox/", "series": [ { "id": 4708, "url": "http://patches.dpdk.org/api/series/4708/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4708", "date": "2019-05-17T13:45:26", "name": "cleanup kernel meson.build file for linux", "version": 2, "mbox": "http://patches.dpdk.org/series/4708/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53526/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/53526/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1A8597CB0;\n\tFri, 17 May 2019 15:45:41 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby dpdk.org (Postfix) with ESMTP id EBD0B6904\n\tfor <dev@dpdk.org>; Fri, 17 May 2019 15:45:39 +0200 (CEST)", "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t17 May 2019 06:45:39 -0700", "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.223.2])\n\tby orsmga004.jf.intel.com with ESMTP; 17 May 2019 06:45:38 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "david.marchand@redhat.com, bluca@debian.org,\n\tBruce Richardson <bruce.richardson@intel.com>", "Date": "Fri, 17 May 2019 14:45:28 +0100", "Message-Id": "<20190517134529.18160-3-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190517134529.18160-1-bruce.richardson@intel.com>", "References": "<20190430140325.45537-1-bruce.richardson@intel.com>\n\t<20190517134529.18160-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 2/3] kernel/linux: reduce unneeded indents in\n\tmeson build file", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Since meson 0.46, meson has supported the subdir_done() function, which\nallows us to abort processing of a file early. Using this we can reduce the\nindentation in our files by eliminating unnecessary else blocks.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nReviewed-by: David Marchand <david.marchand@redhat.com>\n---\n kernel/linux/meson.build | 36 ++++++++++++++++++------------------\n 1 file changed, 18 insertions(+), 18 deletions(-)", "diff": "diff --git a/kernel/linux/meson.build b/kernel/linux/meson.build\nindex bf8f085b0..d31fc8f80 100644\n--- a/kernel/linux/meson.build\n+++ b/kernel/linux/meson.build\n@@ -9,25 +9,25 @@ WARN_NO_HEADERS='Cannot compile kernel modules as requested - are kernel headers\n # if we are cross-compiling we need kernel_dir specified\n if get_option('kernel_dir') == '' and meson.is_cross_build()\n \twarning(WARN_CROSS_COMPILE)\n-else\n+\tsubdir_done()\n+endif\n \n-\tkernel_dir = get_option('kernel_dir')\n-\tif kernel_dir == ''\n-\t\t# use default path for native builds\n-\t\tkernel_version = run_command('uname', '-r').stdout().strip()\n-\t\tkernel_dir = '/lib/modules/' + kernel_version + '/build'\n-\tendif\n+kernel_dir = get_option('kernel_dir')\n+if kernel_dir == ''\n+\t# use default path for native builds\n+\tkernel_version = run_command('uname', '-r').stdout().strip()\n+\tkernel_dir = '/lib/modules/' + kernel_version + '/build'\n+endif\n \n-\t# test running make in kernel directory, using \"make kernelversion\"\n-\tmake_returncode = run_command('make', '-sC', kernel_dir,\n-\t\t\t'kernelversion').returncode()\n-\tif make_returncode != 0\n-\t\twarning(WARN_NO_HEADERS)\n-\telse # returncode == 0\n+# test running make in kernel directory, using \"make kernelversion\"\n+make_returncode = run_command('make', '-sC', kernel_dir,\n+\t\t'kernelversion').returncode()\n+if make_returncode != 0\n+\twarning(WARN_NO_HEADERS)\n+\tsubdir_done()\n+endif\n \n # DO ACTUAL MODULE BUILDING\n-\t\tforeach d:subdirs\n-\t\t\tsubdir(d)\n-\t\tendforeach\n-\tendif\n-endif\n+foreach d:subdirs\n+\tsubdir(d)\n+endforeach\n", "prefixes": [ "v2", "2/3" ] }