Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53523/?format=api
{ "id": 53523, "url": "http://patches.dpdk.org/api/patches/53523/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190517122220.31283-6-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190517122220.31283-6-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190517122220.31283-6-maxime.coquelin@redhat.com", "date": "2019-05-17T12:22:20", "name": "[5/5] eal/x86: force inlining of all memcpy and mov helpers", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "5ffdb22b064f1141362be073a4aa8f1ba9212ae1", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190517122220.31283-6-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 4707, "url": "http://patches.dpdk.org/api/series/4707/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4707", "date": "2019-05-17T12:22:15", "name": "vhost: I-cache pressure optimizations", "version": 1, "mbox": "http://patches.dpdk.org/series/4707/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53523/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/53523/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B7AB4D1A3;\n\tFri, 17 May 2019 14:22:59 +0200 (CEST)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id 81B4CD17B\n\tfor <dev@dpdk.org>; Fri, 17 May 2019 14:22:58 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id DBD90B2DCE;\n\tFri, 17 May 2019 12:22:57 +0000 (UTC)", "from localhost.localdomain (ovpn-112-59.ams2.redhat.com\n\t[10.36.112.59])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id ED3D610021B2;\n\tFri, 17 May 2019 12:22:50 +0000 (UTC)" ], "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, tiwei.bie@intel.com, jfreimann@redhat.com,\n\tzhihong.wang@intel.com, bruce.richardson@intel.com,\n\tkonstantin.ananyev@intel.com", "Cc": "root <root@virtlab510.virt.lab.eng.bos.redhat.com>", "Date": "Fri, 17 May 2019 14:22:20 +0200", "Message-Id": "<20190517122220.31283-6-maxime.coquelin@redhat.com>", "In-Reply-To": "<20190517122220.31283-1-maxime.coquelin@redhat.com>", "References": "<20190517122220.31283-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 2.84 on 10.5.11.22", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]); Fri, 17 May 2019 12:22:57 +0000 (UTC)", "Subject": "[dpdk-dev] [PATCH 5/5] eal/x86: force inlining of all memcpy and\n\tmov helpers", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: root <root@virtlab510.virt.lab.eng.bos.redhat.com>\n\nSome helpers in the header file are forced inlined other are\nonly inlined, this patch forces inline for all.\n\nIt will avoid it to be embedded as functions when called multiple\ntimes in the same object file. For example, when we added packed\nring support in vhost-user library, rte_memcpy_generic got no\nmore inlined.\n\nSigned-off-by: root <root@virtlab510.virt.lab.eng.bos.redhat.com>\n---\n .../common/include/arch/x86/rte_memcpy.h | 18 +++++++++---------\n 1 file changed, 9 insertions(+), 9 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h\nindex 7b758094df..ba44c4a328 100644\n--- a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h\n+++ b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h\n@@ -115,7 +115,7 @@ rte_mov256(uint8_t *dst, const uint8_t *src)\n * Copy 128-byte blocks from one location to another,\n * locations should not overlap.\n */\n-static inline void\n+static __rte_always_inline void\n rte_mov128blocks(uint8_t *dst, const uint8_t *src, size_t n)\n {\n \t__m512i zmm0, zmm1;\n@@ -163,7 +163,7 @@ rte_mov512blocks(uint8_t *dst, const uint8_t *src, size_t n)\n \t}\n }\n \n-static inline void *\n+static __rte_always_inline void *\n rte_memcpy_generic(void *dst, const void *src, size_t n)\n {\n \tuintptr_t dstu = (uintptr_t)dst;\n@@ -330,7 +330,7 @@ rte_mov64(uint8_t *dst, const uint8_t *src)\n * Copy 128 bytes from one location to another,\n * locations should not overlap.\n */\n-static inline void\n+static __rte_always_inline void\n rte_mov128(uint8_t *dst, const uint8_t *src)\n {\n \trte_mov32((uint8_t *)dst + 0 * 32, (const uint8_t *)src + 0 * 32);\n@@ -343,7 +343,7 @@ rte_mov128(uint8_t *dst, const uint8_t *src)\n * Copy 128-byte blocks from one location to another,\n * locations should not overlap.\n */\n-static inline void\n+static __rte_always_inline void\n rte_mov128blocks(uint8_t *dst, const uint8_t *src, size_t n)\n {\n \t__m256i ymm0, ymm1, ymm2, ymm3;\n@@ -363,7 +363,7 @@ rte_mov128blocks(uint8_t *dst, const uint8_t *src, size_t n)\n \t}\n }\n \n-static inline void *\n+static __rte_always_inline void *\n rte_memcpy_generic(void *dst, const void *src, size_t n)\n {\n \tuintptr_t dstu = (uintptr_t)dst;\n@@ -523,7 +523,7 @@ rte_mov64(uint8_t *dst, const uint8_t *src)\n * Copy 128 bytes from one location to another,\n * locations should not overlap.\n */\n-static inline void\n+static __rte_always_inline void\n rte_mov128(uint8_t *dst, const uint8_t *src)\n {\n \trte_mov16((uint8_t *)dst + 0 * 16, (const uint8_t *)src + 0 * 16);\n@@ -655,7 +655,7 @@ __extension__ ({ \\\n } \\\n })\n \n-static inline void *\n+static __rte_always_inline void *\n rte_memcpy_generic(void *dst, const void *src, size_t n)\n {\n \t__m128i xmm0, xmm1, xmm2, xmm3, xmm4, xmm5, xmm6, xmm7, xmm8;\n@@ -800,7 +800,7 @@ rte_memcpy_generic(void *dst, const void *src, size_t n)\n \n #endif /* RTE_MACHINE_CPUFLAG */\n \n-static inline void *\n+static __rte_always_inline void *\n rte_memcpy_aligned(void *dst, const void *src, size_t n)\n {\n \tvoid *ret = dst;\n@@ -860,7 +860,7 @@ rte_memcpy_aligned(void *dst, const void *src, size_t n)\n \treturn ret;\n }\n \n-static inline void *\n+static __rte_always_inline void *\n rte_memcpy(void *dst, const void *src, size_t n)\n {\n \tif (!(((uintptr_t)dst | (uintptr_t)src) & ALIGNMENT_MASK))\n", "prefixes": [ "5/5" ] }