Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53515/?format=api
http://patches.dpdk.org/api/patches/53515/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190517120231.15898-2-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190517120231.15898-2-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190517120231.15898-2-bruce.richardson@intel.com", "date": "2019-05-17T12:02:29", "name": "[v3,1/3] examples: fix install of sample apps if setting not provided", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "97d5cd4a859cceb7d961d2226f861ef88b157ff9", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190517120231.15898-2-bruce.richardson@intel.com/mbox/", "series": [ { "id": 4706, "url": "http://patches.dpdk.org/api/series/4706/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4706", "date": "2019-05-17T12:02:28", "name": "Fixes for building examples", "version": 3, "mbox": "http://patches.dpdk.org/series/4706/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53515/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/53515/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 97F1C5F51;\n\tFri, 17 May 2019 14:02:41 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id DE4C75F2E;\n\tFri, 17 May 2019 14:02:37 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t17 May 2019 05:02:37 -0700", "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.223.2])\n\tby orsmga008.jf.intel.com with ESMTP; 17 May 2019 05:02:36 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "bluca@debian.org, Bruce Richardson <bruce.richardson@intel.com>,\n\tstable@dpdk.org", "Date": "Fri, 17 May 2019 13:02:29 +0100", "Message-Id": "<20190517120231.15898-2-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190517120231.15898-1-bruce.richardson@intel.com>", "References": "<20190517114613.7027-1-bruce.richardson@intel.com>\n\t<20190517120231.15898-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 1/3] examples: fix install of sample apps if\n\tsetting not provided", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "While the examples were being installed into the appropriate install path\nwhen processing the examples/meson.build file, that file was only processed\nif the \"examples\" meson parameter was non-empty. Since we now do more than\njust build the examples, we need to unconditionally process the file.\n\nFixes: 2daf565f91b5 (\"examples: install as part of ninja install\")\n\nCc: stable@dpdk.org\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n examples/meson.build | 4 ++++\n meson.build | 7 +++----\n 2 files changed, 7 insertions(+), 4 deletions(-)", "diff": "diff --git a/examples/meson.build b/examples/meson.build\nindex 1a6134f12..1995f4dcb 100644\n--- a/examples/meson.build\n+++ b/examples/meson.build\n@@ -19,6 +19,10 @@ foreach ex:all_examples\n \t\t\texclude_files: 'meson.build')\n endforeach\n \n+if get_option('examples') == ''\n+\tsubdir_done()\n+endif\n+\n if get_option('examples').to_lower() == 'all'\n \texamples = all_examples\n \tallow_skips = true # don't flag an error if we can't build an app\ndiff --git a/meson.build b/meson.build\nindex 46f9c5683..9cad43481 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -42,10 +42,9 @@ subdir('app')\n # build docs\n subdir('doc')\n \n-# build any examples explicitly requested - useful for developers\n-if get_option('examples') != ''\n-\tsubdir('examples')\n-endif\n+# build any examples explicitly requested - useful for developers - and\n+# install any example code into the appropriate install path\n+subdir('examples')\n \n # build kernel modules if enabled\n if get_option('enable_kmods')\n", "prefixes": [ "v3", "1/3" ] }{ "id": 53515, "url": "