Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53506/?format=api
{ "id": 53506, "url": "http://patches.dpdk.org/api/patches/53506/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190517114613.7027-3-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190517114613.7027-3-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190517114613.7027-3-bruce.richardson@intel.com", "date": "2019-05-17T11:46:12", "name": "[v2,2/3] examples: remove auto-generation of examples list", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "aa098a9247fc55e6f539b65bddd250ae6d8ee516", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190517114613.7027-3-bruce.richardson@intel.com/mbox/", "series": [ { "id": 4704, "url": "http://patches.dpdk.org/api/series/4704/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4704", "date": "2019-05-17T11:46:10", "name": "Fixes for building examples", "version": 2, "mbox": "http://patches.dpdk.org/series/4704/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53506/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/53506/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 908E65F1D;\n\tFri, 17 May 2019 13:47:01 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby dpdk.org (Postfix) with ESMTP id DE4665F14;\n\tFri, 17 May 2019 13:46:56 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t17 May 2019 04:46:56 -0700", "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.223.2])\n\tby orsmga001.jf.intel.com with ESMTP; 17 May 2019 04:46:55 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "bluca@debian.org, Bruce Richardson <bruce.richardson@intel.com>,\n\tstable@dpdk.org", "Date": "Fri, 17 May 2019 12:46:12 +0100", "Message-Id": "<20190517114613.7027-3-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190517114613.7027-1-bruce.richardson@intel.com>", "References": "<20190503133537.58712-1-bruce.richardson@intel.com>\n\t<20190517114613.7027-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 2/3] examples: remove auto-generation of\n\texamples list", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The examples/meson.build file scanned the filesystem to find all examples\nto build (for examples=all option) and install. However, using run_command\nand scanning the filesystem prevented ninja from properly detecting the\naddition or removal of any examples - one had to recreate the build\ndirectory from scratch to guarantee correct detection of all examples. This\npatch replaces this generated list with a static list of examples, thereby\nallowing proper tracking by ninja/meson, but at the cost of having to\nupdate this file when a new example is added or removed.\n\nThis also fixes an issue with Windows builds, since \"sh\" is not available\nthere.\n\nFixes: 2daf565f91b5 (\"examples: install as part of ninja install\")\n\nCc: stable@dpdk.org\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nAcked-by: Luca Boccassi <bluca@debian.org>\n---\n examples/meson.build | 31 ++++++++++++++++++++++++++++---\n 1 file changed, 28 insertions(+), 3 deletions(-)", "diff": "diff --git a/examples/meson.build b/examples/meson.build\nindex 1a6134f12..8b6577cf7 100644\n--- a/examples/meson.build\n+++ b/examples/meson.build\n@@ -8,9 +8,34 @@ endif\n \n execinfo = cc.find_library('execinfo', required: false)\n \n-all_examples = run_command('sh', '-c',\n-\t'cd $MESON_SOURCE_ROOT/$MESON_SUBDIR && for d in * ; do if [ -d $d ] ; then echo $d ; fi ; done'\n-\t).stdout().split()\n+# list of all example apps. Keep 1-3 per line, in alphabetical order.\n+all_examples = [\n+\t'bbdev_app', 'bond',\n+\t'bpf', 'cmdline',\n+\t'distributor', 'ethtool',\n+\t'eventdev_pipeline', 'exception_path',\n+\t'fips_validation', 'flow_classify',\n+\t'flow_filtering', 'helloworld',\n+\t'ip_fragmentation', 'ip_pipeline',\n+\t'ip_reassembly', 'ipsec-secgw',\n+\t'ipv4_multicast', 'kni',\n+\t'l2fwd', 'l2fwd-cat',\n+\t'l2fwd-crypto', 'l2fwd-jobstats',\n+\t'l2fwd-keepalive', 'l3fwd',\n+\t'l3fwd-acl', 'l3fwd-power',\n+\t'l3fwd-vf', 'link_status_interrupt',\n+\t'load_balancer', 'multi_process',\n+\t'netmap_compat', 'packet_ordering',\n+\t'performance-thread', 'ptpclient',\n+\t'qos_meter', 'qos_sched',\n+\t'quota_watermark', 'rxtx_callbacks',\n+\t'server_node_efd', 'service_cores',\n+\t'skeleton', 'tep_termination',\n+\t'timer', 'vdpa',\n+\t'vhost', 'vhost_crypto',\n+\t'vhost_scsi', 'vm_power_manager',\n+\t'vmdq', 'vmdq_dcb',\n+]\n # install all example code on install - irrespective of whether the example in\n # question is to be built as part of this build or not.\n foreach ex:all_examples\n", "prefixes": [ "v2", "2/3" ] }