Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53500/?format=api
{ "id": 53500, "url": "http://patches.dpdk.org/api/patches/53500/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190516214535.90650-2-shweta.choudaha@gmail.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190516214535.90650-2-shweta.choudaha@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190516214535.90650-2-shweta.choudaha@gmail.com", "date": "2019-05-16T21:45:35", "name": "[1/1] net/e1000: set/clear GO_LINKD bit only if PHY reset is not blocked", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "388f4a5b8f4180618a533d0b8530279ca1cfa645", "submitter": { "id": 881, "url": "http://patches.dpdk.org/api/people/881/?format=api", "name": "Shweta Choudaha", "email": "shweta.choudaha@gmail.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190516214535.90650-2-shweta.choudaha@gmail.com/mbox/", "series": [ { "id": 4701, "url": "http://patches.dpdk.org/api/series/4701/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4701", "date": "2019-05-16T21:45:34", "name": "net/e1000: set/clear GO_LINKD bit only if PHY reset is not blocked", "version": 1, "mbox": "http://patches.dpdk.org/series/4701/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53500/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/53500/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 03D525F0F;\n\tThu, 16 May 2019 23:46:18 +0200 (CEST)", "from mail-wm1-f67.google.com (mail-wm1-f67.google.com\n\t[209.85.128.67]) by dpdk.org (Postfix) with ESMTP id 9197C5F0D;\n\tThu, 16 May 2019 23:46:16 +0200 (CEST)", "by mail-wm1-f67.google.com with SMTP id t5so3519800wmh.3;\n\tThu, 16 May 2019 14:46:16 -0700 (PDT)", "from schoudah-dev.localdomain\n\t(host81-147-150-50.range81-147.btcentralplus.com. [81.147.150.50])\n\tby smtp.gmail.com with ESMTPSA id\n\tz8sm5482869wrs.84.2019.05.16.14.46.15\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 16 May 2019 14:46:15 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=cnqtb8M7hB1UQzfWzLudu6GHzOqV5JDflkp4vnY+8ak=;\n\tb=YMLU0Ksb+83MUSxSj3uPVtm6ItRMjpfMfu7C1OaOxDolFTTMb68z9sNTietEkLawpY\n\t0IsvDzZsL/vN7qa3K41hvPqy0/BdqE+4IFGDzqa1rILtJZLBFoWjtNb+vsnfe0KVxSFQ\n\txHjMLKeEKey1ptwxER6U+FmjYco/Cbiiyb3RxOO49ZHtFuqIjI5ctcIlHKadkkho8LwQ\n\tS4EPmV+tZNvXlZDVxjkvqZ6Ss3LqV/dDpr9TJOleLt0iXrBeQ2RmNZHbOREiMF0p4tjK\n\tPFzhm4cUTExo8FAGwERo3huSL0APZ8FcC9JiHoNFK8nuE859pnbLrcTMU99jwg9MJ4hl\n\tyE/Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=cnqtb8M7hB1UQzfWzLudu6GHzOqV5JDflkp4vnY+8ak=;\n\tb=FVNB0xcomyMV91ZT13N3pCDCZ9ZqPCwsUSi1z8lbZGQPjs80U7Mj+5VhANT2g0J22g\n\tDeN7rZHXb7/sdW7xp4xJAzC0T/r1LsChUE0Wcf6EUUe5PIg9rFqhK1iYhnSgIvQ8asox\n\t6hCp1qLV2zRKjElcZh6cHMWC7nlyMTV7ILwYnJ9oGH++73qog2X0VQwTH0jNLGH0/1b6\n\tdywpJsgjCPkwbGODFJbnDhwDLerB7gX4AvnGEUMl5ma2Wd/eSGqrYfF3CX2RFrupLUbu\n\tStjhiW69h0pm02BM3Bt17rGzgwtpb7aEwsLiQK6G1bX8qi5U4lSdL1qjav5xUnPyAM7W\n\tbNOA==", "X-Gm-Message-State": "APjAAAWnLt/ELuOyLF3t4aU/YPesRYH5AkL5vVZobKmug3qpTjaMvpTW\n\toZwrSS6T8Tsrwy1QhrF/SSOEEhonK5k=", "X-Google-Smtp-Source": "APXvYqxx/Was226iYgTDkNKldKOcReRtachkI0TsWQcFCilwA1Ys8kpeHmSV2/ySEB3myaIqeltN7w==", "X-Received": "by 2002:a1c:f910:: with SMTP id\n\tx16mr3294544wmh.132.1558043176234; \n\tThu, 16 May 2019 14:46:16 -0700 (PDT)", "From": "Shweta Choudaha <shweta.choudaha@gmail.com>", "To": "dev@dpdk.org", "Cc": "wenzhuo.lu@intel.com,\n\tshweta.choudaha@att.com,\n\tstable@dpdk.org", "Date": "Thu, 16 May 2019 22:45:35 +0100", "Message-Id": "<20190516214535.90650-2-shweta.choudaha@gmail.com>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": "<20190516214535.90650-1-shweta.choudaha@gmail.com>", "References": "<20190516214535.90650-1-shweta.choudaha@gmail.com>", "Subject": "[dpdk-dev] [PATCH 1/1] net/e1000: set/clear GO_LINKD bit only if\n\tPHY reset is not blocked", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Shweta Choudaha <shweta.choudaha@att.com>\n\nWhen PHY reset is blocked as is the case when BMC is connected via NC-SI\ndo not set GO_LINKD bit in PHY power management register in dev_stop as\nthis will disconnect the PHY. Also, in dev_close clear the GO_LINKD\nbit only if PHY reset is not blocked\n\nFixes: 3af34dec0b41 (\"igb: force phy power up/down\")\nCC: stable@dpdk.org\n\nSigned-off-by: Shweta Choudaha <shweta.choudaha@att.com>\n---\n drivers/net/e1000/igb_ethdev.c | 11 +++++++----\n 1 file changed, 7 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c\nindex d3a8f5bf4..d0de15531 100644\n--- a/drivers/net/e1000/igb_ethdev.c\n+++ b/drivers/net/e1000/igb_ethdev.c\n@@ -1515,8 +1515,10 @@ eth_igb_stop(struct rte_eth_dev *dev)\n \tigb_pf_reset_hw(hw);\n \tE1000_WRITE_REG(hw, E1000_WUC, 0);\n \n-\t/* Set bit for Go Link disconnect */\n-\tif (hw->mac.type >= e1000_82580) {\n+\n+\t/* Set bit for Go Link disconnect if PHY reset is not blocked */\n+\tif ((hw->mac.type >= e1000_82580) &&\n+\t (e1000_check_reset_block(hw) != E1000_BLK_PHY_RESET)) {\n \t\tuint32_t phpm_reg;\n \n \t\tphpm_reg = E1000_READ_REG(hw, E1000_82580_PHY_POWER_MGMT);\n@@ -1590,8 +1592,9 @@ eth_igb_close(struct rte_eth_dev *dev)\n \tigb_release_manageability(hw);\n \tigb_hw_control_release(hw);\n \n-\t/* Clear bit for Go Link disconnect */\n-\tif (hw->mac.type >= e1000_82580) {\n+\t/* Clear bit for Go Link disconnect if PHY reset is not blocked */\n+\tif ((hw->mac.type >= e1000_82580) &&\n+\t (e1000_check_reset_block(hw) != E1000_BLK_PHY_RESET)) {\n \t\tuint32_t phpm_reg;\n \n \t\tphpm_reg = E1000_READ_REG(hw, E1000_82580_PHY_POWER_MGMT);\n", "prefixes": [ "1/1" ] }