Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53495/?format=api
{ "id": 53495, "url": "http://patches.dpdk.org/api/patches/53495/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190516180427.17270-6-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190516180427.17270-6-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190516180427.17270-6-stephen@networkplumber.org", "date": "2019-05-16T18:04:25", "name": "[v2,5/7] ethdev: use eth_unformat_addr", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b9146160ff5132216411d12ea6fe04cb94ec5745", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190516180427.17270-6-stephen@networkplumber.org/mbox/", "series": [ { "id": 4699, "url": "http://patches.dpdk.org/api/series/4699/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4699", "date": "2019-05-16T18:04:20", "name": "ether: improvements and optimizations", "version": 2, "mbox": "http://patches.dpdk.org/series/4699/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53495/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/53495/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A0E4F1B101;\n\tThu, 16 May 2019 20:04:48 +0200 (CEST)", "from mail-pl1-f195.google.com (mail-pl1-f195.google.com\n\t[209.85.214.195]) by dpdk.org (Postfix) with ESMTP id C92AFD1A3\n\tfor <dev@dpdk.org>; Thu, 16 May 2019 20:04:42 +0200 (CEST)", "by mail-pl1-f195.google.com with SMTP id p15so2009725pll.4\n\tfor <dev@dpdk.org>; Thu, 16 May 2019 11:04:42 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\td67sm9376657pfa.35.2019.05.16.11.04.40\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 16 May 2019 11:04:40 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=yEaUpni5y7fsJISN4fFRnplwP0jzhBCZ/6W1TUBjg94=;\n\tb=MCFRyyyRC8n69pkn93mKpo81IyF66f4iBJB7gf+n/yD2r+EWs6lv8g27P6uhaSOl/B\n\tsATdP1vOLPAHL9sUaXngYG8XmMCByOkbGW9HYAR+QtzWyIe0ld5ed8lcPjEaX/Q93ElW\n\tX8XSrwTSv5Q4lNDSwB+fplDGQ2KNIFLa5X0p2N6/1IvyKqWwVRfAp9WKpJ4nlyaBjnsH\n\tSCalJTUTVCCetAydIkD6F1seSXZ4YzBJH+yfG+ZpFdw3XcL8Z6TIw8zN8D6d0j4nXtTZ\n\tq7D4Z5PtEGeWXZSfCYJLT2RHmBKCO4nLnYHd6pqPz9xWXx53C5xLsTsIcSL8ZgsZc2P3\n\tmGFg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=yEaUpni5y7fsJISN4fFRnplwP0jzhBCZ/6W1TUBjg94=;\n\tb=EbYjf3uSRy+pFGHs5nMQD9K0dgCUNLFqrpQP2Dxz3AaRUbVpCRozduK6JPKwhtZKtW\n\t7bRmovYgODq4ExxhcxP6PJzPEatDR0eETubg+gIIWtZiErxoDTnah17vGAJszsywDjQi\n\t+NrAYzYze3i640n6LCb3b6uEk4ikFQtxeBOGpkXIJihuyz2Ma1QZgV/wZnsj8Dxhfb5q\n\tS9JOjhKPm6X/PTOQ+/PvR1hw3YCGDQcfH/ceMiTCDOSFvAhAcJY94gAJGBP5HagTcXko\n\tK0hshbMyUYIY0qBCoD7PJsQN+p9oCVazQof1HM7aOWWQzoXiiXxLgVZUAGt19hHmnJPg\n\tGTLA==", "X-Gm-Message-State": "APjAAAUs5phuCjSHOh27xwENbuhrPzSYBNlxvtlYOjrF1ok+QSUssNBy\n\tlaKgPp4G9p/WNBEWF0pwVFK6xL+I5n8=", "X-Google-Smtp-Source": "APXvYqyMGWP9dp85sCz1FSHq+1MfZ9NgW5y82tJkZ/mE7hI26ckWI8uyXsOot6FQErKTHJroZ+Wesw==", "X-Received": "by 2002:a17:902:b18c:: with SMTP id\n\ts12mr33231259plr.181.1558029881695; \n\tThu, 16 May 2019 11:04:41 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Thu, 16 May 2019 11:04:25 -0700", "Message-Id": "<20190516180427.17270-6-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190516180427.17270-1-stephen@networkplumber.org>", "References": "<20190516180427.17270-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 5/7] ethdev: use eth_unformat_addr", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Use eth_unformat_addr, so that ethdev can be built and work\nwithout the cmdline library. The dependency on cmdline was\nan arrangement of convenience anyway.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/Makefile | 1 -\n lib/librte_ethdev/Makefile | 2 +-\n lib/librte_ethdev/meson.build | 2 +-\n lib/librte_ethdev/rte_class_eth.c | 9 +--------\n 4 files changed, 3 insertions(+), 11 deletions(-)", "diff": "diff --git a/lib/Makefile b/lib/Makefile\nindex 791e0d9911d6..82b2c4bfa8ea 100644\n--- a/lib/Makefile\n+++ b/lib/Makefile\n@@ -25,7 +25,6 @@ DIRS-$(CONFIG_RTE_LIBRTE_ETHER) += librte_ethdev\n DEPDIRS-librte_ethdev := librte_net librte_eal librte_mempool librte_ring\n DEPDIRS-librte_ethdev += librte_mbuf\n DEPDIRS-librte_ethdev += librte_kvargs\n-DEPDIRS-librte_ethdev += librte_cmdline\n DEPDIRS-librte_ethdev += librte_meter\n DIRS-$(CONFIG_RTE_LIBRTE_BBDEV) += librte_bbdev\n DEPDIRS-librte_bbdev := librte_eal librte_mempool librte_mbuf\ndiff --git a/lib/librte_ethdev/Makefile b/lib/librte_ethdev/Makefile\nindex 8d4a02630c4f..60bcc2227878 100644\n--- a/lib/librte_ethdev/Makefile\n+++ b/lib/librte_ethdev/Makefile\n@@ -12,7 +12,7 @@ CFLAGS += -DALLOW_EXPERIMENTAL_API\n CFLAGS += -O3\n CFLAGS += $(WERROR_FLAGS)\n LDLIBS += -lrte_net -lrte_eal -lrte_mempool -lrte_ring\n-LDLIBS += -lrte_mbuf -lrte_kvargs -lrte_cmdline -lrte_meter\n+LDLIBS += -lrte_mbuf -lrte_kvargs -lrte_meter\n \n EXPORT_MAP := rte_ethdev_version.map\n \ndiff --git a/lib/librte_ethdev/meson.build b/lib/librte_ethdev/meson.build\nindex 8d6165b2a7dd..f75d428c96d0 100644\n--- a/lib/librte_ethdev/meson.build\n+++ b/lib/librte_ethdev/meson.build\n@@ -26,4 +26,4 @@ headers = files('rte_ethdev.h',\n \t'rte_tm.h',\n \t'rte_tm_driver.h')\n \n-deps += ['net', 'kvargs', 'cmdline', 'meter']\n+deps += ['net', 'kvargs', 'meter']\ndiff --git a/lib/librte_ethdev/rte_class_eth.c b/lib/librte_ethdev/rte_class_eth.c\nindex cb99c92ece93..40ca936230c6 100644\n--- a/lib/librte_ethdev/rte_class_eth.c\n+++ b/lib/librte_ethdev/rte_class_eth.c\n@@ -4,7 +4,6 @@\n \n #include <string.h>\n \n-#include <cmdline_parse_etheraddr.h>\n #include <rte_class.h>\n #include <rte_compat.h>\n #include <rte_errno.h>\n@@ -43,19 +42,13 @@ static int\n eth_mac_cmp(const char *key __rte_unused,\n \t\tconst char *value, void *opaque)\n {\n-\tint ret;\n \tstruct ether_addr mac;\n \tconst struct rte_eth_dev_data *data = opaque;\n \tstruct rte_eth_dev_info dev_info;\n \tuint32_t index;\n \n \t/* Parse devargs MAC address. */\n-\t/*\n-\t * cannot use ether_aton_r(value, &mac)\n-\t * because of include conflict with rte_ether.h\n-\t */\n-\tret = cmdline_parse_etheraddr(NULL, value, &mac, sizeof(mac));\n-\tif (ret < 0)\n+\tif (ether_unformat_addr(value, &mac) < 0)\n \t\treturn -1; /* invalid devargs value */\n \n \t/* Return 0 if devargs MAC is matching one of the device MACs. */\n", "prefixes": [ "v2", "5/7" ] }