Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53461/?format=api
http://patches.dpdk.org/api/patches/53461/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1557980885-183777-4-git-send-email-mesut.a.ergin@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1557980885-183777-4-git-send-email-mesut.a.ergin@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1557980885-183777-4-git-send-email-mesut.a.ergin@intel.com", "date": "2019-05-16T04:28:05", "name": "[3/3] net/i40e: fix inadvertent override of vector RX allowance", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "fa5bd179b5c93217265d55020dee734590251ca2", "submitter": { "id": 455, "url": "http://patches.dpdk.org/api/people/455/?format=api", "name": "Ergin, Mesut A", "email": "mesut.a.ergin@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1557980885-183777-4-git-send-email-mesut.a.ergin@intel.com/mbox/", "series": [ { "id": 4685, "url": "http://patches.dpdk.org/api/series/4685/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4685", "date": "2019-05-16T04:28:02", "name": "net/i40e: improve rte_flow offload with MARK + RSS", "version": 1, "mbox": "http://patches.dpdk.org/series/4685/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53461/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/53461/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 136915F1A;\n\tThu, 16 May 2019 06:28:33 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 33495326C\n\tfor <dev@dpdk.org>; Thu, 16 May 2019 06:28:26 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t15 May 2019 21:28:23 -0700", "from skx-pink.jf.intel.com ([10.54.80.236])\n\tby orsmga001.jf.intel.com with ESMTP; 15 May 2019 21:28:23 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Mesut Ali Ergin <mesut.a.ergin@intel.com>", "To": "beilei.xing@intel.com,\n\tqi.z.zhang@intel.com", "Cc": "dev@dpdk.org,\n\tMesut Ali Ergin <mesut.a.ergin@intel.com>", "Date": "Wed, 15 May 2019 21:28:05 -0700", "Message-Id": "<1557980885-183777-4-git-send-email-mesut.a.ergin@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1557980885-183777-1-git-send-email-mesut.a.ergin@intel.com>", "References": "<1557980885-183777-1-git-send-email-mesut.a.ergin@intel.com>", "Subject": "[dpdk-dev] [PATCH 3/3] net/i40e: fix inadvertent override of vector\n\tRX allowance", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When i40e_rx_vec_dev_conf_condition_check_default() determines whether\nvector receive functions would be allowed during initialization phase,\nit should honor previously recorded disallowance during configuration\nphase, and not override simply because it is for the first queue.\n\nSigned-off-by: Mesut Ali Ergin <mesut.a.ergin@intel.com>\n---\n drivers/net/i40e/i40e_rxtx_vec_common.h | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h b/drivers/net/i40e/i40e_rxtx_vec_common.h\nindex 0e6ffa0..f30cab4 100644\n--- a/drivers/net/i40e/i40e_rxtx_vec_common.h\n+++ b/drivers/net/i40e/i40e_rxtx_vec_common.h\n@@ -212,6 +212,10 @@ i40e_rx_vec_dev_conf_condition_check_default(struct rte_eth_dev *dev)\n \tif (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_EXTEND)\n \t\treturn -1;\n \n+\t/* Should not override if vector was already disallowed */\n+\tif (!ad->rx_vec_allowed)\n+\treturn -1;\n+\n \t/**\n \t * Vector mode is allowed only when number of Rx queue\n \t * descriptor is power of 2.\n", "prefixes": [ "3/3" ] }{ "id": 53461, "url": "