Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53459/?format=api
{ "id": 53459, "url": "http://patches.dpdk.org/api/patches/53459/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1557980885-183777-2-git-send-email-mesut.a.ergin@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1557980885-183777-2-git-send-email-mesut.a.ergin@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1557980885-183777-2-git-send-email-mesut.a.ergin@intel.com", "date": "2019-05-16T04:28:03", "name": "[1/3] net/i40e: add support for MARK + RSS action in rte_flow", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c1d20a5ea49e5ce65d70c66ae39b80736ffd06b9", "submitter": { "id": 455, "url": "http://patches.dpdk.org/api/people/455/?format=api", "name": "Ergin, Mesut A", "email": "mesut.a.ergin@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1557980885-183777-2-git-send-email-mesut.a.ergin@intel.com/mbox/", "series": [ { "id": 4685, "url": "http://patches.dpdk.org/api/series/4685/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4685", "date": "2019-05-16T04:28:02", "name": "net/i40e: improve rte_flow offload with MARK + RSS", "version": 1, "mbox": "http://patches.dpdk.org/series/4685/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53459/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/53459/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6517A5920;\n\tThu, 16 May 2019 06:28:29 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 657912F7D\n\tfor <dev@dpdk.org>; Thu, 16 May 2019 06:28:25 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t15 May 2019 21:28:23 -0700", "from skx-pink.jf.intel.com ([10.54.80.236])\n\tby orsmga001.jf.intel.com with ESMTP; 15 May 2019 21:28:23 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Mesut Ali Ergin <mesut.a.ergin@intel.com>", "To": "beilei.xing@intel.com,\n\tqi.z.zhang@intel.com", "Cc": "dev@dpdk.org,\n\tMesut Ali Ergin <mesut.a.ergin@intel.com>", "Date": "Wed, 15 May 2019 21:28:03 -0700", "Message-Id": "<1557980885-183777-2-git-send-email-mesut.a.ergin@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1557980885-183777-1-git-send-email-mesut.a.ergin@intel.com>", "References": "<1557980885-183777-1-git-send-email-mesut.a.ergin@intel.com>", "Subject": "[dpdk-dev] [PATCH 1/3] net/i40e: add support for MARK + RSS action\n\tin rte_flow", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently, i40e Flow Director action parser only allows following nine\naction combinations: (QUEUE, PASSTHRU, DROP, QUEUE + MARK, PASSTHRU +\nMARK, DROP + MARK, QUEUE + FLAG, PASSTHRU + FLAG, DROP + FLAG)\n\nUsing the existing Cloud Filter profile on the NIC, it is possible to\nadd support for two more combinations as: (MARK + RSS, MARK + FLAG +\nRSS)\n\nAddition of these new combinations would allow more applications to\nutilize DPDK rte_flow to implement hardware flow offloads with Intel\nEthernet 700 series network adapters, including but not limited to the\nexisting OVS DPDK partial hardware flow offload feature.\n\nSigned-off-by: Mesut Ali Ergin <mesut.a.ergin@intel.com>\n---\n drivers/net/i40e/i40e_flow.c | 29 +++++++++++++++++++++++++++++\n 1 file changed, 29 insertions(+)", "diff": "diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c\nindex 5447e4e..d4d564f 100644\n--- a/drivers/net/i40e/i40e_flow.c\n+++ b/drivers/net/i40e/i40e_flow.c\n@@ -3078,6 +3078,12 @@ i40e_flow_parse_fdir_action(struct rte_eth_dev *dev,\n \tcase RTE_FLOW_ACTION_TYPE_PASSTHRU:\n \t\tfilter->action.behavior = I40E_FDIR_PASSTHRU;\n \t\tbreak;\n+\tcase RTE_FLOW_ACTION_TYPE_MARK:\n+\t\tfilter->action.behavior = I40E_FDIR_PASSTHRU;\n+\t\tmark_spec = act->conf;\n+\t\tfilter->action.report_status = I40E_FDIR_REPORT_ID;\n+\t\tfilter->soft_id = mark_spec->id;\n+\tbreak;\n \tdefault:\n \t\trte_flow_error_set(error, EINVAL,\n \t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION, act,\n@@ -3090,13 +3096,36 @@ i40e_flow_parse_fdir_action(struct rte_eth_dev *dev,\n \tNEXT_ITEM_OF_ACTION(act, actions, index);\n \tswitch (act->type) {\n \tcase RTE_FLOW_ACTION_TYPE_MARK:\n+\t\tif (!mark_spec) {\n+\t\t\t/* Double MARK actions requested */\n+\t\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t RTE_FLOW_ERROR_TYPE_ACTION, act,\n+\t\t\t \"Invalid action.\");\n+\t\t\treturn -rte_errno;\n+\t\t}\n \t\tmark_spec = act->conf;\n \t\tfilter->action.report_status = I40E_FDIR_REPORT_ID;\n \t\tfilter->soft_id = mark_spec->id;\n \t\tbreak;\n \tcase RTE_FLOW_ACTION_TYPE_FLAG:\n+\t\tif (!mark_spec) {\n+\t\t\t/* MARK + FLAG not supported */\n+\t\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION, act,\n+\t\t\t\t\t \"Invalid action.\");\n+\t\t\treturn -rte_errno;\n+\t\t}\n \t\tfilter->action.report_status = I40E_FDIR_NO_REPORT_STATUS;\n \t\tbreak;\n+\tcase RTE_FLOW_ACTION_TYPE_RSS:\n+\t\tif (filter->action.behavior != I40E_FDIR_PASSTHRU) {\n+\t\t\t/* RSS filter won't be next if FDIR did not pass thru */\n+\t\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION, act,\n+\t\t\t\t\t \"Invalid action.\");\n+\t\t\treturn -rte_errno;\n+\t\t}\n+\t\tbreak;\n \tcase RTE_FLOW_ACTION_TYPE_END:\n \t\treturn 0;\n \tdefault:\n", "prefixes": [ "1/3" ] }