Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53454/?format=api
{ "id": 53454, "url": "http://patches.dpdk.org/api/patches/53454/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190515221952.21959-5-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190515221952.21959-5-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190515221952.21959-5-stephen@networkplumber.org", "date": "2019-05-15T22:19:52", "name": "[RFC,4/4] net/ether: use bitops to speedup comparison", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4dd6db6a299e79a56f017ad46f4f43c2fda42489", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190515221952.21959-5-stephen@networkplumber.org/mbox/", "series": [ { "id": 4681, "url": "http://patches.dpdk.org/api/series/4681/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4681", "date": "2019-05-15T22:19:48", "name": "net/ether: improvements", "version": 1, "mbox": "http://patches.dpdk.org/series/4681/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53454/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/53454/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3AE885F34;\n\tThu, 16 May 2019 00:20:10 +0200 (CEST)", "from mail-pg1-f180.google.com (mail-pg1-f180.google.com\n\t[209.85.215.180]) by dpdk.org (Postfix) with ESMTP id 2E5955F1C\n\tfor <dev@dpdk.org>; Thu, 16 May 2019 00:20:06 +0200 (CEST)", "by mail-pg1-f180.google.com with SMTP id t187so459263pgb.13\n\tfor <dev@dpdk.org>; Wed, 15 May 2019 15:20:06 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\td5sm3549964pgb.33.2019.05.15.15.20.04\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 15 May 2019 15:20:04 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=usySncatsxV2VcU8J+VYqa3cdTtdmtHu06jkvUhvS04=;\n\tb=Y/vfVpHeN8TDoC+xF/c/458NwxocPHgUZWIhw23dUF2TFz+v47WBRTH//eWg+PN6zg\n\t9a3Vo4fkFWdIfwLa6ff4kLBNQH75f3c4aVo8lNHQgHAqwHw2wVijE4BmeLBeGCtiYdf6\n\thtxM02vDnZIt53RihUVzlxVCcXkiGT7VVXchgwKjfyKVxv+VcxcLZZzfSDTPu7uH6Hwd\n\tOMB++dd/BGJmp7M/X5iLo1FudtrqQ346yH2pdtgWWZZMrmccMDJbNEAN1LyOwujGzIen\n\tVAO7AJFQgVTYIP47wlga6BuNW5z/WxdAJSOnEndgGR7V6jmXfH1PnITV25ZxxDsinwMj\n\tdfmQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=usySncatsxV2VcU8J+VYqa3cdTtdmtHu06jkvUhvS04=;\n\tb=KSu4UGmd5DtQuzDEtwWvGEXF3RidS4CQPCjxaoTwPNC/CGPB4/ehd7CUBHqrG/26gA\n\tXoUNHjoHTAdy4XR9QhJIrkhjCybxnUGj0JMOKMxornTcvX4H+0BH5vHu2I4A9aRw0Yu4\n\tmH0ncPKIOl3ZOJQw0r9LzFRXfUH2uojmk0ZxiNvPBLgAwPaH12LYYr7coPJZ0lK6E4vm\n\tfxYWxoaGLS5pxPckx7prgd3YDyBeRwhaDla2+5l5SQG5Ph/bGQFBXC7ysoiAYuCYBnhP\n\t3A2MLlgRsdp+9MuI2AJZbIzuikFgLZ8R/AjnMk+Q3QNqITWhM9GtN7DyecLFIifqUPtM\n\tjyvw==", "X-Gm-Message-State": "APjAAAU0iE6TmTKlnGUfVeAFFngN5xHP2t6MpM0/B68HeQ+oxG/88Un3\n\tRgwYIua5lSMUokMfPzyzz+J+k87aLUY=", "X-Google-Smtp-Source": "APXvYqzgjJ/WkrQMiS6AeLu6qwDmZ0JESuuaqHHJygQCr0RIPuEB69tyMFsmgBfMuR332leESJQcLw==", "X-Received": "by 2002:a63:6ac1:: with SMTP id\n\tf184mr47439282pgc.25.1557958805080; \n\tWed, 15 May 2019 15:20:05 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Wed, 15 May 2019 15:19:52 -0700", "Message-Id": "<20190515221952.21959-5-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190515221952.21959-1-stephen@networkplumber.org>", "References": "<20190515221952.21959-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [RFC 4/4] net/ether: use bitops to speedup comparison", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Using bit operations like or and xor is faster than a loop\non all architectures. Really just explicit unrolling.\n\nSimilar cast to uint16 unaligned is already done in\nother functions here.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/librte_net/rte_ether.h | 17 +++++++----------\n 1 file changed, 7 insertions(+), 10 deletions(-)", "diff": "diff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h\nindex b94e64b2195e..5d9242cda230 100644\n--- a/lib/librte_net/rte_ether.h\n+++ b/lib/librte_net/rte_ether.h\n@@ -78,11 +78,10 @@ struct ether_addr {\n static inline int is_same_ether_addr(const struct ether_addr *ea1,\n \t\t\t\t const struct ether_addr *ea2)\n {\n-\tint i;\n-\tfor (i = 0; i < ETHER_ADDR_LEN; i++)\n-\t\tif (ea1->addr_bytes[i] != ea2->addr_bytes[i])\n-\t\t\treturn 0;\n-\treturn 1;\n+\tconst unaligned_uint16_t *w1 = (const uint16_t *)ea1;\n+\tconst unaligned_uint16_t *w2 = (const uint16_t *)ea2;\n+\n+\treturn ((w1[0] ^ w2[0]) | (w1[1] ^ w2[1]) | (w1[2] ^ w2[2])) == 0;\n }\n \n /**\n@@ -97,11 +96,9 @@ static inline int is_same_ether_addr(const struct ether_addr *ea1,\n */\n static inline int is_zero_ether_addr(const struct ether_addr *ea)\n {\n-\tint i;\n-\tfor (i = 0; i < ETHER_ADDR_LEN; i++)\n-\t\tif (ea->addr_bytes[i] != 0x00)\n-\t\t\treturn 0;\n-\treturn 1;\n+\tconst unaligned_uint16_t *w = (const uint16_t *)ea;\n+\n+\treturn (w[0] | w[1] | w[2]) == 0;\n }\n \n /**\n", "prefixes": [ "RFC", "4/4" ] }