Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 53453,
    "url": "http://patches.dpdk.org/api/patches/53453/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190515221952.21959-4-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190515221952.21959-4-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190515221952.21959-4-stephen@networkplumber.org",
    "date": "2019-05-15T22:19:51",
    "name": "[RFC,3/4] ethdev: use eth_unformat_addr",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "f0a3aa3546bf278b637c82f836f54f0d9784bc8f",
    "submitter": {
        "id": 27,
        "url": "http://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190515221952.21959-4-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 4681,
            "url": "http://patches.dpdk.org/api/series/4681/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4681",
            "date": "2019-05-15T22:19:48",
            "name": "net/ether: improvements",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/4681/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/53453/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/53453/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A4AF25F2A;\n\tThu, 16 May 2019 00:20:08 +0200 (CEST)",
            "from mail-pf1-f196.google.com (mail-pf1-f196.google.com\n\t[209.85.210.196]) by dpdk.org (Postfix) with ESMTP id 117165F14\n\tfor <dev@dpdk.org>; Thu, 16 May 2019 00:20:05 +0200 (CEST)",
            "by mail-pf1-f196.google.com with SMTP id y11so672624pfm.13\n\tfor <dev@dpdk.org>; Wed, 15 May 2019 15:20:04 -0700 (PDT)",
            "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\td5sm3549964pgb.33.2019.05.15.15.20.02\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 15 May 2019 15:20:03 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=V6S4SrZPKD5RhbdoJ6Quu9gqFutejpSzCG3N29qiz80=;\n\tb=kAoHjGYkC6VbUkLCJ4uMDkBYwD4CALOG1mlz5jTyEPVNdGeh1qo2OAaLXcMCu7EKZl\n\tH9iTbFjaBmjyiOTuZwVaV/1fIz7R6oQo3L+94Ke2of5CmWEoIYwRGTfcfXiNODKKcUOV\n\tUy/5a29Tzrs7zJt5F+5s5o6ixI6vdeSWaZ1eUXdzd5otqXXbTjzYBcp0rTIIR/Ww1zkz\n\tvUTDdJPntjdOIIdCfeHPG0jDrtq531gpXoq3Wc4OjcAASFAgd3lDdxXVcxe35A7kslau\n\tEnU2yhdh9bmdsHlLI6yJ7bgIirssaFCqjJOeY5RX4Vs3pUfumEqgUJ7KWJIT+9b+SPoM\n\tVIPw==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=V6S4SrZPKD5RhbdoJ6Quu9gqFutejpSzCG3N29qiz80=;\n\tb=MifcX428UBh1XD9sFL+j+F3koYDYnZY7QIaRmu109WSX6EHy37Bbl67qmmxNS6tjSP\n\t3eWOAo3x+P8FrkHi09IThrib/5zTrwcLzteoSEwacT56XpjVIf1WhCW1eX3caWL/7qci\n\tsEg+8euD+taWN2MqLjWjGGB1mGKp0w6dHmvn9nkzmgW2kq8g6bGS+xBBvqbXTbfZNftl\n\t5sSf+sCSq2R6FgUznzvf+twe/uASR+cYAWKsTRo3NNjDHUpxpfwSKiBQddMHefJHLh2W\n\t+vf26osC6rX8qzgkcopBiu0Ak5tBumKX/0MC8ufl5Wg43vvKnwfH/Y6KonGdT6pWT6V1\n\tk2gw==",
        "X-Gm-Message-State": "APjAAAUnK6PPfuvMRaOAltSSne5qctX/BCLM/Y7YeyB1ymEbWWj4Mdn6\n\tf9OocHuDEN480xdxnyB7e426ivU/qG4=",
        "X-Google-Smtp-Source": "APXvYqx5X+zYWL0LljNhQKKY7IBLaIeEUpNLkcfKUbEPKQtrhKPxvrud2hN/xZ5ZAACRaM2DYO5f1w==",
        "X-Received": "by 2002:a63:4a66:: with SMTP id\n\tj38mr27552446pgl.199.1557958803996; \n\tWed, 15 May 2019 15:20:03 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>",
        "Date": "Wed, 15 May 2019 15:19:51 -0700",
        "Message-Id": "<20190515221952.21959-4-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.20.1",
        "In-Reply-To": "<20190515221952.21959-1-stephen@networkplumber.org>",
        "References": "<20190515221952.21959-1-stephen@networkplumber.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [RFC 3/4] ethdev: use eth_unformat_addr",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Use eth_unformat_addr, so that ethdev can be built and work\nwithout the cmdline library. The dependency on cmdline was\nan arrangement of convenience anyway.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/librte_ethdev/rte_class_eth.c | 9 +--------\n 1 file changed, 1 insertion(+), 8 deletions(-)",
    "diff": "diff --git a/lib/librte_ethdev/rte_class_eth.c b/lib/librte_ethdev/rte_class_eth.c\nindex cb99c92ece93..40ca936230c6 100644\n--- a/lib/librte_ethdev/rte_class_eth.c\n+++ b/lib/librte_ethdev/rte_class_eth.c\n@@ -4,7 +4,6 @@\n \n #include <string.h>\n \n-#include <cmdline_parse_etheraddr.h>\n #include <rte_class.h>\n #include <rte_compat.h>\n #include <rte_errno.h>\n@@ -43,19 +42,13 @@ static int\n eth_mac_cmp(const char *key __rte_unused,\n \t\tconst char *value, void *opaque)\n {\n-\tint ret;\n \tstruct ether_addr mac;\n \tconst struct rte_eth_dev_data *data = opaque;\n \tstruct rte_eth_dev_info dev_info;\n \tuint32_t index;\n \n \t/* Parse devargs MAC address. */\n-\t/*\n-\t * cannot use ether_aton_r(value, &mac)\n-\t * because of include conflict with rte_ether.h\n-\t */\n-\tret = cmdline_parse_etheraddr(NULL, value, &mac, sizeof(mac));\n-\tif (ret < 0)\n+\tif (ether_unformat_addr(value, &mac) < 0)\n \t\treturn -1; /* invalid devargs value */\n \n \t/* Return 0 if devargs MAC is matching one of the device MACs. */\n",
    "prefixes": [
        "RFC",
        "3/4"
    ]
}