Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 53451,
    "url": "http://patches.dpdk.org/api/patches/53451/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190515221952.21959-2-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190515221952.21959-2-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190515221952.21959-2-stephen@networkplumber.org",
    "date": "2019-05-15T22:19:49",
    "name": "[RFC,1/4] net/ether: deinline non-critical functions",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "418e0ea8ef0fabb9103e0b8ede2acaca0f3145b4",
    "submitter": {
        "id": 27,
        "url": "http://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190515221952.21959-2-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 4681,
            "url": "http://patches.dpdk.org/api/series/4681/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4681",
            "date": "2019-05-15T22:19:48",
            "name": "net/ether: improvements",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/4681/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/53451/comments/",
    "check": "warning",
    "checks": "http://patches.dpdk.org/api/patches/53451/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6F7475F1B;\n\tThu, 16 May 2019 00:20:05 +0200 (CEST)",
            "from mail-pl1-f195.google.com (mail-pl1-f195.google.com\n\t[209.85.214.195]) by dpdk.org (Postfix) with ESMTP id 1A49A5B1E\n\tfor <dev@dpdk.org>; Thu, 16 May 2019 00:20:01 +0200 (CEST)",
            "by mail-pl1-f195.google.com with SMTP id g5so543578plt.2\n\tfor <dev@dpdk.org>; Wed, 15 May 2019 15:20:01 -0700 (PDT)",
            "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\td5sm3549964pgb.33.2019.05.15.15.19.59\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 15 May 2019 15:19:59 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=ZWNZHay0xN3T3JMmVhQZ41r8L5iCV64FZ7UGs4mBQdk=;\n\tb=YrUmEgWaVra5y/1M+QyDIjF2pWc2uUh9la2jmJk181zm57j4HjDUWjZm3IDLY42QT+\n\tw+9qSsvhDKIlG7baXEeLzGeqAPXHe/RumXPLJDC7wgqusTV7HrmKmda3uJJp5dOkbD9U\n\t7g2g6uAuZ2mQblwpB74UJFrg3CwalWGpQ/T7qvIhbIF5nHbf503LzmfWW3IZnHyOutya\n\tuBx0COOWNUDXo3SzsqwtPJ4KW28y70xoZzpb6RSpCu6z+b7hAFua5L7inD6iCmk9GVEg\n\tq49sgNAhvwASF32vWrIYkh+xu7es2rito61jOM592y3WD0PY0+a09Pls2eoQ2a7IOhm6\n\tKBkA==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=ZWNZHay0xN3T3JMmVhQZ41r8L5iCV64FZ7UGs4mBQdk=;\n\tb=VCt0opPfLdfwcqT7ynMB5KdeRJSxqjDsASrG+I6pIouCEMT8zS76f6Atm06VtYmc+a\n\tiuWEvw188ba/k7gc4aLphtpj0zSeKrT98Yin9CGfAVDfv/GsPwmZs0oHB5BWw3K8x+u6\n\tUXXr94K4F2w9x/YSdhJV9Epw7JYOac3aRfis1YC2/ilg0Pixcx2ZKUxpFLXR3Ys4Jo5N\n\tbPtOBK4C1aqLo/V9fEPUkxyPDgQa5ZTZbHBbjenBrpWGfYhnipz+SqHYN0P2PfeIxnI8\n\tnTqewRqA9MZTuHndIreU/yfCRvzvtVjemh0gFeK4K2A01ZXfDBfJO0m4FkRW5hN7DKRe\n\t5Ktg==",
        "X-Gm-Message-State": "APjAAAWQbswO7PND54n6i3NaZtYu1muMUFIe1lXKYrT0OBmpuxcNjjY3\n\tIzcOptTrMLv4BUpCaczcm/TYpU6KAbc=",
        "X-Google-Smtp-Source": "APXvYqx5AHmyGc8FDiUVXRiQXpUy40FLgR7dno1rU7dLv5bVSn/PPSuyuDVpL0EXkoJ1p2kmsqzx5g==",
        "X-Received": "by 2002:a17:902:ca:: with SMTP id\n\ta68mr21023752pla.7.1557958800345; \n\tWed, 15 May 2019 15:20:00 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>",
        "Date": "Wed, 15 May 2019 15:19:49 -0700",
        "Message-Id": "<20190515221952.21959-2-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.20.1",
        "In-Reply-To": "<20190515221952.21959-1-stephen@networkplumber.org>",
        "References": "<20190515221952.21959-1-stephen@networkplumber.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [RFC 1/4] net/ether: deinline non-critical functions",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Formatting ethernet address and getting a random value are\nnot in critical path so they should not be inlined.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/librte_net/Makefile            |  1 +\n lib/librte_net/rte_ether.c         | 29 +++++++++++++++++++++++++++++\n lib/librte_net/rte_ether.h         | 24 ++++--------------------\n lib/librte_net/rte_net_version.map |  8 ++++++++\n 4 files changed, 42 insertions(+), 20 deletions(-)\n create mode 100644 lib/librte_net/rte_ether.c",
    "diff": "diff --git a/lib/librte_net/Makefile b/lib/librte_net/Makefile\nindex c3082069ab50..f68b42cd0e8f 100644\n--- a/lib/librte_net/Makefile\n+++ b/lib/librte_net/Makefile\n@@ -14,6 +14,7 @@ LIBABIVER := 1\n \n SRCS-$(CONFIG_RTE_LIBRTE_NET) := rte_net.c\n SRCS-$(CONFIG_RTE_LIBRTE_NET) += rte_net_crc.c\n+SRCS-$(CONFIG_RTE_LIBRTE_NET) := rte_ether.c\n SRCS-$(CONFIG_RTE_LIBRTE_NET) += rte_arp.c\n \n # install includes\ndiff --git a/lib/librte_net/rte_ether.c b/lib/librte_net/rte_ether.c\nnew file mode 100644\nindex 000000000000..d4b41f122a16\n--- /dev/null\n+++ b/lib/librte_net/rte_ether.c\n@@ -0,0 +1,29 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2010-2014 Intel Corporation\n+ */\n+\n+#include <rte_ether.h>\n+\n+void\n+eth_random_addr(uint8_t *addr)\n+{\n+\tuint64_t rand = rte_rand();\n+\tuint8_t *p = (uint8_t *)&rand;\n+\n+\trte_memcpy(addr, p, ETHER_ADDR_LEN);\n+\taddr[0] &= (uint8_t)~ETHER_GROUP_ADDR;\t/* clear multicast bit */\n+\taddr[0] |= ETHER_LOCAL_ADMIN_ADDR;\t/* set local assignment bit */\n+}\n+\n+void\n+ether_format_addr(char *buf, uint16_t size,\n+\t\t  const struct ether_addr *eth_addr)\n+{\n+\tsnprintf(buf, size, \"%02X:%02X:%02X:%02X:%02X:%02X\",\n+\t\t eth_addr->addr_bytes[0],\n+\t\t eth_addr->addr_bytes[1],\n+\t\t eth_addr->addr_bytes[2],\n+\t\t eth_addr->addr_bytes[3],\n+\t\t eth_addr->addr_bytes[4],\n+\t\t eth_addr->addr_bytes[5]);\n+}\ndiff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h\nindex 3a87ff184900..46d40412763c 100644\n--- a/lib/librte_net/rte_ether.h\n+++ b/lib/librte_net/rte_ether.h\n@@ -204,15 +204,8 @@ static inline int is_valid_assigned_ether_addr(const struct ether_addr *ea)\n  * @param addr\n  *   A pointer to Ethernet address.\n  */\n-static inline void eth_random_addr(uint8_t *addr)\n-{\n-\tuint64_t rand = rte_rand();\n-\tuint8_t *p = (uint8_t *)&rand;\n-\n-\trte_memcpy(addr, p, ETHER_ADDR_LEN);\n-\taddr[0] &= (uint8_t)~ETHER_GROUP_ADDR;       /* clear multicast bit */\n-\taddr[0] |= ETHER_LOCAL_ADMIN_ADDR;  /* set local assignment bit */\n-}\n+void\n+eth_random_addr(uint8_t *addr);\n \n /**\n  * Fast copy an Ethernet address.\n@@ -251,18 +244,9 @@ static inline void ether_addr_copy(const struct ether_addr *ea_from,\n  * @param eth_addr\n  *   A pointer to a ether_addr structure.\n  */\n-static inline void\n+void\n ether_format_addr(char *buf, uint16_t size,\n-\t\t  const struct ether_addr *eth_addr)\n-{\n-\tsnprintf(buf, size, \"%02X:%02X:%02X:%02X:%02X:%02X\",\n-\t\t eth_addr->addr_bytes[0],\n-\t\t eth_addr->addr_bytes[1],\n-\t\t eth_addr->addr_bytes[2],\n-\t\t eth_addr->addr_bytes[3],\n-\t\t eth_addr->addr_bytes[4],\n-\t\t eth_addr->addr_bytes[5]);\n-}\n+\t\t  const struct ether_addr *eth_addr);\n \n /**\n  * Ethernet header: Contains the destination address, source address\ndiff --git a/lib/librte_net/rte_net_version.map b/lib/librte_net/rte_net_version.map\nindex 26c06e7c7ae7..49d34093781c 100644\n--- a/lib/librte_net/rte_net_version.map\n+++ b/lib/librte_net/rte_net_version.map\n@@ -13,6 +13,14 @@ DPDK_17.05 {\n \n } DPDK_16.11;\n \n+DPDK_19.08 {\n+\tglobal:\n+\n+\teth_random_addr;\n+\teth_format_addr;\n+} DPDK_17.05;\n+\n+\n EXPERIMENTAL {\n \tglobal:\n \n",
    "prefixes": [
        "RFC",
        "1/4"
    ]
}