Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53447/?format=api
{ "id": 53447, "url": "http://patches.dpdk.org/api/patches/53447/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190515180817.71523-7-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190515180817.71523-7-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190515180817.71523-7-ajit.khaparde@broadcom.com", "date": "2019-05-15T18:08:17", "name": "[6/6] net/bnxt: support bulk free of Tx mbufs", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "fa9833252bf785b4399a7cbf789355005cd8f9f7", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190515180817.71523-7-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 4678, "url": "http://patches.dpdk.org/api/series/4678/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4678", "date": "2019-05-15T18:08:11", "name": "bnxt patchset for Tx performance optimization", "version": 1, "mbox": "http://patches.dpdk.org/series/4678/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53447/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/53447/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4F0CF69D4;\n\tWed, 15 May 2019 20:08:35 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id AFF055A6A\n\tfor <dev@dpdk.org>; Wed, 15 May 2019 20:08:25 +0200 (CEST)", "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id B47EF30C0BB;\n\tWed, 15 May 2019 11:08:22 -0700 (PDT)", "from C02VPB22HTD6.wifi.broadcom.net (c02vpb22htd6.wifi.broadcom.net\n\t[10.69.74.102])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id 95919AC07C2;\n\tWed, 15 May 2019 11:08:23 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com B47EF30C0BB", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1557943702;\n\tbh=EV3OWFFZVn29XyU5y2c55a+H40GNeBkQ1cDtuMaA+xc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=mN6Rm+E69SAP7G54ba8ihxTCNjw65BfCaHJFJwQzNt0L05NNKfF5mH8G3AUflb+ud\n\tDcsxgPiKt0pcvCdw4SWmqnbsJxRulrTXT1lO/V6gh+pubmK46HiS3r9yWvZv2nfmOG\n\tAEb7K5T2t8UTArNYBsLEf9orR7PntlWvyziV08aA=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tSriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>", "Date": "Wed, 15 May 2019 11:08:17 -0700", "Message-Id": "<20190515180817.71523-7-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.20.1 (Apple Git-117)", "In-Reply-To": "<20190515180817.71523-1-ajit.khaparde@broadcom.com>", "References": "<20190515180817.71523-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 6/6] net/bnxt: support bulk free of Tx mbufs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The driver currently uses rte_pktmbuf_free() to free each mbuf\nafter transmit completion. This is optimized to free multiple\nmbufs using rte_mempool_put_bulk().\n\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nSigned-off-by: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>\n---\n drivers/net/bnxt/bnxt_txq.c | 11 ++++++++\n drivers/net/bnxt/bnxt_txq.h | 1 +\n drivers/net/bnxt/bnxt_txr.c | 50 +++++++++++++++++++++++++++++--------\n 3 files changed, 52 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_txq.c b/drivers/net/bnxt/bnxt_txq.c\nindex b9b975e4c..5a7bfaf3e 100644\n--- a/drivers/net/bnxt/bnxt_txq.c\n+++ b/drivers/net/bnxt/bnxt_txq.c\n@@ -69,6 +69,7 @@ void bnxt_tx_queue_release_op(void *tx_queue)\n \t\trte_memzone_free(txq->mz);\n \t\ttxq->mz = NULL;\n \n+\t\trte_free(txq->free);\n \t\trte_free(txq);\n \t}\n }\n@@ -110,6 +111,16 @@ int bnxt_tx_queue_setup_op(struct rte_eth_dev *eth_dev,\n \t\trc = -ENOMEM;\n \t\tgoto out;\n \t}\n+\n+\ttxq->free = rte_zmalloc_socket(NULL,\n+\t\t\t\t sizeof(struct rte_mbuf *) * nb_desc,\n+\t\t\t\t RTE_CACHE_LINE_SIZE, socket_id);\n+\tif (!txq->free) {\n+\t\tPMD_DRV_LOG(ERR, \"allocation of tx mbuf free array failed!\");\n+\t\trte_free(txq);\n+\t\trc = -ENOMEM;\n+\t\tgoto out;\n+\t}\n \ttxq->bp = bp;\n \ttxq->nb_tx_desc = nb_desc;\n \ttxq->tx_free_thresh = tx_conf->tx_free_thresh;\ndiff --git a/drivers/net/bnxt/bnxt_txq.h b/drivers/net/bnxt/bnxt_txq.h\nindex 720ca90cf..a0d4678d9 100644\n--- a/drivers/net/bnxt/bnxt_txq.h\n+++ b/drivers/net/bnxt/bnxt_txq.h\n@@ -33,6 +33,7 @@ struct bnxt_tx_queue {\n \tunsigned int\t\tcp_nr_rings;\n \tstruct bnxt_cp_ring_info\t*cp_ring;\n \tconst struct rte_memzone *mz;\n+\tstruct rte_mbuf **free;\n };\n \n void bnxt_free_txq_stats(struct bnxt_tx_queue *txq);\ndiff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt/bnxt_txr.c\nindex b15778b39..9de12e0d0 100644\n--- a/drivers/net/bnxt/bnxt_txr.c\n+++ b/drivers/net/bnxt/bnxt_txr.c\n@@ -320,6 +320,7 @@ static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt,\n \t\tRTE_VERIFY(m_seg->data_len);\n \t\ttxr->tx_prod = RING_NEXT(txr->tx_ring_struct, txr->tx_prod);\n \t\ttx_buf = &txr->tx_buf_ring[txr->tx_prod];\n+\t\ttx_buf->mbuf = m_seg;\n \n \t\ttxbd = &txr->tx_desc_ring[txr->tx_prod];\n \t\ttxbd->address = rte_cpu_to_le_64(rte_mbuf_data_iova(m_seg));\n@@ -339,24 +340,53 @@ static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt,\n static void bnxt_tx_cmp(struct bnxt_tx_queue *txq, int nr_pkts)\n {\n \tstruct bnxt_tx_ring_info *txr = txq->tx_ring;\n+\tstruct rte_mempool *pool = NULL;\n+\tstruct rte_mbuf **free = txq->free;\n \tuint16_t cons = txr->tx_cons;\n+\tunsigned int blk = 0;\n \tint i, j;\n \n \tfor (i = 0; i < nr_pkts; i++) {\n-\t\tstruct bnxt_sw_tx_bd *tx_buf;\n \t\tstruct rte_mbuf *mbuf;\n+\t\tstruct bnxt_sw_tx_bd *tx_buf = &txr->tx_buf_ring[cons];\n+\t\tunsigned short nr_bds = tx_buf->nr_bds;\n \n-\t\ttx_buf = &txr->tx_buf_ring[cons];\n-\t\tcons = RING_NEXT(txr->tx_ring_struct, cons);\n-\t\tmbuf = tx_buf->mbuf;\n-\t\ttx_buf->mbuf = NULL;\n-\n-\t\t/* EW - no need to unmap DMA memory? */\n-\n-\t\tfor (j = 1; j < tx_buf->nr_bds; j++)\n+\t\tfor (j = 0; j < nr_bds; j++) {\n+\t\t\tmbuf = tx_buf->mbuf;\n+\t\t\ttx_buf->mbuf = NULL;\n \t\t\tcons = RING_NEXT(txr->tx_ring_struct, cons);\n-\t\trte_pktmbuf_free(mbuf);\n+\t\t\ttx_buf = &txr->tx_buf_ring[cons];\n+\t\t\tif (!mbuf)\t/* long_bd's tx_buf ? */\n+\t\t\t\tcontinue;\n+\n+\t\t\tmbuf = rte_pktmbuf_prefree_seg(mbuf);\n+\t\t\tif (unlikely(!mbuf))\n+\t\t\t\tcontinue;\n+\n+\t\t\t/* EW - no need to unmap DMA memory? */\n+\n+\t\t\tif (likely(mbuf->pool == pool)) {\n+\t\t\t\t/* Add mbuf to the bulk free array */\n+\t\t\t\tfree[blk++] = mbuf;\n+\t\t\t} else {\n+\t\t\t\t/* Found an mbuf from a different pool. Free\n+\t\t\t\t * mbufs accumulated so far to the previous\n+\t\t\t\t * pool\n+\t\t\t\t */\n+\t\t\t\tif (likely(pool != NULL))\n+\t\t\t\t\trte_mempool_put_bulk(pool,\n+\t\t\t\t\t\t\t (void *)free,\n+\t\t\t\t\t\t\t blk);\n+\n+\t\t\t\t/* Start accumulating mbufs in a new pool */\n+\t\t\t\tfree[0] = mbuf;\n+\t\t\t\tpool = mbuf->pool;\n+\t\t\t\tblk = 1;\n+\t\t\t}\n+\t\t}\n \t}\n+\tif (blk)\n+\t\trte_mempool_put_bulk(pool, (void *)free, blk);\n \n \ttxr->tx_cons = cons;\n }\n", "prefixes": [ "6/6" ] }