Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53446/?format=api
{ "id": 53446, "url": "http://patches.dpdk.org/api/patches/53446/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190515180817.71523-6-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190515180817.71523-6-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190515180817.71523-6-ajit.khaparde@broadcom.com", "date": "2019-05-15T18:08:16", "name": "[5/6] net/bnxt: optimize Tx batching code", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1662665616911dded4f9f7444261987b8ac8cdfa", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190515180817.71523-6-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 4678, "url": "http://patches.dpdk.org/api/series/4678/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4678", "date": "2019-05-15T18:08:11", "name": "bnxt patchset for Tx performance optimization", "version": 1, "mbox": "http://patches.dpdk.org/series/4678/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53446/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/53446/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 877E05F72;\n\tWed, 15 May 2019 20:08:33 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id D2E7F5F14\n\tfor <dev@dpdk.org>; Wed, 15 May 2019 20:08:24 +0200 (CEST)", "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 9BBAA30C0B7;\n\tWed, 15 May 2019 11:08:22 -0700 (PDT)", "from C02VPB22HTD6.wifi.broadcom.net (c02vpb22htd6.wifi.broadcom.net\n\t[10.69.74.102])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id 77CDCAC0709;\n\tWed, 15 May 2019 11:08:23 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 9BBAA30C0B7", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1557943702;\n\tbh=Gq42Kz7Xo2g9dOVWAvDWrAc8Z+a9xqD16CN9Ue88F28=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=vVy3CGGV84mJ9C7LevpwLnBXU/WU8HFvuw91EbWK6gcPDkIkTGlgPE1Qd0qLRWxDN\n\tmo9+YOQ/BECytJPJL832kquud0I0Jc1+vmE1WNzNVajHAePTINYzbBseZa5PDF3c05\n\tjIf9ZUBS6uW5HmJBHDyk6tIyFYr9mWwP9BXGjDHg=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tSriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>,\n\tAjit Kumar Khaparde <ajit.khaparde@broadcom.com>", "Date": "Wed, 15 May 2019 11:08:16 -0700", "Message-Id": "<20190515180817.71523-6-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.20.1 (Apple Git-117)", "In-Reply-To": "<20190515180817.71523-1-ajit.khaparde@broadcom.com>", "References": "<20190515180817.71523-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 5/6] net/bnxt: optimize Tx batching code", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>\n\nThis patch adds a few optimizations to Tx batching. Instead of\nspecifying 'cmpl_next' to bnxt_start_xmit() as a hint to enable\ncompletion for a given packet, request for completion on the last\nsuccessfully enqueued TxBD. This takes care of both success and\nerror cases. It eliminates 'cmpl_next' arg and related per-packet\ncondition checks around it.\n\nFixes: 5735eb241947 (\"net/bnxt: support Tx batching\")\nSigned-off-by: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>\nReviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_txr.c | 32 +++++++++-----------------------\n 1 file changed, 9 insertions(+), 23 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt/bnxt_txr.c\nindex 186934136..b15778b39 100644\n--- a/drivers/net/bnxt/bnxt_txr.c\n+++ b/drivers/net/bnxt/bnxt_txr.c\n@@ -121,7 +121,6 @@ static inline uint32_t bnxt_tx_avail(struct bnxt_tx_queue *txq)\n static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt,\n \t\t\t\tstruct bnxt_tx_queue *txq,\n \t\t\t\tuint16_t *coal_pkts,\n-\t\t\t\tuint16_t *cmpl_next,\n \t\t\t\tstruct tx_bd_long **last_txbd)\n {\n \tstruct bnxt_tx_ring_info *txr = txq->tx_ring;\n@@ -184,12 +183,7 @@ static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt,\n \ttxbd->opaque = *coal_pkts;\n \ttxbd->flags_type = nr_bds << TX_BD_LONG_FLAGS_BD_CNT_SFT;\n \ttxbd->flags_type |= TX_BD_SHORT_FLAGS_COAL_NOW;\n-\tif (!*cmpl_next) {\n-\t\ttxbd->flags_type |= TX_BD_LONG_FLAGS_NO_CMPL;\n-\t} else {\n-\t\t*coal_pkts = 0;\n-\t\t*cmpl_next = false;\n-\t}\n+\ttxbd->flags_type |= TX_BD_LONG_FLAGS_NO_CMPL;\n \ttxbd->len = tx_pkt->data_len;\n \tif (tx_pkt->pkt_len >= 2014)\n \t\ttxbd->flags_type |= TX_BD_LONG_FLAGS_LHINT_GTE2K;\n@@ -415,10 +409,10 @@ static int bnxt_handle_tx_cp(struct bnxt_tx_queue *txq)\n uint16_t bnxt_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\t\t uint16_t nb_pkts)\n {\n-\tstruct bnxt_tx_queue *txq = tx_queue;\n+\tint rc;\n \tuint16_t nb_tx_pkts = 0;\n \tuint16_t coal_pkts = 0;\n-\tuint16_t cmpl_next = 0;\n+\tstruct bnxt_tx_queue *txq = tx_queue;\n \tstruct tx_bd_long *last_txbd = NULL;\n \n \t/* Handle TX completions */\n@@ -432,27 +426,19 @@ uint16_t bnxt_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \n \t/* Handle TX burst request */\n \tfor (nb_tx_pkts = 0; nb_tx_pkts < nb_pkts; nb_tx_pkts++) {\n-\t\tint rc;\n-\n-\t\t/* Request a completion on the last packet */\n-\t\tcmpl_next |= (nb_pkts == nb_tx_pkts + 1);\n \t\tcoal_pkts++;\n \t\trc = bnxt_start_xmit(tx_pkts[nb_tx_pkts], txq,\n-\t\t\t\t &coal_pkts, &cmpl_next, &last_txbd);\n+\t\t\t\t &coal_pkts, &last_txbd);\n \n-\t\tif (unlikely(rc)) {\n-\t\t\t/* Request a completion on the last successfully\n-\t\t\t * enqueued packet\n-\t\t\t */\n-\t\t\tif (last_txbd)\n-\t\t\t\tlast_txbd->flags_type &=\n-\t\t\t\t\t~TX_BD_LONG_FLAGS_NO_CMPL;\n+\t\tif (unlikely(rc))\n \t\t\tbreak;\n-\t\t}\n \t}\n \n-\tif (nb_tx_pkts)\n+\tif (likely(nb_tx_pkts)) {\n+\t\t/* Request a completion on the last packet */\n+\t\tlast_txbd->flags_type &= ~TX_BD_LONG_FLAGS_NO_CMPL;\n \t\tB_TX_DB(txq->tx_ring->tx_doorbell, txq->tx_ring->tx_prod);\n+\t}\n \n \treturn nb_tx_pkts;\n }\n", "prefixes": [ "5/6" ] }