Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53443/?format=api
{ "id": 53443, "url": "http://patches.dpdk.org/api/patches/53443/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190515180817.71523-2-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190515180817.71523-2-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190515180817.71523-2-ajit.khaparde@broadcom.com", "date": "2019-05-15T18:08:12", "name": "[1/6] net/bnxt: fix an issue seen with TSO", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "853ecb4d792d13314a8d15d4db8dd89ccc051ce7", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190515180817.71523-2-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 4678, "url": "http://patches.dpdk.org/api/series/4678/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4678", "date": "2019-05-15T18:08:11", "name": "bnxt patchset for Tx performance optimization", "version": 1, "mbox": "http://patches.dpdk.org/series/4678/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53443/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/53443/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 18C5B5F1C;\n\tWed, 15 May 2019 20:08:28 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 75E935B20\n\tfor <dev@dpdk.org>; Wed, 15 May 2019 20:08:24 +0200 (CEST)", "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 187F730C033;\n\tWed, 15 May 2019 11:08:22 -0700 (PDT)", "from C02VPB22HTD6.wifi.broadcom.net (c02vpb22htd6.wifi.broadcom.net\n\t[10.69.74.102])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id E268DAC0709;\n\tWed, 15 May 2019 11:08:22 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 187F730C033", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1557943702;\n\tbh=C9YrNrk8nidWJfIi0sHUUsYcEVk5ocmx0QXztDPq2bI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=AnXX7ls/r3C7qSY5h5X46QEgRC7vpAmrA1QH3FQOv+mJ1c3pAN1jXV/e5FaigAqyO\n\tOu40yM14kk7Jhs0BSodlz+FMo5rWkYL8Hd/cKcENIIk6RzHNpmuutpJ7/p+3aU3TEF\n\tpyXWkE5C4bo7ubFNuDbwi13YHrpNgH7ilSSfzjuI=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, Somnath Kotur <somnath.kotur@broadcom.com>,\n\tSriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>", "Date": "Wed, 15 May 2019 11:08:12 -0700", "Message-Id": "<20190515180817.71523-2-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.20.1 (Apple Git-117)", "In-Reply-To": "<20190515180817.71523-1-ajit.khaparde@broadcom.com>", "References": "<20190515180817.71523-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 1/6] net/bnxt: fix an issue seen with TSO", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "We wrongly update lflags in the Tx descriptor; avoid it. Also, instead of\ncalculating the last producer index to see if mbuf segments are chained,\ncheck if the pointer is NULL to iterate through the segment list.\n\nFixes: 6eb3cc2294fd (\"net/bnxt: add initial Tx code\")\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\nSigned-off-by: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>\n---\n drivers/net/bnxt/bnxt_txr.c | 15 ++++++++-------\n 1 file changed, 8 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt/bnxt_txr.c\nindex 39be7bdfa..6f55f3c53 100644\n--- a/drivers/net/bnxt/bnxt_txr.c\n+++ b/drivers/net/bnxt/bnxt_txr.c\n@@ -123,7 +123,6 @@ static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt,\n \tstruct tx_bd_long_hi *txbd1 = NULL;\n \tuint32_t vlan_tag_flags, cfa_action;\n \tbool long_bd = false;\n-\tuint16_t last_prod = 0;\n \tstruct rte_mbuf *m_seg;\n \tstruct bnxt_sw_tx_bd *tx_buf;\n \tstatic const uint32_t lhint_arr[4] = {\n@@ -143,8 +142,6 @@ static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt,\n \ttx_buf = &txr->tx_buf_ring[txr->tx_prod];\n \ttx_buf->mbuf = tx_pkt;\n \ttx_buf->nr_bds = long_bd + tx_pkt->nb_segs;\n-\tlast_prod = (txr->tx_prod + tx_buf->nr_bds - 1) &\n-\t\t\t\ttxr->tx_ring_struct->ring_mask;\n \n \tif (unlikely(bnxt_tx_avail(txr) < tx_buf->nr_bds))\n \t\treturn -ENOMEM;\n@@ -193,11 +190,17 @@ static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt,\n \t\ttxbd1->cfa_action = cfa_action;\n \n \t\tif (tx_pkt->ol_flags & PKT_TX_TCP_SEG) {\n+\t\t\tuint16_t hdr_size;\n+\n \t\t\t/* TSO */\n \t\t\ttxbd1->lflags |= TX_BD_LONG_LFLAGS_LSO;\n-\t\t\ttxbd1->hdr_size = tx_pkt->l2_len + tx_pkt->l3_len +\n+\t\t\thdr_size = tx_pkt->l2_len + tx_pkt->l3_len +\n \t\t\t\t\ttx_pkt->l4_len + tx_pkt->outer_l2_len +\n \t\t\t\t\ttx_pkt->outer_l3_len;\n+\t\t\t/* The hdr_size is multiple of 16bit units not 8bit.\n+\t\t\t * Hence divide by 2.\n+\t\t\t */\n+\t\t\ttxbd1->hdr_size = hdr_size >> 1;\n \t\t\ttxbd1->mss = tx_pkt->tso_segsz;\n \n \t\t} else if ((tx_pkt->ol_flags & PKT_TX_OIP_IIP_TCP_UDP_CKSUM) ==\n@@ -282,7 +285,7 @@ static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt,\n \n \tm_seg = tx_pkt->next;\n \t/* i is set at the end of the if(long_bd) block */\n-\twhile (txr->tx_prod != last_prod) {\n+\twhile (m_seg) {\n \t\ttxr->tx_prod = RING_NEXT(txr->tx_ring_struct, txr->tx_prod);\n \t\ttx_buf = &txr->tx_buf_ring[txr->tx_prod];\n \n@@ -295,8 +298,6 @@ static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt,\n \t}\n \n \ttxbd->flags_type |= TX_BD_LONG_FLAGS_PACKET_END;\n-\tif (txbd1)\n-\t\ttxbd1->lflags = rte_cpu_to_le_32(txbd1->lflags);\n \n \ttxr->tx_prod = RING_NEXT(txr->tx_ring_struct, txr->tx_prod);\n \n", "prefixes": [ "1/6" ] }