Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53403/?format=api
{ "id": 53403, "url": "http://patches.dpdk.org/api/patches/53403/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190514133702.2993-1-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190514133702.2993-1-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190514133702.2993-1-bruce.richardson@intel.com", "date": "2019-05-14T13:37:01", "name": "[1/2] build: shorten code for instruction set detection", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f50c856ff0794e25d30973a04258d43a1ac7fe5e", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190514133702.2993-1-bruce.richardson@intel.com/mbox/", "series": [ { "id": 4654, "url": "http://patches.dpdk.org/api/series/4654/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4654", "date": "2019-05-14T13:37:01", "name": "[1/2] build: shorten code for instruction set detection", "version": 1, "mbox": "http://patches.dpdk.org/series/4654/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53403/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/53403/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A8044E3ED;\n\tTue, 14 May 2019 15:37:10 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby dpdk.org (Postfix) with ESMTP id 5B98A6CD8\n\tfor <dev@dpdk.org>; Tue, 14 May 2019 15:37:08 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t14 May 2019 06:37:06 -0700", "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.223.2])\n\tby orsmga001.jf.intel.com with ESMTP; 14 May 2019 06:37:05 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "=?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>,\n\tBruce Richardson <bruce.richardson@intel.com>", "Date": "Tue, 14 May 2019 14:37:01 +0100", "Message-Id": "<20190514133702.2993-1-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.21.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 1/2] build: shorten code for instruction set\n\tdetection", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Rather than checking flag by flag individually, use a loop to make it\neasier to check new flags.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n config/x86/meson.build | 34 +++++++++++++---------------------\n 1 file changed, 13 insertions(+), 21 deletions(-)", "diff": "diff --git a/config/x86/meson.build b/config/x86/meson.build\nindex bb23771b4..a650a1ca8 100644\n--- a/config/x86/meson.build\n+++ b/config/x86/meson.build\n@@ -28,6 +28,19 @@ foreach f:base_flags\n \tcompile_time_cpuflags += ['RTE_CPUFLAG_' + f]\n endforeach\n \n+optional_flags = ['AES', 'PCLMUL',\n+\t\t'AVX', 'AVX2', 'AVX512F']\n+foreach f:optional_flags\n+\tif cc.get_define('__@0@__'.format(f), args: machine_args) == '1'\n+\t\tif f == 'PCLMUL' # special case flags with different defines\n+\t\t\tf = 'PCLMULQDQ'\n+\t\tendif\n+\t\tdpdk_conf.set('RTE_MACHINE_CPUFLAG_' + f, 1)\n+\t\tcompile_time_cpuflags += ['RTE_CPUFLAG_' + f]\n+\tendif\n+endforeach\n+\n+\n dpdk_conf.set('RTE_ARCH_X86', 1)\n if dpdk_conf.get('RTE_ARCH_64')\n \tdpdk_conf.set('RTE_ARCH_X86_64', 1)\n@@ -37,25 +50,4 @@ else\n \tdpdk_conf.set('RTE_ARCH', 'i686')\n endif\n \n-if cc.get_define('__AES__', args: machine_args) != ''\n-\tdpdk_conf.set('RTE_MACHINE_CPUFLAG_AES', 1)\n-\tcompile_time_cpuflags += ['RTE_CPUFLAG_AES']\n-endif\n-if cc.get_define('__PCLMUL__', args: machine_args) != ''\n-\tdpdk_conf.set('RTE_MACHINE_CPUFLAG_PCLMULQDQ', 1)\n-\tcompile_time_cpuflags += ['RTE_CPUFLAG_PCLMULQDQ']\n-endif\n-if cc.get_define('__AVX__', args: machine_args) != ''\n-\tdpdk_conf.set('RTE_MACHINE_CPUFLAG_AVX', 1)\n-\tcompile_time_cpuflags += ['RTE_CPUFLAG_AVX']\n-endif\n-if cc.get_define('__AVX2__', args: machine_args) != ''\n-\tdpdk_conf.set('RTE_MACHINE_CPUFLAG_AVX2', 1)\n-\tcompile_time_cpuflags += ['RTE_CPUFLAG_AVX2']\n-endif\n-if cc.get_define('__AVX512F__', args: machine_args) != ''\n-\tdpdk_conf.set('RTE_MACHINE_CPUFLAG_AVX512F', 1)\n-\tcompile_time_cpuflags += ['RTE_CPUFLAG_AVX512F']\n-endif\n-\n dpdk_conf.set('RTE_CACHE_LINE_SIZE', 64)\n", "prefixes": [ "1/2" ] }