Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53396/?format=api
{ "id": 53396, "url": "http://patches.dpdk.org/api/patches/53396/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190514092046.30808-4-mattias.ronnblom@ericsson.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190514092046.30808-4-mattias.ronnblom@ericsson.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190514092046.30808-4-mattias.ronnblom@ericsson.com", "date": "2019-05-14T09:20:43", "name": "[3/6] eal: improve entropy for initial PRNG seed", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0b6aeb6f232d7a07e6b68eeaa5951d3fd325d5bf", "submitter": { "id": 1077, "url": "http://patches.dpdk.org/api/people/1077/?format=api", "name": "Mattias Rönnblom", "email": "mattias.ronnblom@ericsson.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190514092046.30808-4-mattias.ronnblom@ericsson.com/mbox/", "series": [ { "id": 4650, "url": "http://patches.dpdk.org/api/series/4650/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4650", "date": "2019-05-14T09:20:40", "name": "Pseudo-random number generation improvements", "version": 1, "mbox": "http://patches.dpdk.org/series/4650/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53396/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/53396/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1BA245F1D;\n\tTue, 14 May 2019 11:21:49 +0200 (CEST)", "from sesbmg23.ericsson.net (sesbmg23.ericsson.net [193.180.251.37])\n\tby dpdk.org (Postfix) with ESMTP id 4E0F75F1B\n\tfor <dev@dpdk.org>; Tue, 14 May 2019 11:21:48 +0200 (CEST)", "from ESESBMB503.ericsson.se (Unknown_Domain [153.88.183.116])\n\tby sesbmg23.ericsson.net (Symantec Mail Security) with SMTP id\n\t60.30.10736.BA88ADC5; Tue, 14 May 2019 11:21:47 +0200 (CEST)", "from ESESBMR503.ericsson.se (153.88.183.135) by\n\tESESBMB503.ericsson.se (153.88.183.170) with Microsoft SMTP Server\n\t(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id\n\t15.1.1713.5; Tue, 14 May 2019 11:21:47 +0200", "from ESESSMB503.ericsson.se (153.88.183.164) by\n\tESESBMR503.ericsson.se (153.88.183.135) with Microsoft SMTP Server\n\t(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id\n\t15.1.1713.5; Tue, 14 May 2019 11:21:47 +0200", "from selio1a020.lmera.ericsson.se (153.88.183.153) by\n\tsmtp.internal.ericsson.com (153.88.183.191) with Microsoft SMTP\n\tServer id\n\t15.1.1713.5 via Frontend Transport; Tue, 14 May 2019 11:21:47 +0200", "from breslau.lmera.ericsson.se (breslau.lmera.ericsson.se\n\t[150.132.109.241])\n\tby selio1a020.lmera.ericsson.se (8.15.1+Sun/8.15.1) with ESMTP id\n\tx4E9LQN7027252; Tue, 14 May 2019 11:21:46 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801;\n\tc=relaxed/relaxed; \n\tq=dns/txt; i=@ericsson.com; t=1557825708; x=1560417708;\n\th=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type:\n\tContent-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From:\n\tResent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id:\n\tList-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;\n\tbh=h5GAOK7LZyMqXa8dFI/Hz/qrD/CKwXlWzZPkx0rt9vs=;\n\tb=Y16jGUA83eUHMOdBwIOBC/SHWnedtcDSmcw1uRIEhvN2cA7uN5BMoI89vGOubD9p\n\t4dNe4LHH0sBa2zxpx07JnEt6sUdUEV0DhU0Ys2qGI8DBJRwv9L+Fs9OV38YG45NX\n\txwHGW7f60c377Z5/SBG28CrGkkQLeophQSzJ3I/rWmw=;", "X-AuditID": "c1b4fb25-3b1ff700000029f0-03-5cda88ab9f24", "From": "=?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>", "To": "<dev@dpdk.org>", "CC": "<nhorman@tuxdriver.com>, <stephen@networkplumber.org>,\n\t<david.marchand@redhat.com>, <bruce.richardson@intel.com>, \n\t=?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>", "Date": "Tue, 14 May 2019 11:20:43 +0200", "Message-ID": "<20190514092046.30808-4-mattias.ronnblom@ericsson.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190514092046.30808-1-mattias.ronnblom@ericsson.com>", "References": "<20190508181014.7dde7580@xps13>\n\t<20190514092046.30808-1-mattias.ronnblom@ericsson.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"UTF-8\"", "Content-Transfer-Encoding": "8bit", "X-Brightmail-Tracker": "H4sIAAAAAAAAA+NgFvrOLMWRmVeSWpSXmKPExsUyM2J7ie7qjlsxBkuabS1urLK32L6ii83i\n\t3aftTBa3mk+yWSy+I+fA6vFrwVJWj8V7XjJ59Jycx+Txft9VNo8r31czBrBGcdmkpOZklqUW\n\t6dslcGW8XHiApWAVR0V35zqmBsY/bF2MHBwSAiYST3YndDFycQgJHGWUOLl9N3sXIyeQ841R\n\t4lWLP0QCyH7xaC8rhHORUaK96TKUc5lRYtWF08wgLWwCnhKT33WzgNgiAkISSz9eZgcpYhbY\n\tCzRq3TywhLCAvcS1uz/BGlgEVCVad3Qxgdi8Ak4S13oawWokBOQlVm84AFbDKeAsMWnKLaib\n\tUiT+9DxigagXlDg58wmYzSygKdG6/Tc7hC0v0bx1NjNEvZbE/SVfmCcwCs9C0jILScssJC0L\n\tGJlXMYoWpxYn5aYbGeulFmUmFxfn5+nlpZZsYgRGx8Etv1V3MF5+43iIUYCDUYmH1y/9VowQ\n\ta2JZcWXuIUYJDmYlEd4oxRsxQrwpiZVVqUX58UWlOanFhxilOViUxHmjV++JERJITyxJzU5N\n\tLUgtgskycXBKNTC29AYesw5Vr1k03af8mWLPcv+OuI8C8moXdYu1gww3e5ivS+H69kkncn9Z\n\txa3Wb72V/9/tTXB0qrN3Pf1p6dwFrnwKjSyHwtLPHUhJKtPN3u4Wk2TOpdO1elVpz8qu51OK\n\tU+bFMq4IOnfr6s2i/tcH1jCIK3rn8q0NlEuyvXl5orXO/U1cbUosxRmJhlrMRcWJAExYeTqK\n\tAgAA", "Subject": "[dpdk-dev] [PATCH 3/6] eal: improve entropy for initial PRNG seed", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Replace the use of rte_get_timer_cycles() with getentropy() for\nseeding the pseudo-random number generator. getentropy() provides a\nmore truly random value.\n\nSuggested-by: Stephen Hemminger <stephen@networkplumber.org>\nSigned-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>\n---\n lib/librte_eal/common/rte_random.c | 12 +++++++++++-\n 1 file changed, 11 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_eal/common/rte_random.c b/lib/librte_eal/common/rte_random.c\nindex 4d3cf5226..aafc2f7ad 100644\n--- a/lib/librte_eal/common/rte_random.c\n+++ b/lib/librte_eal/common/rte_random.c\n@@ -3,6 +3,7 @@\n */\n \n #include <stdlib.h>\n+#include <unistd.h>\n \n #include <rte_branch_prediction.h>\n #include <rte_cycles.h>\n@@ -135,5 +136,14 @@ rte_rand(void)\n \n RTE_INIT(rte_rand_init)\n {\n-\trte_srand(rte_get_timer_cycles());\n+\tuint64_t seed;\n+\tint rc;\n+\n+\trc = getentropy(&seed, sizeof(seed));\n+\n+\t/* fall back to rdtsc in case of failure */\n+\tif (rc < 0)\n+\t\tseed = rte_get_timer_cycles();\n+\n+\trte_srand(seed);\n }\n", "prefixes": [ "3/6" ] }