Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53266/?format=api
{ "id": 53266, "url": "http://patches.dpdk.org/api/patches/53266/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190503172507.5272-5-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190503172507.5272-5-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190503172507.5272-5-stephen@networkplumber.org", "date": "2019-05-03T17:25:06", "name": "[v3,4/5] examples/bond: use lcore accessor", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1032b2023229fb1ad083c808a810dd27cb579288", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190503172507.5272-5-stephen@networkplumber.org/mbox/", "series": [ { "id": 4560, "url": "http://patches.dpdk.org/api/series/4560/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4560", "date": "2019-05-03T17:25:02", "name": "prepare to make lcore_config not visible in ABI", "version": 3, "mbox": "http://patches.dpdk.org/series/4560/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53266/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/53266/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 94EE01B131;\n\tFri, 3 May 2019 19:25:26 +0200 (CEST)", "from mail-pl1-f193.google.com (mail-pl1-f193.google.com\n\t[209.85.214.193]) by dpdk.org (Postfix) with ESMTP id 9C1011B11F\n\tfor <dev@dpdk.org>; Fri, 3 May 2019 19:25:22 +0200 (CEST)", "by mail-pl1-f193.google.com with SMTP id a59so3000885pla.5\n\tfor <dev@dpdk.org>; Fri, 03 May 2019 10:25:22 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tt13sm3109578pgj.49.2019.05.03.10.25.20\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 03 May 2019 10:25:20 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=zNltVzlxvH9rabMCydlhPZChw/XgxYYGtV0k1rmfLOw=;\n\tb=Oz98T+v3l2X4wqtNc1Ek13o1MWY41BGHYNvxZm6Z56TWiA4Rt1dDYqZpgwPqc+9yu5\n\tHwMQSjVxuvkUcc8CDDmWsPovRUcXca8yMRXt7xHJTOSquFt37r7DUrA431YXoLh6iEVQ\n\taFmRDxduwxozU6Bah4bm/xW4tYX95k2z7ACLf5VKo323mo9Ru/kQg5YdNS7qj8/rxSF8\n\tdhl6sjQqHLqBedx0T5cWp87iCBBtMAhwq/JtpD1DLkDDEwK6h57NEx0ndXYMSbDmN/vk\n\tuf5Xucns1uk/nnWZeaW96wyg0GnqVsoS4PempqwVmfIjgYmmmhJZNdzsffD4XuahJ+UZ\n\tOa/w==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=zNltVzlxvH9rabMCydlhPZChw/XgxYYGtV0k1rmfLOw=;\n\tb=Z0kjM0nR8Zu1NWUOeh24YwshnBmH2bnSuMDl7N41u8gE2IEnhvI4y5SgibCv0S09U7\n\tIlh1ErAImfFSt7W4Wj33doZLoOUIRtwfl/yvmqPzTAp1L0Yu23vldUYOYBtEpzUWmzZ/\n\tfVB0bwelpxDRh+qAQEjFYVgeSCwdeHInxRCk2aPyhaZ15V4eXB6uKeDnySYZKLdtCiCm\n\tarUqhxIAmFTrGZTmBhX0NBNy+hpicgaqYjcjBwFG5kfnhF07/cPixacQK7IMQ9LwvNrZ\n\tEGEJVPHYOsfWALGus99MY/uN0TYtyzBY8L61mPRk+8/zSwRGzKY8VqV8uVYHwPJdlJGv\n\tHLCg==", "X-Gm-Message-State": "APjAAAVzZdeHX+2YrPCKsjy9m9GJVoZ14ex3XrcGdRv3Si4xZ9FEPFlL\n\tCOS8Zk6lZyFAdlqnWWJPFVTSNEoW4tA=", "X-Google-Smtp-Source": "APXvYqxhyJWEbZuN228cOUgzYlwHbZGbpaTYJR0atTWqh8a9AqAXr7MnTiqAVrTHPJxkJ0AQ2zTBbQ==", "X-Received": "by 2002:a17:902:4681:: with SMTP id\n\tp1mr12006964pld.139.1556904321584; \n\tFri, 03 May 2019 10:25:21 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Fri, 3 May 2019 10:25:06 -0700", "Message-Id": "<20190503172507.5272-5-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190503172507.5272-1-stephen@networkplumber.org>", "References": "<20190410171603.8979-1-stephen@networkplumber.org>\n\t<20190503172507.5272-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 4/5] examples/bond: use lcore accessor", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Referring to lcore_config directly is no longer recommended.\nAlso remove unnecessary assignment of slave_core_id.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n examples/bond/main.c | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)", "diff": "diff --git a/examples/bond/main.c b/examples/bond/main.c\nindex ef86194fff4a..1b35d53c8efa 100644\n--- a/examples/bond/main.c\n+++ b/examples/bond/main.c\n@@ -526,8 +526,9 @@ static void cmd_start_parsed(__attribute__((unused)) void *parsed_result,\n \tint slave_core_id = rte_lcore_id();\n \n \trte_spinlock_trylock(&global_flag_stru_p->lock);\n-\tif (global_flag_stru_p->LcoreMainIsRunning == 0)\t{\n-\t\tif (lcore_config[global_flag_stru_p->LcoreMainCore].state != WAIT)\t{\n+\tif (global_flag_stru_p->LcoreMainIsRunning == 0) {\n+\t\tif (rte_eal_get_lcore_state(global_flag_stru_p->LcoreMainCore)\n+\t\t != WAIT) {\n \t\t\trte_spinlock_unlock(&global_flag_stru_p->lock);\n \t\t\treturn;\n \t\t}\n@@ -760,7 +761,7 @@ static void prompt(__attribute__((unused)) void *arg1)\n int\n main(int argc, char *argv[])\n {\n-\tint ret;\n+\tint ret, slave_core_id;\n \tuint16_t nb_ports, i;\n \n \t/* init EAL */\n@@ -792,13 +793,13 @@ main(int argc, char *argv[])\n \tbond_port_init(mbuf_pool);\n \n \trte_spinlock_init(&global_flag_stru_p->lock);\n-\tint slave_core_id = rte_lcore_id();\n \n \t/* check state of lcores */\n \tRTE_LCORE_FOREACH_SLAVE(slave_core_id) {\n-\tif (lcore_config[slave_core_id].state != WAIT)\n-\t\treturn -EBUSY;\n+\t\tif (rte_eal_get_lcore_state(slave_core_id) != WAIT)\n+\t\t\treturn -EBUSY;\n \t}\n+\n \t/* start lcore main on core != master_core - ARP response thread */\n \tslave_core_id = rte_get_next_lcore(rte_lcore_id(), 1, 0);\n \tif ((slave_core_id >= RTE_MAX_LCORE) || (slave_core_id == 0))\n", "prefixes": [ "v3", "4/5" ] }