Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53265/?format=api
{ "id": 53265, "url": "http://patches.dpdk.org/api/patches/53265/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190503172507.5272-4-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190503172507.5272-4-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190503172507.5272-4-stephen@networkplumber.org", "date": "2019-05-03T17:25:05", "name": "[v3,3/5] bus: use lcore accessor functions", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3d857413a83f678c28194ca1f832ab1f5b79ad2b", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190503172507.5272-4-stephen@networkplumber.org/mbox/", "series": [ { "id": 4560, "url": "http://patches.dpdk.org/api/series/4560/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4560", "date": "2019-05-03T17:25:02", "name": "prepare to make lcore_config not visible in ABI", "version": 3, "mbox": "http://patches.dpdk.org/series/4560/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53265/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/53265/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4B5121B122;\n\tFri, 3 May 2019 19:25:24 +0200 (CEST)", "from mail-pf1-f195.google.com (mail-pf1-f195.google.com\n\t[209.85.210.195]) by dpdk.org (Postfix) with ESMTP id 82F3D4C77\n\tfor <dev@dpdk.org>; Fri, 3 May 2019 19:25:21 +0200 (CEST)", "by mail-pf1-f195.google.com with SMTP id 13so2892701pfw.9\n\tfor <dev@dpdk.org>; Fri, 03 May 2019 10:25:21 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tt13sm3109578pgj.49.2019.05.03.10.25.18\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 03 May 2019 10:25:18 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=Tk+THDTtwwPo1XgpH2f5PsOUp7bFrD3PI8G0F2fMdg0=;\n\tb=g5kDJNoNiOHRQtxnpRjZdzUgXvmCIqaxkUpdGX5LEdcFCxuIzwwB4S/KyTNRnFo3fq\n\tytA16sjM1te+mZHT/bH6nA1CeJCjxPDScUv+qJOUaQSaPkjxLrawSSFrL8XgnMJGbp+G\n\tX2+QlBeQsG96XROMRea2SkPJC1GIsDrp1IN93J7gnn6V4QoVirJKgMo6bIOsxhYNmgA/\n\tWhYt4qUZogP01zwVkQfVjLGLWfpapNbVXjJtHqB1O8QdWCK2oVvtxcDHRBwXrq6CE0pB\n\ty9toAdvyvDHGcr576mr3SxkiaxJg5G8XwQ9VT3/cXyvmcbIcZU8M/WaLOmAZbS5MBLDP\n\tli+g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=Tk+THDTtwwPo1XgpH2f5PsOUp7bFrD3PI8G0F2fMdg0=;\n\tb=k2sdRrTM2Uks7x/ZkSWodsK851Xfj0j9vJUhXmUqbENRs6hzLEK7wLmD9kEPOLvNe/\n\tuGS5ieew1qwHNLRUtCXHcXjMaSQZhfEakv1/aw6b0NsJZJmIBd500wkznNu98fDjM15q\n\ti/uugj+jZAWlKjVCD69wHDCp22b+Vn+SgPynKjdJVRtHDvaBecipbszBh9uGYh5oG3e6\n\t9EPiQjUjZ51Vt923k7trGHFfJB2pUJz4bBrays2WpUfJ1tBVpcol8vQI6E3GBp4+g197\n\tr5nK1MSIALJXIj+EQiGc8jR1kIIXEyrQMrESnJt8gvNWfrnL+ELviTaN2ML1PuyRFxxW\n\toCOg==", "X-Gm-Message-State": "APjAAAUNab6qv+V/ov4Cn0ilNeucQtgkAVsQHAOk4S0ASWbrZddV4bjt\n\tF2OmvZhHREmjZVsuihYvR8qxhp8aFvE=", "X-Google-Smtp-Source": "APXvYqyeawqYL1hc/2m0JNx+na4vIzQbJbK5L/MGxiqj4ffIpWnE/OOqM5hbC2Kw9JNr86JHOiUJ5A==", "X-Received": "by 2002:aa7:8190:: with SMTP id\n\tg16mr12562413pfi.92.1556904320017; \n\tFri, 03 May 2019 10:25:20 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n\tDavid Marchand <david.marchand@redhat.com>", "Date": "Fri, 3 May 2019 10:25:05 -0700", "Message-Id": "<20190503172507.5272-4-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190503172507.5272-1-stephen@networkplumber.org>", "References": "<20190410171603.8979-1-stephen@networkplumber.org>\n\t<20190503172507.5272-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 3/5] bus: use lcore accessor functions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The lcore_config structure will be hidden in future release.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nReviewed-by: David Marchand <david.marchand@redhat.com>\n---\n drivers/bus/dpaa/dpaa_bus.c | 6 ++++--\n drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 4 +++-\n 2 files changed, 7 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c\nindex ac20eccd53c1..08c822781d9d 100644\n--- a/drivers/bus/dpaa/dpaa_bus.c\n+++ b/drivers/bus/dpaa/dpaa_bus.c\n@@ -254,6 +254,7 @@ int rte_dpaa_portal_init(void *arg)\n \tunsigned int cpu, lcore = rte_lcore_id();\n \tint ret;\n \tstruct dpaa_portal *dpaa_io_portal;\n+\trte_cpuset_t cpuset;\n \n \tBUS_INIT_FUNC_TRACE();\n \n@@ -263,12 +264,13 @@ int rte_dpaa_portal_init(void *arg)\n \t\tif (lcore >= RTE_MAX_LCORE)\n \t\t\treturn -1;\n \n-\tcpu = lcore_config[lcore].core_id;\n+\tcpu = rte_lcore_to_cpu_id(lcore);\n \n \t/* Set CPU affinity for this thread.*/\n \tid = pthread_self();\n+\tcpuset = rte_lcore_cpuset(lcore);\n \tret = pthread_setaffinity_np(id, sizeof(cpu_set_t),\n-\t\t\t&lcore_config[lcore].cpuset);\n+\t\t\t\t &cpuset);\n \tif (ret) {\n \t\tDPAA_BUS_LOG(ERR, \"pthread_setaffinity_np failed on core :%u\"\n \t\t\t \" (lcore=%u) with ret: %d\", cpu, lcore, ret);\ndiff --git a/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c b/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c\nindex 7bcbde840e63..8efb24af5c6a 100644\n--- a/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c\n+++ b/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c\n@@ -366,7 +366,9 @@ dpaa2_check_lcore_cpuset(void)\n \n \tfor (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {\n \t\tfor (i = 0; i < RTE_MAX_LCORE; i++) {\n-\t\t\tif (CPU_ISSET(i, &lcore_config[lcore_id].cpuset)) {\n+\t\t\trte_cpuset_t cpuset = rte_lcore_cpuset(lcore_id);\n+\n+\t\t\tif (CPU_ISSET(i, &cpuset)) {\n \t\t\t\tRTE_LOG(DEBUG, EAL, \"lcore id = %u cpu=%u\\n\",\n \t\t\t\t\tlcore_id, i);\n \t\t\t\tif (dpaa2_cpu[lcore_id] != 0xffffffff) {\n", "prefixes": [ "v3", "3/5" ] }