Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53254/?format=api
{ "id": 53254, "url": "http://patches.dpdk.org/api/patches/53254/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190503140901.59064-5-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190503140901.59064-5-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190503140901.59064-5-bruce.richardson@intel.com", "date": "2019-05-03T14:09:01", "name": "[RFC,4/4] examples/vm_power_manager: support build using pkg-config", "commit_ref": null, "pull_url": null, "state": "rfc", "archived": true, "hash": "1e7746d647197ce53faf899e1be2ce5ec3cb3fc1", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190503140901.59064-5-bruce.richardson@intel.com/mbox/", "series": [ { "id": 4555, "url": "http://patches.dpdk.org/api/series/4555/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4555", "date": "2019-05-03T14:08:57", "name": "allow vm_power_manager to build using pkg-config", "version": 1, "mbox": "http://patches.dpdk.org/series/4555/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53254/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/53254/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 503FE5F28;\n\tFri, 3 May 2019 16:09:19 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby dpdk.org (Postfix) with ESMTP id 046145F24\n\tfor <dev@dpdk.org>; Fri, 3 May 2019 16:09:17 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t03 May 2019 07:09:17 -0700", "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.222.236])\n\tby orsmga003.jf.intel.com with ESMTP; 03 May 2019 07:09:16 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,426,1549958400\"; d=\"scan'208\";a=\"147884590\"", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "david.hunt@intel.com", "Cc": "dev@dpdk.org,\n\tBruce Richardson <bruce.richardson@intel.com>", "Date": "Fri, 3 May 2019 15:09:01 +0100", "Message-Id": "<20190503140901.59064-5-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190503140901.59064-1-bruce.richardson@intel.com>", "References": "<20190503140901.59064-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [RFC PATCH 4/4] examples/vm_power_manager: support build\n\tusing pkg-config", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The vm_power_manager example app did not check for a libdpdk pkg-config\nfile and attempt to build using that. Add support for that method of\ncompile to align the app with the other examples.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n examples/vm_power_manager/Makefile | 80 +++++++++++++++++++++++-------\n 1 file changed, 62 insertions(+), 18 deletions(-)", "diff": "diff --git a/examples/vm_power_manager/Makefile b/examples/vm_power_manager/Makefile\nindex 6e573916a..d58669b0e 100644\n--- a/examples/vm_power_manager/Makefile\n+++ b/examples/vm_power_manager/Makefile\n@@ -1,8 +1,69 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2010-2014 Intel Corporation\n \n+# binary name\n+APP = vm_power_mgr\n+\n+# all source are stored in SRCS-y\n+SRCS-y := \\\n+\tchannel_manager.c \\\n+\tchannel_monitor.c \\\n+\tmain.c \\\n+\toob_monitor_nop.c \\\n+\toob_monitor_x86.c \\\n+\tparse.c \\\n+\tpower_manager.c \\\n+\tvm_power_cli.c \\\n+\n ifneq ($(shell pkg-config --atleast-version=0.9.3 libvirt; echo $$?), 0)\n $(error vm_power_manager requires libvirt >= 0.9.3)\n+endif\n+LDLIBS += -lvirt\n+\n+ifeq ($(shell pkg-config --exists jansson; echo $$?), 0)\n+LDLIBS += $(shell pkg-config --libs jansson)\n+CFLAGS += -DUSE_JANSSON\n+endif\n+\n+\n+# Build using pkg-config variables if possible\n+$(shell pkg-config --exists libdpdk)\n+ifeq ($(.SHELLSTATUS),0)\n+\n+all: shared\n+.PHONY: shared static\n+shared: build/$(APP)-shared\n+\tln -sf $(APP)-shared build/$(APP)\n+static: build/$(APP)-static\n+\tln -sf $(APP)-static build/$(APP)\n+\n+PKGCONF=pkg-config\n+ifneq ($(DPDK_PC_PREFIX),)\n+\tPKGCONF += --define-variable=prefix=$(DPDK_PC_PREFIX)\n+endif\n+\n+LDFLAGS += $(LDLIBS) -lrte_pmd_i40e -lrte_pmd_bnxt -lrte_pmd_ixgbe \\\n+\t\t-lrte_bus_pci -lrte_bus_vdev\n+\n+PC_FILE := $(shell $(PKGCONF) --path libdpdk)\n+CFLAGS += -O3 $(shell $(PKGCONF) --cflags libdpdk)\n+LDFLAGS_SHARED = $(shell $(PKGCONF) --libs libdpdk)\n+LDFLAGS_STATIC = -Wl,-Bstatic $(shell $(PKGCONF) --static --libs libdpdk)\n+\n+build/$(APP)-shared: $(SRCS-y) Makefile $(PC_FILE) | build\n+\t$(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_SHARED)\n+\n+build/$(APP)-static: $(SRCS-y) Makefile $(PC_FILE) | build\n+\t$(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_STATIC)\n+\n+build:\n+\t@mkdir -p $@\n+\n+.PHONY: clean\n+clean:\n+\trm -f build/$(APP) build/$(APP)-static build/$(APP)-shared\n+\trmdir --ignore-fail-on-non-empty build\n+\n else\n \n ifeq ($(RTE_SDK),)\n@@ -14,26 +75,9 @@ RTE_TARGET ?= $(notdir $(abspath $(dir $(firstword $(wildcard $(RTE_SDK)/*/.conf\n \n include $(RTE_SDK)/mk/rte.vars.mk\n \n-# binary name\n-APP = vm_power_mgr\n-\n-# all source are stored in SRCS-y\n-SRCS-y := main.c vm_power_cli.c power_manager.c channel_manager.c\n-SRCS-y += channel_monitor.c parse.c\n-SRCS-y += oob_monitor_x86.c\n-SRCS-y += oob_monitor_nop.c\n-\n CFLAGS += -O3\n CFLAGS += $(WERROR_FLAGS)\n \n-LDLIBS += -lvirt\n-\n-JANSSON := $(shell pkg-config --exists jansson; echo $$?)\n-ifeq ($(JANSSON), 0)\n-LDLIBS += $(shell pkg-config --libs jansson)\n-CFLAGS += -DUSE_JANSSON\n-endif\n-\n ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y)\n \n ifeq ($(CONFIG_RTE_LIBRTE_IXGBE_PMD),y)\n@@ -58,4 +102,4 @@ endif\n \n include $(RTE_SDK)/mk/rte.extapp.mk\n \n-endif # libvirt check\n+endif # pkg-config check\n", "prefixes": [ "RFC", "4/4" ] }